Uh oh!
There was an error while loading. Please reload this page.
feat(browser): Add support for streamed spans in cultureContextIntegration - #20352
Merged
Conversation
Lms24
marked this pull request as ready for review
April 16, 2026 13:54
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d6dedf6. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
nicohrubec
approved these changes
Apr 17, 2026
| @@ -1,5 +1,4 @@ | |||
| import { defineIntegration } from '../integration'; | |||
| import { hasSpanStreamingEnabled } from '../tracing/spans/hasSpanStreamingEnabled'; | |||
Member
There was a problem hiding this comment.
seems like we are not emitting errors for unused imports during linting, should we change that?
MemberAuthor
There was a problem hiding this comment.
yeah I brought this up a while ago. +1 for erroring on lint warnings all together tbh
Member
There was a problem hiding this comment.
yes agreed, seems like warnings usually get ignored so mostly add noise
Lms24force-pushed
the
lms/feat-browser-culture-context-streamed
branch
from
April 17, 2026 12:42
3b97589 to
878ef99CompareLms24
enabled auto-merge (squash)
April 17, 2026 12:44
Uh oh!
There was an error while loading. Please reload this page.
andreiborza pushed a commit
that referenced
this pull request
Apr 20, 2026
…ration` (#20352) This PR adds span processing support for the `cultureContextIntegration` plus a few integration API additions to make span processing on an integration level easier: - `Integration::processSegmentSpan` - `Integration::processSpan` - register a `processSegmentSpan` callback on `cultureContextIntegration` that adds the attributes. All attributes are already registered in sentry conventions: https://getsentry.github.io/sentry-conventions/attributes/culture/ - adds a span streaming-specific integration test in addition to the already existing error/event-based integration test closes#20353closes#20354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds span processing support for the
cultureContextIntegrationplus a few integration API additions to make span processing on an integration level easier:Integration::processSegmentSpanIntegration::processSpanprocessSegmentSpancallback oncultureContextIntegrationthat adds the attributes. All attributes are already registered in sentry conventions: https://getsentry.github.io/sentry-conventions/attributes/culture/closes#20353
closes#20354