feat(http): refactor node:http client instrumentation for portability by isaacs · Pull Request #20393 · getsentry/sentry-javascript

isaacs · 2026-04-20T01:13:16Z

Refactor the node:http outgoing request instrumentation so that it can
be applied to non-Node.js environments by patching the http module.

Also, refactor so that the diagnostics_channel and monkeypatching paths
can share code, and so that light and normal node-core instrumentations
can share more of the functionality as well.

To facilitate this, some portable minimal types are vendored in from the
node:http module.

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Notes on test changes:

The test changes are mostly owing to the fact that more versions are covered by some of the conditions, so the test gets un-indented, because it was previously conditionalTest on a node version.
The origin span data changes from the vague (and now incorrect) auto.http.otel.http to auto.http.client for client spans. This also affects a lot of the tests.

Otherwise, all prior behavior should be unchanged, which is reflected in the integration and unit tests.

github-actions · 2026-04-20T01:57:01Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	26.31 kB	-	-
@sentry/browser - with treeshaking flags	24.8 kB	-	-
@sentry/browser (incl. Tracing)	44.2 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	46.42 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	49.16 kB	-	-
@sentry/browser (incl. Tracing, Replay)	83.58 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	73.04 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	88.26 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	100.87 kB	-	-
@sentry/browser (incl. Feedback)	43.47 kB	-	-
@sentry/browser (incl. sendFeedback)	31.12 kB	-	-
@sentry/browser (incl. FeedbackAsync)	36.21 kB	-	-
@sentry/browser (incl. Metrics)	27.62 kB	-	-
@sentry/browser (incl. Logs)	27.75 kB	-	-
@sentry/browser (incl. Metrics & Logs)	28.45 kB	-	-
@sentry/react	28.05 kB	-	-
@sentry/react (incl. Tracing)	46.42 kB	-	-
@sentry/vue	31.18 kB	-	-
@sentry/vue (incl. Tracing)	46.04 kB	-	-
@sentry/svelte	26.34 kB	-	-
CDN Bundle	28.91 kB	-0.02%	-3 B 🔽
CDN Bundle (incl. Tracing)	46.95 kB	-0.02%	-5 B 🔽
CDN Bundle (incl. Logs, Metrics)	30.34 kB	+0.01%	+2 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	48.06 kB	-0.01%	-3 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics)	69.41 kB	-0.01%	-3 B 🔽
CDN Bundle (incl. Tracing, Replay)	84.11 kB	-0.01%	-2 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	85.16 kB	+0.01%	+2 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	89.91 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	90.99 kB	-0.03%	-25 B 🔽
CDN Bundle - uncompressed	84.72 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	140.31 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	88.92 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	143.77 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	212.86 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	258.11 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	261.56 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	271.81 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	275.25 kB	-	-
@sentry/nextjs (client)	48.92 kB	-	-
@sentry/sveltekit (client)	44.67 kB	-	-
@sentry/node-core	59.82 kB	+1.19%	+700 B 🔺
@sentry/node	163.37 kB	-4.22%	-7.19 kB 🔽
@sentry/node - without tracing	72.29 kB	-25.6%	-24.87 kB 🔽
@sentry/aws-serverless	106.97 kB	-6.15%	-7 kB 🔽
@sentry/cloudflare (withSentry) - minified	165.2 kB	-	-
@sentry/cloudflare (withSentry)	417.71 kB	-	-

View base workflow run

Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.

…20393)

…ation (#20393)

…trumentation (#20393)

…ent instrumentation (#20393)

Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.

…ation (#20393)

Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.

…20393)

Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.

JPeer264

Amazing changes. LGTM.

JPeer264 · 2026-04-29T07:57:04Z

@@ -0,0 +1,86 @@
+import { createTestServer } from '@sentry-internal/test-utils';


Extremely nice that there are tests for this scenario. Maybe it makes sense to display a warning in our docs too: https://docs.sentry.io/platforms/javascript/guides/node/configuration/integrations/http/ (not sure if this is the best place to put it)

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 616a2a0. Configure here.}

isaacs · 2026-05-03T16:50:36Z

So, I added a commit to check for the OTel double-wrapping, which seems to work in any case I could think to test it. It dodges the timing issue by just checking and warning at run-time, and only prints a warning once, so it should be relatively polite. I think this is ready to merge at this point.

This was implemented for the portable Express integration, but others will need the same functionality, so make it a reusable util.

Refactor the `node:http` outgoing request instrumentation so that it can be applied to non-Node.js environments by patching the http module. Also, refactor so that the diagnostics_channel and monkeypatching paths can share code, and so that light and normal node-core instrumentations can share more of the functionality as well. To facilitate this, some portable minimal types are vendored in from the `node:http` module.

isaacs force-pushed the isaacschlueter/portable-http-integration-client branch from 1f9cef2 to 5ab332aCompare April 20, 2026 01:47

isaacs force-pushed the isaacschlueter/portable-http-integration-client branch 3 times, most recently from 18b93f6 to fd04ed5Compare April 20, 2026 16:31

isaacs force-pushed the isaacschlueter/portable-http-integration-client branch from 0877c6e to 1963717Compare April 20, 2026 19:00

isaacs marked this pull request as ready for review April 20, 2026 19:00

isaacs requested review from andreiborza and mydea April 20, 2026 19:00

sentryBot reviewed Apr 20, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/http/client-subscriptions.ts Outdated

isaacs force-pushed the isaacschlueter/portable-http-integration-client branch from 1963717 to 3e7001cCompare April 20, 2026 19:06