Uh oh!
There was an error while loading. Please reload this page.
feat(core, node): portable Connect integration - #20882
Closed
isaacs wants to merge 1 commit into
Closed
Conversation
isaacs added a commit
that referenced
this pull request
May 13, 2026
Platform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacsforce-pushed
the
isaacschlueter/portable-connect-integration
branch
from
May 13, 2026 21:30
051bd5b to
93b0b34Compareisaacs added a commit
that referenced
this pull request
May 13, 2026
Platform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacsforce-pushed
the
isaacschlueter/portable-connect-integration
branch
from
May 13, 2026 21:31
93b0b34 to
eebfaa1CompareContributor
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
isaacs added a commit
that referenced
this pull request
May 19, 2026
Platform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacsforce-pushed
the
isaacschlueter/portable-connect-integration
branch
from
May 19, 2026 19:34
eebfaa1 to
52c43e5ComparePlatform-portable Connect tracing integration in `@sentry/core` (`patchConnectModule`, `setupConnectErrorHandler`), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class. Remove OTel-specific span attribute fix-up. Spans created with correct origin (`auto.http.connect`) and op directly in the middleware.
isaacsforce-pushed
the
isaacschlueter/portable-connect-integration
branch
from
May 19, 2026 19:35
52c43e5 to
32896c0Compare| return originalHandle.apply(this, args); | ||
| }); | ||
| } catch (e) { | ||
| DEBUG_BUILD && debug.error('Failed to patch connect handle method:', e); |
Contributor
There was a problem hiding this comment.
Bug: When the handle method is called without an out callback, the stack layer added by addNewStackLayer is never removed, causing route stack corruption on subsequent calls.
Severity: HIGH
Suggested Fix
The completeStack() function should be called to clean up the stack layer after originalHandle completes, regardless of whether an out callback was provided. This can be achieved by calling it after the originalHandle.apply call, ensuring the layer is always popped.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/core/src/integrations/connect/index.ts#L254
Potential issue: The patched `handle` method calls `addNewStackLayer(req)` to push a new
layer onto the route stack. However, the corresponding cleanup function,
`completeStack()`, is only scheduled to be called within a patched `out` callback.
According to Connect.js documentation, the `out` callback is optional and often omitted
in nested application scenarios. When `handle` is invoked without `out`, a layer is
pushed but never popped. If the same request object is reused across multiple `handle`
calls, this leads to an accumulation of stale layers, corrupting the route stack and
causing `generateRoute(req)` to report incorrect route names.
Did we get this right? 👍 / 👎 to inform future reviews.
isaacs
commented
May 19, 2026
MemberAuthor
This actually needs to be somewhat re-factored to work off the now-vendored Connect integration. And, tbh, it might make more sense to go with orchestrion, and make it a v11 integration anyway. This was always a somewhat experimental low-stakes/low-value patch, so it's no great loss. Not a ton of people using Connect anyway, compared with Express and other node frameworks. Closing this for now. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 32896c0. Configure here.
| const app = connect.apply(this, args) as ConnectApp; | ||
| patchConnectApp(app, options); | ||
| return app; | ||
| } as ConnectModule; |
There was a problem hiding this comment.
Connect export loses static props
Medium Severity
patchConnectModule returns a new factory function and the Node instrumentation hook uses that as the patched connect export. Unlike the in-place Express patch, nothing copies static members from the original export (for example connect.mime), so code that reads them after Sentry.init() breaks.
Reviewed by Cursor Bugbot for commit 32896c0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform-portable Connect tracing integration in
@sentry/core(patchConnectModule,setupConnectErrorHandler), similar to portable Express integration, and rewire the Node SDK's Connect integration to call into it through the otel InstrumentationBase class.Remove OTel-specific span attribute fix-up. Spans created with correct origin (
auto.http.connect) and op directly in the middleware.