feat(core): Support array attributes for spans, logs and metrics by nicohrubec · Pull Request #20427 · getsentry/sentry-javascript

nicohrubec · 2026-04-21T16:48:02Z

Adds array attribute support for spans, logs, and metrics. Relay only supports primitive homogeneous arrays (all elements have the same primitive type). However, any attributes with non-conforming arrays will be dropped by Relay, so there is no need for runtime validation on the SDK end.

This change as is comes with a behavioral change for user-defined logs and metrics. If users previously set array attributes for logs/metrics then these were previously sent to Sentry stringified, now these will be sent as arrays. After discussion with product teams we also decided not to drop empty arrays.

Closes#20651
Closes#20438

Relay's wire contract (AttributeType enum in relay-event-schema) defines exactly five `type:` tags: boolean, integer, double, string, array. The SDK's AttributeTypeMap previously declared typed array variants (`string[]`, `integer[]`, etc.) that Relay does not recognize - these were never actually emitted because the runtime serializer only handled primitives, so array-valued attributes silently dropped. This change: - Collapses the four `x[]` variants in AttributeTypeMap into a single `array` variant whose value is `Array<string> | Array<number> | Array<boolean>`. - Extends getTypedAttributeValue to auto-detect homogeneous primitive arrays and emit `{type: 'array', value: [...]}`. - Adds an isHomogeneousPrimitiveArray guard so mixed-type and nested arrays remain unsupported (dropped by default, stringified under the fallback path). - Updates tests to cover the new typed-array path (including empty arrays, unit preservation, and mixed-type drop/stringify). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-04-21T16:58:09Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	26.88 kB	+0.05%	+12 B 🔺
@sentry/browser - with treeshaking flags	25.32 kB	+0.06%	+15 B 🔺
@sentry/browser (incl. Tracing)	44.78 kB	+0.04%	+14 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)	46.75 kB	+0.03%	+13 B 🔺
@sentry/browser (incl. Tracing, Profiling)	49.77 kB	+0.03%	+13 B 🔺
@sentry/browser (incl. Tracing, Replay)	84.41 kB	+0.02%	+13 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	73.84 kB	+0.03%	+15 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	89.11 kB	+0.02%	+13 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	101.75 kB	+0.02%	+12 B 🔺
@sentry/browser (incl. Feedback)	44.06 kB	+0.03%	+10 B 🔺
@sentry/browser (incl. sendFeedback)	31.69 kB	+0.04%	+11 B 🔺
@sentry/browser (incl. FeedbackAsync)	36.8 kB	+0.03%	+11 B 🔺
@sentry/browser (incl. Metrics)	27.97 kB	+0.05%	+13 B 🔺
@sentry/browser (incl. Logs)	28.11 kB	+0.05%	+14 B 🔺
@sentry/browser (incl. Metrics & Logs)	28.8 kB	+0.06%	+17 B 🔺
@sentry/react	28.63 kB	+0.04%	+9 B 🔺
@sentry/react (incl. Tracing)	47.05 kB	+0.05%	+19 B 🔺
@sentry/vue	31.8 kB	+0.04%	+12 B 🔺
@sentry/vue (incl. Tracing)	46.65 kB	+0.04%	+14 B 🔺
@sentry/svelte	26.9 kB	+0.05%	+12 B 🔺
CDN Bundle	29.26 kB	+0.05%	+14 B 🔺
CDN Bundle (incl. Tracing)	47.17 kB	+0.03%	+10 B 🔺
CDN Bundle (incl. Logs, Metrics)	30.64 kB	+0.05%	+13 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)	48.29 kB	+0.02%	+9 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)	69.97 kB	+0.03%	+14 B 🔺
CDN Bundle (incl. Tracing, Replay)	84.56 kB	+0.02%	+12 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	85.63 kB	+0.02%	+10 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	90.37 kB	+0.01%	+9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	91.47 kB	+0.01%	+8 B 🔺
CDN Bundle - uncompressed	86.08 kB	+0.07%	+54 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	141.53 kB	+0.04%	+54 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed	90.28 kB	+0.06%	+54 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	145 kB	+0.04%	+54 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	215.1 kB	+0.03%	+54 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	260.24 kB	+0.03%	+54 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	263.69 kB	+0.03%	+54 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	273.94 kB	+0.02%	+54 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	277.38 kB	+0.02%	+54 B 🔺
@sentry/nextjs (client)	49.56 kB	+0.04%	+17 B 🔺
@sentry/sveltekit (client)	45.27 kB	+0.04%	+16 B 🔺
@sentry/node-core	60.84 kB	+0.05%	+27 B 🔺
@sentry/node	165.98 kB	+0.02%	+28 B 🔺
@sentry/node - without tracing	73.97 kB	+0.04%	+24 B 🔺
@sentry/aws-serverless	108.07 kB	+0.02%	+20 B 🔺
@sentry/cloudflare (withSentry) - minified	170.68 kB	+0.03%	+49 B 🔺
@sentry/cloudflare (withSentry)	430.48 kB	+0.02%	+71 B 🔺

View base workflow run

Arrays that were previously dropped by the serializer now ship as native array attributes (`type: 'array'`). Update the affected integration test expectations and bump size-limit thresholds for the five bundle scenarios whose gzipped/uncompressed sizes grew from the new serializer logic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Drop the size-limit increases for the five bundle scenarios that grew from adding homogeneous primitive array support. Test expectation updates from the previous commit stay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Re-apply the size-limit bumps needed to account for the new homogeneous-primitive-array detection logic. Five scenarios grew past their thresholds: - @sentry/browser (incl. Metrics & Logs): 28 → 29 KB - CDN Bundle (incl. Logs, Metrics): 30 → 31 KB - CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed: 258.5 → 259 KB - CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed: 268 → 269 KB - CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed: 271.5 → 272 KB Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…72 KB Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

andreiborza · 2026-04-29T05:37:20Z

 }
 }
+
+function isHomogeneousPrimitiveArray(arr: unknown): arr is Array<string> | Array<number> | Array<boolean> {


q: Was it previously decided that SDKs have to guarantee homogeneity? Just wondering if we really have to iterate over the entire array for every array.

Jap fair question, we are still discussing that one 😅

Talked to ingest: We don't need any SDK-side runtime validation.

nicohrubec · 2026-04-29T07:46:25Z

Converting back to draft until we have a definitive answer for SDK validation.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit f896f3a. Configure here.}

cursor · 2026-05-04T14:10:13Z

 */
 function getTypedAttributeValue(value: unknown): TypedAttributeValue | void {
+ if (Array.isArray(value) && value.length !== 0) {
+ return { value, type: 'array' };


Mixed-type array console parameters silently dropped by Relay
Medium Severity
The getTypedAttributeValue function now converts all non-empty arrays to { type: 'array' } before the stringify fallback path is reached. This means SDK-internal sentry.message.parameter.X attributes created by createConsoleTemplateAttributes from mixed-type console args (e.g. console.log('Array:', [1, 2, 3, 'string'])) are now sent as array attributes instead of being stringified. Since Relay drops non-homogeneous arrays, these template parameters will be silently lost — a regression from the previous behavior where they were preserved as stringified values. The body text is unaffected, but structured template parameter data is lost for mixed-type arrays.
^{Reviewed by Cursor Bugbot for commit f896f3a. Configure here.}

this is basically what I described in the PR description, we can discuss it but I think this is a tradeoff we have to make. don't think we can really solve this unless we do runtime inspection of the types of elements in arrays

chargome · 2026-05-04T14:34:39Z

 export type Attributes = Record<string, TypedAttributeValue>;

-export type AttributeValueType = string | number | boolean | Array<string> | Array<number> | Array<boolean>;
+export type AttributeValueType = string | number | boolean | Array<unknown>;


h: Do we really want Array<unknown>? Every change that follows would be breaking from here on.

Narrowed it down again

chargome

chargome · 2026-05-04T15:45:57Z

 value: expect.any(Number),
 },
- // TODO: 'device.archs' is set but arrays are not yet serialized in span attributes
+ 'device.archs': {


Thanks for pulling this one in.

JPeer264 · 2026-05-05T08:50:11Z

- 'integer[]': Array<number>;
- 'double[]': Array<number>;
- 'boolean[]': Array<boolean>;
+ array: Array<string> | Array<number> | Array<boolean>;


q: Would be BigInt supported as well? I think this is a broader question actually

Mhm not sure. I assume relay enforces some number maximum but no idea what that is.

logaretm

@nicohrubec Do u think it is worth warning in debug if we detect non-homogenous attributes in the array?

Just to ease detecting this for the end user.

logaretm · 2026-05-05T19:42:20Z

- * https://github.com/getsentry/sentry-javascript/pull/18165
 */
 function getTypedAttributeValue(value: unknown): TypedAttributeValue | void {
+ if (Array.isArray(value) && value.length !== 0) {


@nicohrubec q: what happens in empty arrays? are they still stringified?

as discussed I'll switch that logic to early return for empty arrays so they get dropped for both fallback/non-fallback paths. the way it is right now if fallback is enabled we send a stringified empty array if the fallback is on

actually after further discussion we won't be dropping empty arrays (independent of fallback on/off)

Now that array attributes are serialized, `device.archs` is no longer dropped — uncomment and enable the assertions in integration tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

nicohrubecand others added 8 commits April 21, 2026 19:28

Revert ".size-limit.js" bumps
fa70b75
Drop the size-limit increases for the five bundle scenarios that grew from adding homogeneous primitive array support. Test expectation updates from the previous commit stay. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Merge branch 'develop' into nh/array-attribute-support
aa3b2b1

types
467dfcc

Merge branch 'develop' into nh/array-attribute-support
5f62ad7

formatting
4b05596

Merge branch 'develop' into nh/array-attribute-support
e852120

nicohrubec marked this pull request as ready for review April 28, 2026 11:16

nicohrubec marked this pull request as draft April 28, 2026 11:16

nicohrubec changed the title ~~feat(core): Support homogeneous primitive arrays as span attributes~~feat(core): Support homogeneous primitive arrays as span/metric/log attributesApr 28, 2026

cursorBot reviewed Apr 28, 2026
View reviewed changes

Comment threadpackages/core/src/attributes.ts Outdated

guard against nan
7cd226a

nicohrubec marked this pull request as ready for review April 28, 2026 11:37

nicohrubec mentioned this pull request Apr 28, 2026
feat(core): Emit sentry.sdk.integrations on streamed segment spans #20428
Merged

chore(size-limit): Bump CDN Tracing+Replay+Feedback uncompressed to 2…
735bbe8
…72 KB Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

nicohrubec requested review from andreiborza, chargome and mydea April 28, 2026 12:04

andreiborza approved these changes Apr 29, 2026
View reviewed changes

nicohrubec marked this pull request as draft April 29, 2026 07:46

Merge branch 'develop' into nh/array-attribute-support
d9a8974

chargome reviewed Apr 29, 2026
View reviewed changes

Comment threadpackages/core/src/attributes.ts Outdated
Comment threadpackages/core/src/attributes.ts Outdated

nicohrubecand others added 4 commits May 4, 2026 13:57

no runtime validation
a26bdc0

Merge branch 'develop' into nh/array-attribute-support
50bdc74

add changelog
cb94756

update changelog
fa0dbde

nicohrubec marked this pull request as ready for review May 4, 2026 12:48

nicohrubec requested review from a team as code owners May 4, 2026 12:48

nicohrubec changed the title ~~feat(core): Support homogeneous primitive arrays as span/metric/log attributes~~feat(core): Support array attributes for spans, logs and metricsMay 4, 2026

nicohrubecand others added 3 commits May 4, 2026 15:42

fix test
01a6851

Merge branch 'develop' into nh/array-attribute-support
20adc34

fix test
f896f3a

sentryBot reviewed May 4, 2026
View reviewed changes

Comment threadpackages/core/src/attributes.ts Outdated

cursorBot reviewed May 4, 2026
View reviewed changes

chargome reviewed May 4, 2026
View reviewed changes

nicohrubec added 3 commits May 4, 2026 17:32

.
f76bca2

.
1538b0d

.
f24852d

chargome approved these changes May 4, 2026
View reviewed changes

JPeer264 approved these changes May 5, 2026
View reviewed changes

logaretm approved these changes May 5, 2026
View reviewed changes

logaretm reviewed May 5, 2026
View reviewed changes

nicohrubecand others added 3 commits May 7, 2026 10:51

emit empty arrays
516cb6a

Merge branch 'develop' into nh/array-attribute-support
15ebfc1

fix(tests): Expect device.archs array attribute in streamed span tests
6f10a4f
Now that array attributes are serialized, `device.archs` is no longer dropped — uncomment and enable the assertions in integration tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

nicohrubec marked this pull request as draft May 7, 2026 17:32

nicohrubec marked this pull request as ready for review May 12, 2026 14:25

nicohrubec added 2 commits May 12, 2026 20:54

Merge branch 'develop' into nh/array-attribute-support
6ecadb5

Merge branch 'develop' into nh/array-attribute-support
068b6f8

nicohrubec merged commit 16eab59 into developMay 13, 2026
521 of 524 checks passed

nicohrubec deleted the nh/array-attribute-support branch May 13, 2026 07:45

sentry-release-botBot mentioned this pull request May 26, 2026
publish: getsentry/sentry-javascript@10.54.0 getsentry/publish#8271
Closed
47 tasks

This was referenced May 26, 2026
Add assertion for 'device.archs' once array attributes are supported #20651
Closed
Enable array attribute support in the SDK #20438
Closed

nicohrubec mentioned this pull request Aug 6, 2026
ref(server-utils): Remove array JSON-stringify fallback in Vercel AI integration #23102
Merged

Uh oh!

Uh oh!

Conversation

nicohrubec commented Apr 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Apr 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicohrubec commented Apr 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

cursorBotMay 4, 2026

Choose a reason for hiding this comment

Mixed-type array console parameters silently dropped by Relay

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

logaretm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nicohrubec commented Apr 21, 2026•
edited
Loading

github-actionsBot commented Apr 21, 2026•
edited
Loading