Uh oh!
There was an error while loading. Please reload this page.
feat(core): Emit sentry.sdk.integrations on streamed segment spans - #20428
Merged
Conversation
Contributor
size-limit report 📦
|
nicohrubecforce-pushed
the
nh/span-streaming-sdk-integrations
branch
5 times, most recently
from
April 28, 2026 11:56
db34ebc to
ffe7af4Comparenicohrubecforce-pushed
the
nh/span-streaming-sdk-integrations
branch
3 times, most recently
from
May 13, 2026 07:16
b03ea96 to
d394c8eCompare…eaming In the classic (non-streaming) pipeline, SDK integrations ride on the transaction event wrapper via `event.sdk.integrations`. The span streaming pipeline emits segment spans directly as span envelope items with no transaction wrapper, so that metadata never reaches ingest. Add `sentry.sdk.integrations` as a native array attribute on segment spans (matching the wire contract Relay expects: `type: 'array'`). Relies on the homogeneous-primitive-array serializer support. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ations Segment spans now ship a sentry.sdk.integrations attribute listing the active SDK integrations. Add the attribute to the full-shape assertions in the browser unit test, the browser/node/cloudflare streamed integration tests, and the Deno e2e test. Matching uses expect.arrayContaining against the explicit integrations configured in each scenario, to stay resilient to default-integration churn. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
oxfmt wants the SEMANTIC_ATTRIBUTE_SENTRY_SDK_INTEGRATIONS entries broken across multiple lines because they exceed the max line length. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… expectation Same fix applied to node-integration-tests earlier — the node-core-integration-tests streamed basic-usage scenario also needs sentry.sdk.integrations in its full-shape assertion. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nicohrubecforce-pushed
the
nh/span-streaming-sdk-integrations
branch
from
May 13, 2026 07:49
d394c8e to
b8aa456Comparesentry.sdk.integrations on streamed segment spansnicohrubec
marked this pull request as ready for review
May 13, 2026 08:00
| } | ||
| function applySdkMetadataToSegmentSpan(segmentSpanJSON: StreamedSpanJSON, client: Client): void { | ||
| const integrationNames = client.getOptions().integrations.map(i => i.name); |
Member
There was a problem hiding this comment.
m: Do we need to call this on every capture? We could cache it maybe once?
MemberAuthor
There was a problem hiding this comment.
yep true that should work, changed it
Uh oh!
There was an error while loading. Please reload this page.
JPeer264
approved these changes
May 13, 2026
| function applySdkMetadataToSegmentSpan(segmentSpanJSON: StreamedSpanJSON, client: Client): void { | ||
| let integrationNames = integrationNamesCache.get(client); | ||
| if (!integrationNames) { | ||
| integrationNames = client.getOptions().integrations.map(i => i.name); |
Member
There was a problem hiding this comment.
q: Is the order important here? E.g. if one has "InboundFilters", "BrowserTracing" and another has "BrowserTracing", "InboundFilters". Also should duplicates be removed (not that it happens, but you never know)?
MemberAuthor
There was a problem hiding this comment.
I don't think it matters. This is also now directly aligned with how this has been implemented in the transaction path for the past 3 years so I'd assume we would have heard about this by now if it would be an issue
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 585ce8c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
…ns is populated Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chargome
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the classic (non-streaming) pipeline, SDK integrations are sets on the transaction event wrapper via
event.sdk.integrations. In the streaming path this metadata is currently missing. This PR setssentry.sdk.integrationson streamed segment spans.