Skip to content

feat(deno): Add processSegmentSpan to Deno context integration - #20613

Merged
chargome merged 3 commits into
developfrom
cg/deno-context-span-first
May 4, 2026
Merged

feat(deno): Add processSegmentSpan to Deno context integration#20613
chargome merged 3 commits into
developfrom
cg/deno-context-span-first

Conversation

@chargome

@chargomechargome commented Apr 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Adds processSegmentSpan to the denoContextIntegration for span streaming support.

Attributes added in getsentry/sentry-conventions#347

closes#20381

@chargomechargome self-assigned this Apr 30, 2026
@github-actions

github-actionsBot commented Apr 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser26.31 kB--
@sentry/browser - with treeshaking flags24.8 kB--
@sentry/browser (incl. Tracing)44.2 kB--
@sentry/browser (incl. Tracing + Span Streaming)46.42 kB--
@sentry/browser (incl. Tracing, Profiling)49.16 kB--
@sentry/browser (incl. Tracing, Replay)83.58 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags73.04 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)88.26 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)100.87 kB--
@sentry/browser (incl. Feedback)43.47 kB--
@sentry/browser (incl. sendFeedback)31.12 kB--
@sentry/browser (incl. FeedbackAsync)36.21 kB--
@sentry/browser (incl. Metrics)27.62 kB--
@sentry/browser (incl. Logs)27.75 kB--
@sentry/browser (incl. Metrics & Logs)28.45 kB--
@sentry/react28.05 kB--
@sentry/react (incl. Tracing)46.42 kB--
@sentry/vue31.18 kB--
@sentry/vue (incl. Tracing)46.04 kB--
@sentry/svelte26.34 kB--
CDN Bundle28.91 kB--
CDN Bundle (incl. Tracing)46.95 kB--
CDN Bundle (incl. Logs, Metrics)30.34 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)48.06 kB--
CDN Bundle (incl. Replay, Logs, Metrics)69.41 kB--
CDN Bundle (incl. Tracing, Replay)84.11 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)85.16 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)89.91 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)91.01 kB--
CDN Bundle - uncompressed84.72 kB--
CDN Bundle (incl. Tracing) - uncompressed140.31 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed88.92 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed143.77 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed212.86 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed258.11 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed261.56 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed271.81 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed275.25 kB--
@sentry/nextjs (client)48.92 kB--
@sentry/sveltekit (client)44.67 kB--
@sentry/node-core59.13 kB+0.02%+11 B 🔺
@sentry/node170.42 kB+0.01%+11 B 🔺
@sentry/node - without tracing97 kB+0.01%+8 B 🔺
@sentry/aws-serverless113.85 kB+0.03%+33 B 🔺
@sentry/cloudflare (withSentry) - minified165.2 kB--
@sentry/cloudflare (withSentry)417.71 kB--

View base workflow run

@chargome
chargome marked this pull request as ready for review May 4, 2026 08:40
@chargome
chargome requested a review from a team as a code ownerMay 4, 2026 08:40
@chargome
chargome requested a review from nicohrubecMay 4, 2026 08:41
sentry[bot]
sentryBot reviewed May 4, 2026
View reviewed changes
Comment threadpackages/deno/src/integrations/context.ts Outdated
JPeer264
JPeer264 approved these changes May 4, 2026
View reviewed changes

@JPeer264JPeer264 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

Comment threaddev-packages/e2e-tests/test-applications/deno-streamed/tests/spans.test.ts
Comment threadpackages/deno/src/integrations/context.ts Outdated
nicohrubec
nicohrubec reviewed May 4, 2026
View reviewed changes
Comment threadpackages/deno/src/integrations/context.ts Outdated
@chargome
chargome requested a review from nicohrubecMay 4, 2026 11:28
cursor[bot]
cursorBot reviewed May 4, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4785e50. Configure here.

Comment threadpackages/deno/src/integrations/context.ts
nicohrubec
nicohrubec approved these changes May 4, 2026
View reviewed changes

@nicohrubecnicohrubec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. let's just open a ticket so we don't forget to add the assertion

@chargomechargome mentioned this pull request May 4, 2026
Closed
@chargome
chargome merged commit 9a4b9b2 into developMay 4, 2026
256 checks passed
@chargome
chargome deleted the cg/deno-context-span-first branch May 4, 2026 13:19
@chargomechargome mentioned this pull request May 5, 2026
Merged
nicohrubec added a commit that referenced this pull request May 7, 2026
@chargome@claude@nicohrubec
feat(node-core): AddprocessSegmentSpanto node context integration (…
e185818
…#20678)
Adds `processSegmentSpan` to the `nodeContextIntegration` for span
streaming support.
Node equivalent to
#20613
closes https://linear.app/getsentry/issue/JS-2219
---------
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Nicolas Hrubec <nico.hrubec@sentry.io>
@sentry-release-botsentry-release-botBot mentioned this pull request May 7, 2026
Closed
47 tasks
@github-actionsgithub-actionsBot mentioned this pull request May 7, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@JPeer264JPeer264JPeer264 approved these changes
@nicohrubecnicohrubecnicohrubec approved these changes

Assignees

@chargomechargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Event processor migration: Deno Context

3 participants

@chargome@JPeer264@nicohrubec