Skip to content

feat(node): use ioredis tracing channels - #21187

Merged
isaacs merged 3 commits into
developfrom
awad/ioredis-tracing-channels
May 28, 2026
Merged

feat(node): use ioredis tracing channels#21187
isaacs merged 3 commits into
developfrom
awad/ioredis-tracing-channels

Conversation

@logaretm

@logaretmlogaretm commented May 27, 2026

Copy link
Copy Markdown
Member

ioredis5.11 released tracing channels so we can start using them in the integration, I followed the same strategy we established with redis client by limiting the patching to older releases and subscribing anyways which will be inert except for newer releases.

I added similar tests as well to ensure both dc and non-dc paths still work.

This is not to be confused with the redis client, there is two of them, redis and ioredis, the latter being older but more popular.

@github-actions

github-actionsBot commented May 27, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.17 kB--
@sentry/browser - with treeshaking flags25.62 kB--
@sentry/browser (incl. Tracing)45.25 kB--
@sentry/browser (incl. Tracing + Span Streaming)47.47 kB--
@sentry/browser (incl. Tracing, Profiling)50.22 kB--
@sentry/browser (incl. Tracing, Replay)84.83 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.39 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)89.53 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.15 kB--
@sentry/browser (incl. Feedback)44.34 kB--
@sentry/browser (incl. sendFeedback)31.98 kB--
@sentry/browser (incl. FeedbackAsync)37.08 kB--
@sentry/browser (incl. Metrics)28.25 kB--
@sentry/browser (incl. Logs)28.48 kB--
@sentry/browser (incl. Metrics & Logs)29.19 kB--
@sentry/react28.99 kB--
@sentry/react (incl. Tracing)47.51 kB--
@sentry/vue32.2 kB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)47.16 kB--
@sentry/svelte27.19 kB--
CDN Bundle29.55 kB--
CDN Bundle (incl. Tracing)47.81 kB--
CDN Bundle (incl. Logs, Metrics)31.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.04 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.31 kB--
CDN Bundle (incl. Tracing, Replay)85.18 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.35 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.05 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.21 kB--
CDN Bundle - uncompressed87.59 kB--
CDN Bundle (incl. Tracing) - uncompressed144.09 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed92.08 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed147.85 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed216.81 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed262.87 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed266.61 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed276.57 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed280.3 kB--
@sentry/nextjs (client)50.03 kB--
@sentry/sveltekit (client)45.68 kB--
@sentry/core/server75.93 kB--
@sentry/core/browser63.09 kB--
@sentry/node-core61.95 kB+0.01%+2 B 🔺
@sentry/node130.43 kB+0.04%+46 B 🔺
@sentry/node - without tracing74.36 kB--
@sentry/aws-serverless86.56 kB--
@sentry/cloudflare (withSentry) - minified171.5 kB--
@sentry/cloudflare (withSentry)429.29 kB--

View base workflow run

@logaretm
logaretm marked this pull request as ready for review May 27, 2026 13:05
@logaretm
logaretm requested a review from a team as a code ownerMay 27, 2026 13:05
@logaretm
logaretm requested review from JPeer264, andreiborza and isaacs and removed request for a teamMay 27, 2026 13:05
Comment threadpackages/node/src/integrations/tracing/redis/redis-dc-subscriber.ts Outdated
@JPeer264

Copy link
Copy Markdown
Member

I think we should wait for #21087 to be merged (or built upon it) as it got some refactorings as well.

cc @isaacs

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3f5a18b. Configure here.

logaretmand others added 3 commits May 28, 2026 15:28
Co-Authored-By: GPT-5 Codex <codex@openai.com>
Co-Authored-By: GPT-5 Codex <codex@openai.com>
Co-Authored-By: GPT-5 Codex <codex@openai.com>
@logaretm
logaretmforce-pushed the awad/ioredis-tracing-channels branch from 0f096bb to f288f8aCompareMay 28, 2026 19:28
@isaacs

Copy link
Copy Markdown
Member

I think we should wait for #21087 to be merged (or built upon it) as it got some refactorings as well.

I kind of disagree. It's not too hard to land this, and then rework 21087 to incorporate both. Then the next step will be a cleanup of the span attribute keys and channel constant names.

Landing this now, and I'll have updates to the other PR by EOD us/west time.

@isaacs
isaacs enabled auto-merge (squash) May 28, 2026 19:34
@isaacs
isaacs merged commit 40c6e62 into developMay 28, 2026
265 of 266 checks passed
@isaacs
isaacs deleted the awad/ioredis-tracing-channels branch May 28, 2026 19:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@logaretm@JPeer264@isaacs