feat(deno): redis diagnostics channel based integration for deno by isaacs · Pull Request #21087 · getsentry/sentry-javascript

isaacs · 2026-05-20T21:20:26Z

Refactor the redis and ioredis diagnostics_channel integration logic into core/src/integrations, and create a Deno integration that uses the same patterns.

Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration adds _sentrySpan onto the data in a RedisTracingChannelFactory which is passed to the core utility.

Add deno-redis e2e test covering both redis clients.

fix: #21221
fix: JS-2630

github-actions · 2026-05-20T21:30:26Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	27.17 kB	-	-
@sentry/browser - with treeshaking flags	25.62 kB	-	-
@sentry/browser (incl. Tracing)	45.25 kB	-	-
@sentry/browser (incl. Tracing + Span Streaming)	47.47 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	50.22 kB	-	-
@sentry/browser (incl. Tracing, Replay)	84.83 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	74.39 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	89.53 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	102.15 kB	-	-
@sentry/browser (incl. Feedback)	44.34 kB	-	-
@sentry/browser (incl. sendFeedback)	31.98 kB	-	-
@sentry/browser (incl. FeedbackAsync)	37.08 kB	-	-
@sentry/browser (incl. Metrics)	28.25 kB	-	-
@sentry/browser (incl. Logs)	28.48 kB	-	-
@sentry/browser (incl. Metrics & Logs)	29.19 kB	-	-
@sentry/react	28.99 kB	-	-
@sentry/react (incl. Tracing)	47.51 kB	-	-
@sentry/vue	32.2 kB	-	-
@sentry/vue (incl. Tracing)	47.16 kB	-	-
@sentry/svelte	27.19 kB	-	-
CDN Bundle	29.55 kB	-	-
CDN Bundle (incl. Tracing)	47.81 kB	-	-
CDN Bundle (incl. Logs, Metrics)	31.05 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics)	49.04 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics)	70.31 kB	-	-
CDN Bundle (incl. Tracing, Replay)	85.18 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)	86.35 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	91.05 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)	92.21 kB	-	-
CDN Bundle - uncompressed	87.59 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	144.09 kB	-	-
CDN Bundle (incl. Logs, Metrics) - uncompressed	92.08 kB	-	-
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed	147.85 kB	-	-
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed	216.81 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	262.87 kB	-	-
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed	266.61 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	276.57 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed	280.3 kB	-	-
@sentry/nextjs (client)	50.03 kB	-	-
@sentry/sveltekit (client)	45.68 kB	-	-
@sentry/core/server	76.56 kB	+0.83%	+628 B 🔺
@sentry/core/browser	63.09 kB	-	-
@sentry/node-core	61.69 kB	-	-
@sentry/node	130.51 kB	+0.09%	+112 B 🔺
@sentry/node - without tracing	74.1 kB	-	-
@sentry/aws-serverless	86.29 kB	-	-
@sentry/cloudflare (withSentry) - minified	171.5 kB	-	-
@sentry/cloudflare (withSentry)	429.29 kB	-	-

View base workflow run

) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.

…no (#21087)

… for deno (#21087)

…gration for deno (#21087)

) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.

…no (#21087)

… for deno (#21087)

…gration for deno (#21087)

) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.

github-actions · 2026-05-25T11:28:34Z

👋 @mydea, @andreiborza — Please review this PR when you get a chance!

) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.

JPeer264

LGTM, just have one m which I want to get sorted before approving

github-actions · 2026-05-28T11:20:11Z

👋 @mydea, @andreiborza — Please review this PR when you get a chance!

logaretm

Do u think we can merge this first

#21187

since it will also allow this PR to do it for both ioredis and redis clients.

JPeer264 · 2026-05-28T13:11:05Z

Do u think we can merge this first

I'm personally fine with this. Approved the other PR, waiting for @isaacs decision.

) Refactor the redis-dc integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration just adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test.

) Refactor the redis and ioredis diagnostics_channel integration logic into core/src/integrations, and create a Deno integration that uses the same patterns. Instead of the @sentry/opentelemetry/tracing-channel, the Deno integration adds `_sentrySpan` onto the data in a RedisTracingChannelFactory which is passed to the core utility. Add deno-redis e2e test covering both redis clients. fix: #21221 fix: JS-2630

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ebbbc65. Configure here.}

JPeer264

LGTM. Lint is failing, but it looks like a small change.

logaretm · 2026-05-29T09:10:03Z

+): void {
+ const channel = tracingChannel<T>(channelName, data => {
+ const args = getCommandArgs(data);
+ const statement = safeSerialize(data.command, args);


m: tracing channels on redis already sanitize the command statements or is that a different thing?
https://github.com/redis/ioredis/blob/main/lib/tracing.ts#L10-L22
https://github.com/logaretm/node-redis/blob/master/packages/client/lib/client/tracing.ts#L39-L44
It was based off the one implemented by OTEL originally, and Redis team wanted Redis to own that part.

Ooh, good catch. Yes, this was ported in from the otel implementation, and looks like we missed it the first time around, but it's just spinning extra CPU cycles unnecessarily, since the dc publishers already do this for us.

This also means we don't have to handle Uint8Array/Buffer args, which simplifies it even further, actually.

@logaretm Ended up being a pretty big diff. Care to take another look at that bit? 489eee9

…no (#21087)

… for deno (#21087)

…gration for deno (#21087)

…ed integration for deno (#21087)

isaacs requested a review from a team as a code owner May 20, 2026 21:20

isaacs requested review from andreiborza and mydea and removed request for a teamMay 20, 2026 21:20

isaacs force-pushed the isaacs/deno-redis-dc branch from f176fd8 to 0fc320cCompare May 20, 2026 22:13

isaacs added a commit that referenced this pull request May 20, 2026
fixup! feat(deno): redis diagnostics channel based integration for de…
1048f32
…no (#21087)

isaacs added a commit that referenced this pull request May 20, 2026
fixup! feat(deno): redis diagnostics channel based integration for de…
72be1fa
…no (#21087)

isaacs force-pushed the isaacs/deno-redis-dc branch from 1048f32 to 72be1faCompare May 20, 2026 22:18

cursorBot reviewed May 20, 2026
View reviewed changes

Comment thread.github/workflows/build.yml

isaacs added a commit that referenced this pull request May 21, 2026
fixup! fixup! feat(deno): redis diagnostics channel based integration…
65371f4
… for deno (#21087)

isaacs added a commit that referenced this pull request May 21, 2026
fixup! fixup! fixup! feat(deno): redis diagnostics channel based inte…
11525d8
…gration for deno (#21087)

isaacs force-pushed the isaacs/deno-redis-dc branch from 11525d8 to a8d3cb7Compare May 21, 2026 17:31

cursorBot reviewed May 21, 2026
View reviewed changes

Comment threadpackages/deno/src/integrations/redis.ts Outdated
Comment threadpackages/core/src/integrations/redis/redis-statement-serializer.ts Outdated

isaacs added a commit that referenced this pull request May 21, 2026
fixup! feat(deno): redis diagnostics channel based integration for de…
fcc2244
…no (#21087)

sentryBot reviewed May 21, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/redis/redis-dc-subscriber.ts
Comment threadpackages/node/src/integrations/tracing/redis/index.ts

isaacs added a commit that referenced this pull request May 21, 2026
fixup! fixup! feat(deno): redis diagnostics channel based integration…
0f21211
… for deno (#21087)

sentryBot reviewed May 21, 2026
View reviewed changes

Comment threadpackages/node/src/utils/redisCache.ts

cursorBot reviewed May 21, 2026
View reviewed changes

Comment threadpackages/deno/src/sdk.ts Outdated

isaacs added a commit that referenced this pull request May 21, 2026
fixup! fixup! fixup! feat(deno): redis diagnostics channel based inte…
8226aaf
…gration for deno (#21087)

isaacs added a commit that referenced this pull request May 21, 2026
fixup! fixup! fixup! feat(deno): redis diagnostics channel based inte…
5863e6c
…gration for deno (#21087)

isaacs force-pushed the isaacs/deno-redis-dc branch from 8226aaf to 5863e6cCompare May 21, 2026 21:54

isaacs enabled auto-merge (squash) May 21, 2026 23:10

isaacs force-pushed the isaacs/deno-redis-dc branch from 5863e6c to cd298faCompare May 22, 2026 17:01

cursorBot reviewed May 22, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/redis/redis-statement-serializer.ts Outdated

isaacs force-pushed the isaacs/deno-redis-dc branch from e46685b to 1f6c601Compare May 27, 2026 18:47

cursorBot reviewed May 27, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/redis/redis-statement-serializer.ts Outdated

JPeer264 reviewed May 28, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/redis/redis-dc-subscriber.ts Outdated
Comment threadpackages/core/src/integrations/redis/redis-dc-subscriber.ts
Comment threadpackages/core/src/integrations/redis/redis-dc-subscriber.ts

JPeer264 reviewed May 28, 2026
View reviewed changes

Comment threadpackages/core/src/server-exports.ts

JPeer264 mentioned this pull request May 28, 2026
feat(node): use ioredis tracing channels #21187
Merged

mydea requested review from logaretm and nicohrubec and removed request for mydea May 28, 2026 12:35

logaretm reviewed May 28, 2026
View reviewed changes

isaacs force-pushed the isaacs/deno-redis-dc branch from 1f6c601 to 6a2f9b6Compare May 28, 2026 18:29

isaacs force-pushed the isaacs/deno-redis-dc branch from 6a2f9b6 to ebbbc65Compare May 29, 2026 01:55

isaacs requested review from JPeer264 and logaretm May 29, 2026 01:55

cursorBot reviewed May 29, 2026
View reviewed changes

Comment threadpackages/core/src/integrations/redis/redis-dc-subscriber.ts Outdated

JPeer264 approved these changes May 29, 2026
View reviewed changes

logaretm reviewed May 29, 2026
View reviewed changes

isaacs added 2 commits May 29, 2026 07:37

fixup! feat(deno): redis diagnostics channel based integration for de…
408eec7
…no (#21087)

fixup! fixup! feat(deno): redis diagnostics channel based integration…
0e0f02b
… for deno (#21087)

isaacs disabled auto-merge May 29, 2026 14:39

isaacs added 2 commits May 29, 2026 08:00

fixup! fixup! fixup! feat(deno): redis diagnostics channel based inte…
489eee9
…gration for deno (#21087)

fixup! fixup! fixup! fixup! feat(deno): redis diagnostics channel bas…
66ba343
…ed integration for deno (#21087)

logaretm approved these changes May 29, 2026
View reviewed changes

isaacs merged commit 18fbbb7 into developMay 29, 2026
266 of 267 checks passed

isaacs deleted the isaacs/deno-redis-dc branch May 29, 2026 16:49

sentry-release-botBot mentioned this pull request Jun 2, 2026
publish: getsentry/sentry-javascript@10.56.0 getsentry/publish#8374
Closed
48 tasks

github-actionsBot mentioned this pull request Jun 2, 2026
feat(deno): redis diagnostics channel based integration for deno #21221
Closed

Uh oh!

Uh oh!

Conversation

isaacs commented May 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented May 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 25, 2026

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 28, 2026

Uh oh!

logaretm left a comment

Choose a reason for hiding this comment

Uh oh!

JPeer264 commented May 28, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JPeer264 left a comment

Choose a reason for hiding this comment

Uh oh!

logaretmMay 29, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacsMay 29, 2026

Choose a reason for hiding this comment

Uh oh!

isaacsMay 29, 2026

Choose a reason for hiding this comment

Uh oh!

isaacsMay 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

isaacs commented May 20, 2026•
edited
Loading

github-actionsBot commented May 20, 2026•
edited
Loading

logaretmMay 29, 2026•
edited
Loading