Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare): Auto instrument D1 based on env - #21276
Merged
Conversation
Contributor
size-limit report 📦
|
Deprecate `instrumentD1WithSentry` in favor of automatic D1 instrumentation via `instrumentEnv`. Add `isD1Database` duck-type check and `instrumentD1` with `ensureInstrumented` to prevent double instrumentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JPeer264force-pushed
the
jp/deprecate-d1-instrument-via-env
branch
from
June 2, 2026 08:44
f139295 to
59c5ec0CompareJPeer264
marked this pull request as ready for review
June 2, 2026 11:37
JPeer264
requested review from
andreiborza, isaacs, mydea and nicohrubec
and removed request for
a team and mydeaJune 2, 2026 11:37
andreiborza
approved these changes
Jun 3, 2026
Comment on lines
+151
to
+152
| * @deprecated `withSentry()` automatically instruments all D1 bindings via `env` | ||
| * so this function is not needed anymore. |
Member
There was a problem hiding this comment.
l: Maybe we can call out that this will go away in the next major?
…cation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
andreiborza
approved these changes
Jun 3, 2026
JPeer264
enabled auto-merge (squash)
June 3, 2026 13:40
Uh oh!
There was an error while loading. Please reload this page.
48 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#20862
closes JS-2462
Deprecate
instrumentD1WithSentryin favor of automatic D1 instrumentation viainstrumentEnv. AddisD1Databaseduck-type check andinstrumentD1withensureInstrumentedto prevent double instrumentation.The original ticket also states the following, which is outsourced into its own ticket: