Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare): Add batch, exec, and withSession D1 instrumentation - #21292
Merged
Conversation
JPeer264force-pushed
the
jp/missing-d1-instrumentations
branch
from
June 2, 2026 12:55
dc4ec0c to
c7c19ebCompareContributor
size-limit report 📦
|
JPeer264force-pushed
the
jp/missing-d1-instrumentations
branch
from
June 15, 2026 16:20
c7c19eb to
c4b6af2CompareJPeer264
marked this pull request as ready for review
June 16, 2026 09:14
JPeer264
requested review from
andreiborza and mydea
and removed request for
a teamJune 16, 2026 09:14
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c4b6af2. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
👋 @mydea, @andreiborza — Please review this PR when you get a chance! |
andreiborza
approved these changes
Jun 19, 2026
| const runner = createRunner(__dirname) | ||
| .ignore('event') | ||
| .expect((envelope: Envelope) => { | ||
| if (envelopeItemType(envelope) !== 'transaction') return; |
Member
There was a problem hiding this comment.
q: this would silently pass the test right? seems a bit weird. I think we should just hard fail if we don't have a transaction here, no?
MemberAuthor
There was a problem hiding this comment.
that is correct. I will add this
JPeer264
enabled auto-merge (squash)
June 24, 2026 08:05
andreiborza
approved these changes
Jun 24, 2026
Instrument `db.batch()`, `db.exec()`, and `db.withSession()` methods that were previously not covered by D1 instrumentation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JPeer264force-pushed
the
jp/missing-d1-instrumentations
branch
from
June 24, 2026 17:18
bfb2367 to
527039eCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
49 tasks
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#21275
closes JS-2658
This PR does 2 things:
batch,exec, andwithSession.withSessionis not doing anything as per spec, but instruments its return valuesprepareandbatchcloudflare.d1.query_typetodb.operation.nameand is therefore dependent on feat(attributes): Deprecate cloudflare.d1.query_type sentry-conventions#411db.operation.batch.size: feat(attributes): Add db.operation.batch.size sentry-conventions#407AI generated text:
Instrument
db.batch(),db.exec(), anddb.withSession()methodsthat were previously not covered by D1 instrumentation.