Skip to content

feat: Use dataCollection.frameContextLines for ContextLines integration - #21323

Merged
s1gr1d merged 3 commits into
developfrom
sig/tracecontenxt-datacollection
Jun 5, 2026
Merged

feat: Use dataCollection.frameContextLines for ContextLines integration#21323
s1gr1d merged 3 commits into
developfrom
sig/tracecontenxt-datacollection

Conversation

@s1gr1d

Copy link
Copy Markdown
Member

The previous integration option is kept and will take precedence.

Closes#21320

@s1gr1d
s1gr1d requested review from a team as code ownersJune 3, 2026 11:40
@s1gr1d
s1gr1d requested review from JPeer264, andreiborza, logaretm and mydea and removed request for a teamJune 3, 2026 11:40
@github-actions

github-actionsBot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.21 kB+0.02%+3 B 🔺
@sentry/browser - with treeshaking flags25.65 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing)45.26 kB+0.01%+3 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)47.48 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing, Profiling)50.24 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing, Replay)84.87 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags74.44 kB+0.01%+2 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)89.58 kB+0.01%+4 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.2 kB+0.01%+2 B 🔺
@sentry/browser (incl. Feedback)44.36 kB+0.01%+2 B 🔺
@sentry/browser (incl. sendFeedback)32.02 kB+0.01%+1 B 🔺
@sentry/browser (incl. FeedbackAsync)37.11 kB+0.01%+2 B 🔺
@sentry/browser (incl. Metrics)28.28 kB+0.01%+2 B 🔺
@sentry/browser (incl. Logs)28.52 kB+0.01%+2 B 🔺
@sentry/browser (incl. Metrics & Logs)29.22 kB+0.02%+3 B 🔺
@sentry/react29.03 kB+0.02%+3 B 🔺
@sentry/react (incl. Tracing)47.53 kB+0.01%+2 B 🔺
@sentry/vue32.22 kB+0.01%+2 B 🔺
@sentry/vue (incl. Tracing)47.17 kB+0.01%+2 B 🔺
@sentry/svelte27.23 kB+0.02%+3 B 🔺
CDN Bundle29.58 kB+0.02%+4 B 🔺
CDN Bundle (incl. Tracing)47.83 kB+0.02%+6 B 🔺
CDN Bundle (incl. Logs, Metrics)31.09 kB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics)49.07 kB+0.01%+4 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.37 kB+0.01%+4 B 🔺
CDN Bundle (incl. Tracing, Replay)85.22 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)86.39 kB+0.01%+4 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.09 kB+0.01%+5 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.23 kB+0.01%+4 B 🔺
CDN Bundle - uncompressed87.7 kB--
CDN Bundle (incl. Tracing) - uncompressed144.13 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed92.19 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed147.88 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed217 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed262.99 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed266.74 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed276.69 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed280.42 kB--
@sentry/nextjs (client)50.05 kB+0.01%+2 B 🔺
@sentry/sveltekit (client)45.71 kB+0.01%+2 B 🔺
@sentry/core/server75.94 kB+0.01%+2 B 🔺
@sentry/core/browser63.09 kB+0.01%+2 B 🔺
@sentry/node-core61.7 kB+0.01%+6 B 🔺
@sentry/node130.41 kB+0.01%+4 B 🔺
@sentry/node - without tracing74.08 kB+0.03%+18 B 🔺
@sentry/aws-serverless86.27 kB+0.01%+6 B 🔺
@sentry/cloudflare (withSentry) - minified171.85 kB--
@sentry/cloudflare (withSentry)429.62 kB+0.03%+128 B 🔺

View base workflow run

@s1gr1d
s1gr1d requested a review from chargomeJune 3, 2026 11:56

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone were to pass dataCollection: { userInfo: true } then they would get a default of 5, should update that too and switch in the major? Might be confusing otherwise

@s1gr1d
s1gr1d requested a review from chargomeJune 3, 2026 14:24
@s1gr1d
s1gr1d merged commit d0a8080 into developJun 5, 2026
266 of 269 checks passed
@s1gr1d
s1gr1d deleted the sig/tracecontenxt-datacollection branch June 5, 2026 12:14
@s1gr1d

Copy link
Copy Markdown
MemberAuthor

they would get a default of 5, should update that too and switch in the major?

Talked about this offline. We keep it at 5 as it might be confusing too when someone is already using dataCollection in v10 and then has another change in the major version. If someone already opts-into dataCollection we should keep the defaults for v11.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(core): Migrate strack trace context lines to dataCollection option

3 participants

@s1gr1d@logaretm@chargome