Uh oh!
There was an error while loading. Please reload this page.
ref(aws-serverless): Use @sentry/conventions - #21491
Closed
mydea wants to merge 1 commit into
Closed
Conversation
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
feat/use-sentry-conventions-aws-serverless
branch
from
June 12, 2026 11:24
4e49527 to
364bc0cComparemydea
changed the base branch from
develop
to
feat/use-sentry-conventions-build-infraJune 12, 2026 11:25
mydeaforce-pushed
the
feat/use-sentry-conventions-build-infra
branch
from
June 12, 2026 11:33
625467a to
2a83a9fCompareSource span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaforce-pushed
the
feat/use-sentry-conventions-aws-serverless
branch
from
June 15, 2026 07:58
364bc0c to
18e74beComparemydea
changed the base branch from
feat/use-sentry-conventions-build-infra
to
developJune 15, 2026 07:58
mydea
commented
Jun 17, 2026
MemberAuthor
Superseded by #21597, which re-authors this migration on top of current |
mydea added a commit
that referenced
this pull request
Jun 18, 2026
Sources span attribute keys from `@sentry/conventions/attributes` instead of the locally vendored `./semconv` constants (and direct `@opentelemetry/semantic-conventions` imports), for the attributes that have a `@sentry/conventions` equivalent. No functional change — the resolved attribute key strings are identical. Attributes with no `@sentry/conventions` equivalent stay vendored locally: AWS-specific keys (`aws.dynamodb.*`, `aws.sns.topic.arn`, …), `faas.execution`, `faas.id`, `gen_ai.request.stop_sequences`, and `rpc.system`. This supersedes #21491, which was opened before `develop` substantially refactored these vendored files (the `SemconvStability` dual-semconv handling was removed). Rather than rebase through those conflicts, the migration is re-authored on top of current `develop`. Unlike the previous PR, this does **not** add a `paths` override to the shared `packages/typescript/tsconfig.json` — `@sentry/conventions/attributes` resolves via the package's own `exports` map. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
@sentry/aws-serverlessto source span/attribute keys from@sentry/conventions, added as a regular runtimedependencyand externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.Also maps the
@sentry/conventions/attributessubpath inpackages/typescript/tsconfig.jsonfor the repo'snodemoduleResolution type builds.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982