Uh oh!
There was an error while loading. Please reload this page.
ref(aws-serverless): Use @sentry/conventions - #21597
Merged
Merged
Conversation
mydea
requested review from
JPeer264 and andreiborza
and removed request for
a teamJune 17, 2026 09:28
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Jun 17, 2026
JPeer264
approved these changes
Jun 17, 2026
Source span attribute keys from `@sentry/conventions/attributes` instead of the locally vendored `./semconv` constants (and `@opentelemetry/semantic-conventions`), for the attributes that have a `@sentry/conventions` equivalent. AWS/FAAS-specific keys with no equivalent (e.g. `aws.*`, `faas.execution`, `faas.id`, `gen_ai.request.stop_sequences`, `rpc.system`) remain vendored locally. No functional change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydeaforce-pushed
the
feat/aws-serverless-conventions
branch
from
June 18, 2026 08:56
daf9c0e to
f1e6a5aCompareUh oh!
There was an error while loading. Please reload this page.
48 tasks
andreiborza added a commit
that referenced
this pull request
Jul 1, 2026
…nventions (#21893) Source span attribute keys in `@sentry/node` from `@sentry/conventions/attributes` instead of `@opentelemetry/semantic-conventions` and the locally vendored `./semconv` constants, for every attribute that has a `@sentry/conventions` equivalent. The package source no longer imports `@opentelemetry/semantic-conventions`, and the dependency is dropped from `package.json`. This revives and rebases the closed#21635 onto current `develop`, mirroring the merged `ref(aws-serverless): Use @sentry/conventions` (#21597) and the other conventions migrations. No functional change: all string values are identical. ### Details - Migrated to `@sentry/conventions/attributes` across connect, koa, hapi, hono, fastify (v3), firebase/firestore, postgresjs, and the vendored redis/ioredis, mongo, mongoose, mysql, mysql2, postgres, knex, kafka, amqplib, and tedious instrumentations. - Kept vendored locally (no conventions equivalent): `db.response.status_code`, `db.connection_string`, `db.mongodb.collection`, `db.sql.table`, kafka/rabbitmq-specific messaging keys, and all `*_VALUE_*` constants. `hapi/vendored/semconv.ts` became empty and was deleted. - Deprecated conventions keys (`db.system`, `db.name`, `db.operation`, `db.statement`, `http.method`, `net.peer.*`, `net.transport`) carry a `typescript/no-deprecated` disable, matching the existing knex/postgres vendored files. --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources span attribute keys from
@sentry/conventions/attributesinstead of the locally vendored./semconvconstants (and direct@opentelemetry/semantic-conventionsimports), for the attributes that have a@sentry/conventionsequivalent. No functional change — the resolved attribute key strings are identical.Attributes with no
@sentry/conventionsequivalent stay vendored locally: AWS-specific keys (aws.dynamodb.*,aws.sns.topic.arn, …),faas.execution,faas.id,gen_ai.request.stop_sequences, andrpc.system.This supersedes #21491, which was opened before
developsubstantially refactored these vendored files (theSemconvStabilitydual-semconv handling was removed). Rather than rebase through those conflicts, the migration is re-authored on top of currentdevelop. Unlike the previous PR, this does not add apathsoverride to the sharedpackages/typescript/tsconfig.json—@sentry/conventions/attributesresolves via the package's ownexportsmap.🤖 Generated with Claude Code