Uh oh!
There was an error while loading. Please reload this page.
feat: Set url.template on pageload and navigation spans across framework SDKs - #21953
feat: Set url.template on pageload and navigation spans across framework SDKs#21953Lms24 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
| if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') { | ||
| span.updateName(route); | ||
| span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route'); | ||
| span.setAttribute('url.template', route); |
There was a problem hiding this comment.
Missing tests for url.template
Medium Severity
This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
| activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source); | ||
| if (source === 'route') { | ||
| activeRootSpan.setAttribute('url.template', name); | ||
| } |
There was a problem hiding this comment.
Stale url template on downgrade
Medium Severity
When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 02659b6. Configure here.
size-limit report 📦
|
chargome
left a comment
There was a problem hiding this comment.
LGTM, but should we assert in tests?
Lms24
commented
Jul 3, 2026
yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft. |
5500d3b to
945194aCompare9152b09 to
a5997a6Compare088a93e to
7c4bfcbCompareb40658d to
7ea373eCompared20b04f to
c20fc4aCompare7ea373e to
882142cComparec20fc4a to
41cc9bdCompare14cbb12 to
cae6c25Compareed08f20 to
d792a0eCompare26d8b46 to
d7ce684Compared792a0e to
66cf987Compared7ce684 to
76f14eeCompare4cb8c33 to
975286bCompareda06b4f to
f26d09cCompared7cc00e to
c6c9931Comparef26d09c to
eb2f55bComparec1471bb to
3282635Compare58bf332 to
30325b3Compare3282635 to
67c27a5Compareac4177b to
b7ae3a2Compare0be838c to
8dcf8d2Compare624d1b6 to
fb389c1Compare8dcf8d2 to
4b0a201Comparefb389c1 to
3f204c3Compare3f204c3 to
d5da1caCompare41fa12e to
e595d12Compared5da1ca to
9aa65f1Compare…pans Adds url.template, url.path, and url.full to pageload and navigation spans for Solid Router and TanStack Solid Router, including redirect and back-button navigation cases. Updates solidstart and solid-tanstack-router e2e tests. part of #21921 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit) Refactors Angular routing to use the shared getAbsoluteUrl helper and adds navigation.type to SvelteKit navigation spans. part of #21921 Co-Authored-By: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
9aa65f1 to
aca4884CompareLms24
commented
Jul 8, 2026
Restructuring stack: splitting solid changes into #22090. Reopening with updated base. |


Applies
url.templateto pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the sharedgetAbsoluteUrlhelper introduced in #22006, and adds thenavigation.typeattribute to SvelteKit navigation spans.part of #21921