feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat: Set url.template on pageload and navigation spans across framework SDKs - #21953

Closed
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks
Closed

feat: Set url.template on pageload and navigation spans across framework SDKs#21953
Lms24 wants to merge 2 commits into
feat/pageload-url-attrs-reactfrom
feat/pageload-url-attrs-frameworks

Conversation

@Lms24

@Lms24Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Applies url.template to pageload and navigation root spans for Angular and Solid router integrations, refactors Angular routing to use the shared getAbsoluteUrl helper introduced in #22006, and adds the navigation.type attribute to SvelteKit navigation spans.

part of #21921

@Lms24
Lms24 requested a review from a team as a code ownerJuly 3, 2026 10:08
@Lms24
Lms24 requested review from chargome, mydea and nicohrubec and removed request for a teamJuly 3, 2026 10:08

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

Comment threadpackages/angular/src/tracing.ts Outdated
if (span && attributes[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE] === 'url') {
span.updateName(route);
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, 'route');
span.setAttribute('url.template', route);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for url.template

Medium Severity

This feat PR adds url.template on pageload and navigation spans across many framework SDKs, but the diff includes no unit, integration, or E2E tests asserting that attribute on sent spans. Per PR review guidelines for feat changes, at least one such test is expected.

Fix in CursorFix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

activeRootSpan.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, source);
if (source === 'route') {
activeRootSpan.setAttribute('url.template', name);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale url template on downgrade

Medium Severity

When a pageload or navigation span’s sentry.source is later set to url, the new code often stops writing url.template but never removes an earlier value. The span can then show url source while still carrying a previous route template, which mislabels transactions in Sentry.

Additional Locations (2)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 02659b6. Configure here.

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB+0.16%+70 B 🔺
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB+0.22%+104 B 🔺
@sentry/browser (incl. Tracing, Profiling)51.12 kB+0.18%+87 B 🔺
@sentry/browser (incl. Tracing, Replay)85.61 kB+0.07%+56 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB+0.12%+83 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB+0.07%+60 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB+0.06%+55 B 🔺
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB+0.17%+81 B 🔺
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.3 kB+0.3%+141 B 🔺
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB+0.17%+78 B 🔺
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB+0.2%+97 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB+0.12%+96 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB+0.1%+83 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB+0.1%+86 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB+0.09%+82 B 🔺
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB+0.1%+135 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB+0.1%+135 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB+0.06%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB+0.05%+135 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB+0.05%+135 B 🔺
@sentry/nextjs (client)51.1 kB+0.32%+159 B 🔺
@sentry/sveltekit (client)46.79 kB+0.24%+112 B 🔺
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB+0.01%+1 B 🔺
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)132.88 kB-0.85%-1.14 kB 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB-0.01%-1 B 🔽
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should we assert in tests?

@Lms24
Lms24 marked this pull request as draft July 3, 2026 10:32
@Lms24

Lms24 commented Jul 3, 2026

Copy link
Copy Markdown
MemberAuthor

LGTM, but should we assert in tests?

yup absolutely, sorry for pinging you before this was ready. Clanker opened without draft.

@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 5500d3b to 945194aCompareJuly 3, 2026 11:43
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 9152b09 to a5997a6CompareJuly 3, 2026 12:38
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from 088a93e to 7c4bfcbCompareJuly 3, 2026 13:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from b40658d to 7ea373eCompareJuly 3, 2026 13:10
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from d20b04f to c20fc4aCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 7ea373e to 882142cCompareJuly 6, 2026 08:20
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-base branch from c20fc4a to 41cc9bdCompareJuly 6, 2026 13:13
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 14cbb12 to cae6c25CompareJuly 6, 2026 13:18
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-base to feat/pageload-url-attrs-angularJuly 6, 2026 13:19
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ed08f20 to d792a0eCompareJuly 6, 2026 13:25
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch 2 times, most recently from 26d8b46 to d7ce684CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d792a0e to 66cf987CompareJuly 6, 2026 13:46
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-angular branch from d7ce684 to 76f14eeCompareJuly 7, 2026 09:05
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 4cb8c33 to 975286bCompareJuly 7, 2026 09:16
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from da06b4f to f26d09cCompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-astro branch from d7cc00e to c6c9931CompareJuly 7, 2026 13:51
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from f26d09c to eb2f55bCompareJuly 7, 2026 13:57
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-astro to feat/pageload-url-attrs-react-routerJuly 7, 2026 13:58
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from c1471bb to 3282635CompareJuly 7, 2026 15:50
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react-router branch from 58bf332 to 30325b3CompareJuly 7, 2026 15:50
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-react-router to feat/pageload-url-attrs-remixJuly 7, 2026 16:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3282635 to 67c27a5CompareJuly 7, 2026 16:36
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-remix to feat/pageload-url-attrs-sveltekitJuly 7, 2026 17:06
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from ac4177b to b7ae3a2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 0be838c to 8dcf8d2CompareJuly 8, 2026 07:36
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch 2 times, most recently from 624d1b6 to fb389c1CompareJuly 8, 2026 09:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-sveltekit branch from 8dcf8d2 to 4b0a201CompareJuly 8, 2026 09:29
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-sveltekit to feat/pageload-url-attrs-vueJuly 8, 2026 09:30
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from fb389c1 to 3f204c3CompareJuly 8, 2026 12:22
@Lms24
Lms24 changed the base branch from feat/pageload-url-attrs-vue to feat/pageload-url-attrs-reactJuly 8, 2026 12:24
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 3f204c3 to d5da1caCompareJuly 8, 2026 12:27
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-react branch from 41fa12e to e595d12CompareJuly 8, 2026 12:29
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from d5da1ca to 9aa65f1CompareJuly 8, 2026 12:29
Lms24and others added 2 commits July 8, 2026 14:49
…pans
Adds url.template, url.path, and url.full to pageload and navigation spans
for Solid Router and TanStack Solid Router, including redirect and back-button
navigation cases. Updates solidstart and solid-tanstack-router e2e tests.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ltekit)
Refactors Angular routing to use the shared getAbsoluteUrl helper and adds
navigation.type to SvelteKit navigation spans.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-frameworks branch from 9aa65f1 to aca4884CompareJuly 8, 2026 12:50
@Lms24

Lms24 commented Jul 8, 2026

Copy link
Copy Markdown
MemberAuthor

Restructuring stack: splitting solid changes into #22090. Reopening with updated base.

@Lms24Lms24 closed this Jul 8, 2026
@Lms24Lms24 reopened this Jul 8, 2026
@Lms24Lms24 closed this Jul 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@chargome