feat(nextjs): Set url attributes on pageload and navigation spans - #22006

Merged
Lms24 merged 6 commits into
developfrom
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged

feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom
feat/pageload-url-attrs-nextjs

Conversation

@Lms24

@Lms24Lms24 commented Jul 7, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.

Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.

ref #21921

@Lms24Lms24 changed the title feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24 mentioned this pull request Jul 7, 2026
Closed
@github-actions

github-actionsBot commented Jul 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--

View base workflow run

@Lms24Lms24 changed the title feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24 marked this pull request as ready for review July 7, 2026 11:40
@Lms24
Lms24 requested review from a team as code ownersJuly 7, 2026 11:40
@Lms24
Lms24 requested review from chargome, logaretm, mydea and s1gr1d and removed request for a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot reviewed Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts Outdated
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot reviewed Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts Outdated
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from baade71 to e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot reviewed Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot reviewed Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts
Comment on lines +175 to 185
[SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
},
},
});
{ url: getAbsoluteUrl(navigationTarget) },
);
});
}

@sentrysentryBotJul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM

Suggested Fix

Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit that referenced this pull request Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit that referenced this pull request Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit that referenced this pull request Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from e3e26e0 to de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit that referenced this pull request Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit that referenced this pull request Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit that referenced this pull request Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from de810f2 to 018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot reviewed Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit that referenced this pull request Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit that referenced this pull request Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from 018a447 to a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot reviewed Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from a0cf6b6 to 207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot reviewed Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24 mentioned this pull request Jul 8, 2026
Merged
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from 207182d to 215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot reviewed Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts Outdated
sentry[bot]
sentryBot reviewed Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts Outdated
Base automatically changed from feat/pageload-url-attrs-angular to developJuly 8, 2026 14:20
Lms24and others added 3 commits July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed the feat/pageload-url-attrs-nextjs branch from 215556b to a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot reviewed Jul 8, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.

Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts Outdated
@Lms24
Lms24 merged commit 2420b9d into developJul 8, 2026
395 of 402 checks passed
@Lms24
Lms24 deleted the feat/pageload-url-attrs-nextjs branch July 8, 2026 15:59
Lms24 added a commit that referenced this pull request Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot mentioned this pull request Jul 10, 2026
Closed
49 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(nextjs): Set url attributes on pageload and navigation spans - #22006
Merged
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Jul 8, 2026
Merged
feat(nextjs): Set url attributes on pageload and navigation spans#22006
Lms24 merged 6 commits into
developfrom 
feat/pageload-url-attrs-nextjs
Conversation
@Lms24
@Lms24Lms24
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Adjusts the Next.js (app router and pages router) routing instrumentation to set url.template, url.full and url.path on pageload and navigation spans.
Adds a shared getAbsoluteUrl helper to @sentry/browser-utils (re-exported from @sentry/browser) to resolve the relative URLs the Next.js router gives us into absolute URLs, since we need url.full to carry the full, resolved URL.
ref #21921
@Lms24Lms24
changed the title
feat/pageload url attrs nextjsfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24Lms24
mentioned this pull request
Jul 7, 2026
 Closed

@github-actions
github-actionsBot
commented
Jul 7, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser27.59 kB--
@sentry/browser - with treeshaking flags26.03 kB--
@sentry/browser (incl. Tracing)46.34 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.13 kB--
@sentry/browser (incl. Tracing, Profiling)51.12 kB--
@sentry/browser (incl. Tracing, Replay)85.61 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags75.26 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)90.32 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)102.97 kB--
@sentry/browser (incl. Feedback)44.76 kB--
@sentry/browser (incl. sendFeedback)32.38 kB--
@sentry/browser (incl. FeedbackAsync)37.51 kB--
@sentry/browser (incl. Metrics)28.67 kB--
@sentry/browser (incl. Logs)28.91 kB--
@sentry/browser (incl. Metrics & Logs)29.59 kB--
@sentry/react29.38 kB--
@sentry/react (incl. Tracing)48.61 kB--
@sentry/vue33.03 kB--
@sentry/vue (incl. Tracing)48.24 kB--
@sentry/svelte27.61 kB--
CDN Bundle30 kB--
CDN Bundle (incl. Tracing)48.32 kB--
CDN Bundle (incl. Logs, Metrics)31.57 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)49.64 kB--
CDN Bundle (incl. Replay, Logs, Metrics)70.81 kB--
CDN Bundle (incl. Tracing, Replay)85.84 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)87.14 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)91.64 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)92.92 kB--
CDN Bundle - uncompressed89.35 kB--
CDN Bundle (incl. Tracing) - uncompressed146.1 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed94.05 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed150.07 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed218.75 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed265.27 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed269.23 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed278.97 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed282.92 kB--
@sentry/nextjs (client)51.16 kB+0.25%+125 B 🔺
@sentry/sveltekit (client)46.75 kB--
@sentry/core/server78.42 kB--
@sentry/core/browser64.74 kB--
@sentry/node-core62.72 kB--
@sentry/node124.6 kB--
@sentry/node (incl. diagnostics channel injection)134.02 kB--
@sentry/node/import (ESM hook with diagnostics-channel injection)69.95 kB--
@sentry/node/light50.72 kB--
@sentry/node - without tracing74.05 kB--
@sentry/aws-serverless85.5 kB--
@sentry/cloudflare (withSentry) - minified181.69 kB--
@sentry/cloudflare (withSentry)449.12 kB--
View base workflow run
@Lms24Lms24
changed the title
feat(nextjs): Set url attributes on pageload and navigation spansfeat(nextjs): Set url attributes on pageload and navigation spansJul 7, 2026
@Lms24
Lms24
marked this pull request as ready for review
July 7, 2026 11:40
@Lms24
Lms24
requested review from
a team
as code ownersJuly 7, 2026 11:40
@Lms24
Lms24
requested review from
chargome, logaretm, mydea and s1gr1d
and removed request for
a teamJuly 7, 2026 11:40
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
baade71 to
e3e26e0CompareJuly 7, 2026 13:51
cursor[bot]
cursorBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
sentry[bot]
sentryBot
reviewed
Jul 7, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts

Comment on lines

+175
 to 
185

 [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation',
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.navigation.nextjs.pages_router_instrumentation',
 [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: spanSource,
 ...(spanSource === 'route' && { [URL_TEMPLATE]: newLocation }),
 },
 },
 });
 { url: getAbsoluteUrl(navigationTarget) },
 );
 });
}

@sentrysentryBotJul 7, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: In the App Router instrumentation, router.back() and router.forward() calls result in getAbsoluteUrl(undefined), creating spans with incorrect URLs like .../undefined.
Severity: MEDIUM
Suggested Fix
Before calling getAbsoluteUrl within patchRouter, check if the normalizedHref variable is undefined. If it is, which occurs during back() or forward() navigations, avoid calling getAbsoluteUrl to prevent the creation of a malformed URL on the navigation span. The span can be created without the url attribute in these cases.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
packages/nextjs/src/client/routing/pagesRouterRoutingInstrumentation.ts#L167-L185
Potential issue: In the App Router instrumentation, the `patchRouter` function directly
patches `router.back()` and `router.forward()`. When these router methods are called
without arguments, the code attempts to determine the navigation URL from an `undefined`
argument. This `undefined` value is passed to the `getAbsoluteUrl` utility, which
incorrectly coerces it into the string "undefined", resulting in a malformed URL like
`https://example.com/undefined`. This incorrect URL is then attached to the browser
tracing navigation span, corrupting telemetry data for back and forward navigation
events.

Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
eb2f55b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
c1471bb
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
3282635
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Remix, Solid, SvelteKit, and Vue integrations, and refactors Angular's
routing instrumentation to use the shared getAbsoluteUrl helper introduced
in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
e3e26e0 to
de810f2CompareJuly 7, 2026 15:50
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
67c27a5
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, SvelteKit, and Vue integrations, and refactors Angular's routing
instrumentation to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 7, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
ac4177b
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
b7ae3a2
…ork SDKs
Applies url.template to pageload and navigation root spans across React,
Solid, and Vue integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
de810f2 to
018a447CompareJuly 8, 2026 07:36
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/browser-utils/src/instrument/location.ts
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
0a8a9ab
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Lms24 added a commit
that referenced
this pull request
Jul 8, 2026
@Lms24@cursoragent
feat: Set url.template on pageload and navigation spans across framew…
5bd7299
…ork SDKs
Applies url.template to pageload and navigation root spans across React
and Solid integrations, and refactors Angular's routing instrumentation
to use the shared getAbsoluteUrl helper introduced in #22006.
part of #21921
Co-Authored-By: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
018a447 to
a0cf6b6CompareJuly 8, 2026 09:29
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
a0cf6b6 to
207182dCompareJuly 8, 2026 12:29
sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
@Lms24Lms24
mentioned this pull request
Jul 8, 2026
 Merged

@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
207182d to
215556bCompareJuly 8, 2026 13:11
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated

sentry[bot]
sentryBot
reviewed
Jul 8, 2026
View reviewed changes
Comment threadpackages/nextjs/src/client/routing/appRouterRoutingInstrumentation.ts
Outdated


Base automatically changed from
feat/pageload-url-attrs-angular to
developJuly 8, 2026 14:20
Lms24and others
added 3 commits
July 8, 2026 16:21
@Lms24@cursoragent
browser-utils: add getAbsoluteUrl helper
0beefb5
Adds a shared helper that resolves a relative URL/path to an absolute
URL using the current window origin, for use by framework SDKs that
only have access to relative navigation URLs.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24@cursoragent
nextjs: set url.full, url.path and url.template on pageload/navigatio…
601bb18
…n spans
Uses the new getAbsoluteUrl helper to resolve Next.js router URLs
(which are relative) to absolute URLs so that url.full and url.path
are set correctly on pageload and navigation root spans, and adds
url.template for parameterized routes.
Co-Authored-By: Cursor <cursoragent@cursor.com>
@Lms24
fix pages router instrumentation unit tests
a6ac3d0
@Lms24
Lms24force-pushed
the
feat/pageload-url-attrs-nextjs
branch
from
215556b to
a6ac3d0CompareJuly 8, 2026 14:22
cursor[bot]
cursorBot
reviewed
Jul 8, 2026
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.
Fix All in Cursor
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7328c5c. Configure here.
Comment threaddev-packages/e2e-tests/test-applications/nextjs-13/tests/client/app-dir-pageloads.test.ts
Outdated

@Lms24
Lms24
merged commit 2420b9d
into
developJul 8, 2026

395 of 402 checks passed

@Lms24
Lms24
deleted the

feat/pageload-url-attrs-nextjs

branch
July 8, 2026 15:59
Lms24 added a commit
that referenced
this pull request
Jul 9, 2026
@Lms24@cursoragent
ref(angular): Streamlineurlattribute creation (#22091)
893a48c
Uses the `getAbsoluteUrl` helper introduced in #22006 to streamline the
url attribute creation pipeline and loose some bytes in the process.
part of #21921
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
@sentry-release-botsentry-release-botBot
mentioned this pull request
Jul 10, 2026

Closed

49 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@sentrysentry[bot]sentry[bot] left review comments
@cursorcursor[bot]cursor[bot] left review comments
@s1gr1ds1gr1ds1gr1d approved these changes
@mydeamydeaAwaiting requested review from mydeamydea is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@chargomechargomeAwaiting requested review from chargomechargome is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@logaretmlogaretmAwaiting requested review from logaretmlogaretm is a code owner automatically assigned from getsentry/team-javascript-sdks-browser

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@s1gr1d