Uh oh!
There was an error while loading. Please reload this page.
feat(opentelemetry)!: Remove SentrySpanProcessor & SentrySampler - #22557
Conversation
SentrySpanProcessor & SentrySamplerSentrySpanProcessor & SentrySampler| export { wrapContextManagerClass } from './contextManager'; | ||
| export { SentryPropagator, shouldPropagateTraceForUrl } from './propagator'; | ||
| export { SentrySpanProcessor } from './spanProcessor'; |
There was a problem hiding this comment.
Public APIs removed without deprecation
High Severity
This removes public exports and options (SentrySpanProcessor, SentrySampler, wrapSamplingDecision, validateOpenTelemetrySetup, openTelemetrySpanProcessors, openTelemetryBasicTracerProvider, openTelemetryInstrumentations) in a non-major release without deprecation notices. Existing custom OpenTelemetry setups that import these will break at compile or runtime.
Additional Locations (2)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit a6425a2. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 29be8c9. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
size-limit report 📦
|
11fa52b to
0905bdeCompare
andreiborza
left a comment
There was a problem hiding this comment.
Could you add two entries in https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#sentryopentelemetry please?
Uh oh!
There was an error while loading. Please reload this page.
| "@opentelemetry/api": "^1.9.1", | ||
| "@opentelemetry/core": "^2.9.0", | ||
| "@opentelemetry/instrumentation": "^0.220.0", | ||
| "@opentelemetry/sdk-trace-base": "^2.9.0", |
mydea
commented
Jul 27, 2026
For completeness: we talked about this, we do not need a full list of changes/migrations for the opentelemetry package because this will go away anyhow. |
Uh oh!
There was an error while loading. Please reload this page.
## What Adds a `node-otel-sdk-node` e2e app for the setup where OpenTelemetry owns tracing: the user's own `@opentelemetry/sdk-node` with Sentry tracing off and `otlpIntegration()`. It runs as ESM so import-in-the-middle and orchestrion are exercised together. The migration guide now presents that setup as requiring Sentry tracing off, instead of offering Sentry spans alongside your own. ## Why The bring-your-own-OpenTelemetry apps named in the issue were removed together with the paths they tested (`SentrySpanProcessor` in #22557, the preload entry point in #23074), so nothing covered a user owned OpenTelemetry SDK any more. Closes: #22645 --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This PR removes the
SentrySpanProcessorandSentrySampler, as well as related options in Node SDKs.Main removals
This removes the
SentrySpanProcessor(and with it, theSentryExporterwhich was used by it) as well as theSentrySampler. With this, it no longer becomes possible to do a custom otel setup (like it used to be, this will work differently going forward), so related tests are removed. This also removes the@opentelemetry/sdk-trace-basedependency, which is no longer needed.Removed options
The following options where related only to the span processor and are thus removed:
maxSpanWaitDurationopenTelemetryInstrumentationsopenTelemetrySpanProcessorsopenTelemetryBasicTracerProviderOther removals
Other, less important things that are removed:
validateOpenTelemetrySetupwrapSamplingDecisionImportantly, the context manager and propagator remain for now.