Uh oh!
There was an error while loading. Please reload this page.
feat(node)!: Remove init, preload entry points and preloadOpenTelemetry - #23074
Merged
Conversation
MemberAuthor
buglitzer moch |
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 56dbdfd. Configure here.
andreiborza
marked this pull request as ready for review
August 5, 2026 18:06
andreiborza
requested review from
JPeer264, Lms24, chargome, mydea and nicohrubec
and removed request for
a team and mydeaAugust 5, 2026 18:06
…lemetry` Removes the `@sentry/node/init` and `@sentry/node/preload` no-code entry points and the `preloadOpenTelemetry()` function. All instrumentation is channel-based via orchestrion and set up when the instrumented module loads, so preloading no longer does anything. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborzaforce-pushed
the
ab/clean-up-node-submodule-exports
branch
from
August 5, 2026 18:11
56dbdfd to
58d24feComparenicohrubec
approved these changes
Aug 6, 2026
Lms24
approved these changes
Aug 6, 2026
Member
There was a problem hiding this comment.
Nice!
side-note, absolutely not relevant for this PR: ignoreLayersType is very cryptic to understand for users. Most express users likely don't even know what a layer is. Should we think about a more human-friendly option here? Ignoring middleware spans is something people want to do. ignoreSpans covers this use case universally but since we have the option on integration level, it can be used more precisely and probably reduce perf overhead for perf-conscious users.
... this also made me realize we don't document the express integration 😅 and this option is only documented for Koa
andreiborza
commented
Aug 6, 2026
MemberAuthor
@Lms24 right, we don't have documentations for any of the vendored instrumentations. Def some work to do there. |
Uh oh!
There was an error while loading. Please reload this page.
andreiborza added a commit
that referenced
this pull request
Sep 2, 2026
## What Adds a `node-otel-sdk-node` e2e app for the setup where OpenTelemetry owns tracing: the user's own `@opentelemetry/sdk-node` with Sentry tracing off and `otlpIntegration()`. It runs as ESM so import-in-the-middle and orchestrion are exercised together. The migration guide now presents that setup as requiring Sentry tracing off, instead of offering Sentry spans alongside your own. ## Why The bring-your-own-OpenTelemetry apps named in the issue were removed together with the paths they tested (`SentrySpanProcessor` in #22557, the preload entry point in #23074), so nothing covered a user owned OpenTelemetry SDK any more. Closes: #22645 --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the following from
@sentry/node, part of the v11 major:@sentry/node/initand@sentry/node/preloadno-code entry points.preloadOpenTelemetry()function.node-express-{cjs,esm}-preloade2e apps and theno-codeintegration suite that tested them.Also repurposes the
express/late-initintegration suite (renamed toexpress/ignore-layers-type) into a focusedignoreLayersTypetest.Why
All instrumentation is channel-based via orchestrion and is set up when the instrumented module loads, so preloading no longer does anything.
preloadOpenTelemetry()could only ever preload the Sentry HTTP breadcrumb/propagation instrument, which normalinit()already sets up, so it had quietly stopped doing its advertised job.The issue proposed deprecating
init/preload, but sincedevelopis the v11 line a deprecation cycle buys nothing, so these are removed outright.@sentry/node/importstays as the one supported hook.@sentry/node/loaderand@sentry/node/auto-diagnostic-channelsfrom the issue are already moot:/loaderwas removed with the iitm cleanup, and/importalready is the orchestrion diagnostics-channel hook that/auto-diagnostic-channelswas meant to become.The
late-initsuite existed to guard lazy Express option loading via a laterinit(), a mechanism that now lives only in@sentry/core'spatchLayer(Deno-only, unit-tested) and is unreachable in node under orchestrion. It was also the only node e2e test exercisingignoreLayersType, so it is kept and refocused on that option rather than deleted.Closes: #21483