Uh oh!
There was an error while loading. Please reload this page.
ref(core)!: Rename gen_ai.system to gen_ai.provider.name - #22814
Merged
Conversation
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
July 29, 2026 12:30
nicohrubec
requested review from
andreiborza, isaacs and mydea
and removed request for
a teamJuly 29, 2026 12:30
andreiborza
approved these changes
Jul 29, 2026
Base automatically changed from
ref/align-cache-token-attributes-with-conventions to
developJuly 29, 2026 13:54
nicohrubecforce-pushed
the
ref/genai-system-to-provider-name
branch
2 times, most recently
from
July 30, 2026 05:14
8eee8e4 to
6d11e37Comparenicohrubec
marked this pull request as draft
July 30, 2026 12:43
Emit the `gen_ai.provider.name` attribute from `@sentry/conventions` instead of the deprecated `gen_ai.system` alias across all AI integrations (OpenAI, Anthropic, Google GenAI, LangChain, Bedrock, Vercel AI). The OTel-based Vercel AI processor now renames the SDK-native `gen_ai.system` attribute to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubecforce-pushed
the
ref/genai-system-to-provider-name
branch
from
August 4, 2026 13:24
6d11e37 to
6d7fbebComparenicohrubec
marked this pull request as ready for review
August 5, 2026 11:44
Comment on lines
1
to
2
| /* eslint-disable max-lines */ | ||
| // `@sentry/conventions` marks several gen_ai attributes (e.g. `GEN_AI_SYSTEM`, `GEN_AI_TOOL_*`, | ||
| // `GEN_AI_REQUEST_AVAILABLE_TOOLS`) as deprecated in favour of newer semconv names. We intentionally | ||
| // keep emitting the current names so these spans match the OTel-based (v6) integration and what the | ||
| // Sentry product consumes today; migrating to the new names is a separate, coordinated change. | ||
| /* eslint-disable typescript-eslint/no-deprecated */ |
Contributor
There was a problem hiding this comment.
Bug: The explanatory comment for the eslint-disable typescript-eslint/no-deprecated directive was removed, but the directive itself was kept, reducing code clarity and increasing future maintenance risk.
Severity: LOW
Suggested Fix
Restore the removed comment or add a new concise one explaining why deprecated attributes are intentionally used. This will clarify the purpose of the eslint-disable directive and prevent future maintenance issues.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/server-utils/src/vercel-ai/vercel-ai-dc-subscriber.ts#L1-L2
Potential issue: In `vercel-ai-dc-subscriber.ts`, a comment explaining the intentional
use of deprecated symbols was removed, while the `/* eslint-disable
typescript-eslint/no-deprecated */` directive remains. The file still uses deprecated
symbols like `GEN_AI_REQUEST_AVAILABLE_TOOLS` to maintain compatibility with an
OTel-based integration. Without the comment, future developers may not understand the
reason for disabling the lint rule and could mistakenly remove it, which would cause
build failures. This is inconsistent with other files in the codebase where similar
explanatory comments are retained alongside the directive.
Did we get this right? 👍 / 👎 to inform future reviews.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches all AI integrations from the deprecated
gen_ai.systemattribute to its@sentry/conventionsreplacementgen_ai.provider.name.Part of #22482