Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare)!: Set enableRpcTracePropagation to true by default - #23079
Merged
JPeer264 merged 2 commits intoAug 7, 2026
Merged
Conversation
Contributor
size-limit report 📦
|
JPeer264force-pushed
the
jp/enable-rpc-trace-propagation-true
branch
from
August 6, 2026 12:55
36e5016 to
1184a51CompareJPeer264
marked this pull request as ready for review
August 6, 2026 12:55
JPeer264
requested review from
chargome, isaacs, mydea and nicohrubec
and removed request for
a team, isaacs and mydeaAugust 6, 2026 12:55
chargome
approved these changes
Aug 6, 2026
chargome
left a comment
Member
There was a problem hiding this comment.
Would update the docs here otherwise lgtm!
Comment on lines
+203
to
+204
| * **Important:** This option is enabled by default. Set it to `false` to opt out, e.g. if you | ||
| * do not want trace context to leave your Worker via RPC calls. |
Member
There was a problem hiding this comment.
I think the JSDoc example below should show an example of opting out now, not the other way around
MemberAuthor
There was a problem hiding this comment.
great catch! Gonna change that
nicohrubec
approved these changes
Aug 6, 2026
andreiborza
approved these changes
Aug 6, 2026
JPeer264force-pushed
the
jp/enable-rpc-trace-propagation-true
branch
from
August 7, 2026 06:36
ce80ac7 to
6e9cf9bCompareUh oh!
There was an error while loading. Please reload this page.
JPeer264 added a commit
that referenced
this pull request
Aug 13, 2026
…fault (#23350) reverts #23079 It is bad if we actually set this on by default, not because of performance, but because other uninstrumented services could fail. Instead we will add an allow list like `instrumentPrototypeMethods` was before which is opt-in when using without Vite and when using it with the Vite plugin we allow list all bindings within one deployment automatically and all other services are opt-in (follow up PRs). This is the only way to not modify RPC calls to external deployments. See #23233 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#20525
closes#20525
This swaps the default of the
enableRpcTracePropagationfield