Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,7 +15,7 @@ const redisUrl = Deno.env.get('REDIS_URL') ?? 'redis://127.0.0.1:6379';

// One shared client per process. node-redis publishes to the
// `node-redis:command` / `:batch` / `:connect` diagnostics channels for every
// operation on this client; denoRedisIntegration is already subscribed to
// operation on this client; redisIntegration is already subscribed to
// those.
const redis = createClient({ url: redisUrl });
function onRedisError(err: unknown) {
Expand All@@ -26,7 +26,7 @@ redis.on('error', onRedisError);
await redis.connect();

// Separate ioredis client. ioredis >= 5.11 publishes to the `ioredis:command`
// and `ioredis:connect` channels, which denoRedisIntegration also subscribes
// and `ioredis:connect` channels, which redisIntegration also subscribes
// to. lazyConnect so we can yield a microtick before connecting and ensure
// the DC subscriber is registered before ioredis creates its tracing channels.
await Promise.resolve();
Expand Down
5 changes: 3 additions & 2 deletions packages/deno/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -111,8 +111,7 @@ export { denoServeIntegration } from './integrations/deno-serve';
export type { DenoServeIntegrationOptions } from './integrations/deno-serve';
export { denoHttpIntegration } from './integrations/http';
export type { DenoHttpIntegrationOptions } from './integrations/http';
export { denoRedisIntegration } from './integrations/redis';
export type { DenoRedisIntegrationOptions } from './integrations/redis';

// The orchestrion channel integrations, re-exported from `@sentry/server-utils`.
// Most are in the default set; `dataloader` and `knex` are opt-in (add them to
// `integrations` to enable), matching Node. Re-export every one that `sdk.ts`
Expand All@@ -122,6 +121,7 @@ export {
anthropicIntegration,
awsIntegration,
dataloaderIntegration,
redisIntegration,
Comment thread
cursor[bot] marked this conversation as resolved.
expressIntegration,
firebaseIntegration,
genericPoolIntegration,
Expand DownExpand Up@@ -157,6 +157,7 @@ export { denoMongoIntegration } from './integrations/mongo';
export { denoMongooseIntegration } from './integrations/mongoose';
export { denoDataloaderIntegration } from './integrations/dataloader';
export { denoKnexIntegration } from './integrations/knex';
export { denoRedisIntegration } from './integrations/redis';
/* eslint-enable typescript/no-deprecated */
export { denoContextIntegration } from './integrations/context';
export { globalHandlersIntegration } from './integrations/globalhandlers';
Expand Down
34 changes: 3 additions & 31 deletions packages/deno/src/integrations/redis.ts
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,6 @@
import type { RedisDiagnosticChannelResponseHook } from '@sentry/server-utils';
import { redisIntegration as redisChannelIntegration } from '@sentry/server-utils';
import type { Integration, IntegrationFn } from '@sentry/core';
import { defineIntegration, extendIntegration } from '@sentry/core';

const INTEGRATION_NAME = 'DenoRedis' as const;

export interface DenoRedisIntegrationOptions {
/**
* Optional hook invoked once the redis command response arrives. Useful for
* attaching response-derived attributes (e.g. cache hit/miss, payload size).
*/
responseHook?: RedisDiagnosticChannelResponseHook;
}

const _denoRedisIntegration = ((options: DenoRedisIntegrationOptions = {}) => {
// The diagnostics_channel subscription lives in server-utils so it is shared
// across runtimes. The AsyncLocalStorage async-context strategy the channel
// binding depends on is installed once in `init()`, so this wrapper only
// renames the shared integration.
return extendIntegration(redisChannelIntegration({ responseHook: options.responseHook }), {
name: INTEGRATION_NAME,
});
}) satisfies IntegrationFn;
import { redisIntegration } from '@sentry/server-utils/orchestrion';

/**
* Creates spans for redis commands, batches, and connects under Deno via
* `node:diagnostics_channel`. Subscribes to both node-redis (>= 5.12.0) and
* ioredis (>= 5.11.0) channels — both libraries publish to dedicated channels
* once they're new enough; on older releases the subscribers are inert.
* @deprecated Use `redisIntegration` instead.
*/
export const denoRedisIntegration = defineIntegration(_denoRedisIntegration) as (
options?: DenoRedisIntegrationOptions,
) => Integration & { name: 'DenoRedis'; setupOnce: () => void };
export const denoRedisIntegration: typeof redisIntegration = redisIntegration;
4 changes: 2 additions & 2 deletions packages/deno/src/sdk.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,14 +35,14 @@ import {
postgresJsIntegration,
tediousIntegration,
vercelAiIntegration,
redisIntegration,
} from '@sentry/server-utils/orchestrion';
import { DenoClient } from './client';
import { breadcrumbsIntegration } from './integrations/breadcrumbs';
import { denoContextIntegration } from './integrations/context';
import { contextLinesIntegration } from './integrations/contextlines';
import { denoServeIntegration } from './integrations/deno-serve';
import { denoHttpIntegration } from './integrations/http';
import { denoRedisIntegration } from './integrations/redis';
import { globalHandlersIntegration } from './integrations/globalhandlers';
import { normalizePathsIntegration } from './integrations/normalizepaths';
import { setupOpenTelemetryTracer } from './opentelemetry/tracer';
Expand All@@ -64,7 +64,7 @@ export function getDefaultIntegrations(_options: Options): Integration[] {
denoContextIntegration(),
denoServeIntegration(),
denoHttpIntegration(),
denoRedisIntegration(),
redisIntegration(),
graphqlDiagnosticsIntegration(),
vercelAiIntegration(),
// orchestrion-based instrumentations. We add a deliberate list here rather
Expand Down
6 changes: 3 additions & 3 deletions packages/deno/test/__snapshots__/mod.test.ts.snap
Original file line numberDiff line numberDiff line change
Expand Up@@ -56,7 +56,7 @@ snapshot[`captureMessage 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -161,7 +161,7 @@ snapshot[`captureMessage twice 1`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand DownExpand Up@@ -273,7 +273,7 @@ snapshot[`captureMessage twice 2`] = `
"DenoContext",
"DenoServe",
"DenoHttp",
"DenoRedis",
"Redis",
"Graphql",
"VercelAI",
"Amqplib",
Expand Down
10 changes: 5 additions & 5 deletions packages/deno/test/deno-redis.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,14 +52,14 @@ function withTimeout<T>(p: Promise<T>, ms: number, what: string): Promise<T> {
});
}

Deno.test('denoRedisIntegration: included in default integrations', () => {
Deno.test('redisIntegration: included in default integrations', () => {
resetGlobals();
const client = init({ dsn: 'https://username@domain/123' }) as DenoClient;
const names = client.getOptions().integrations.map(i => i.name);
assert(names.includes('DenoRedis'), `DenoRedis should be in defaults, got ${names.join(', ')}`);
assert(names.includes('Redis'), `Redis should be in defaults, got ${names.join(', ')}`);
});

Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: node-redis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -98,7 +98,7 @@ Deno.test('denoRedisIntegration: node-redis:command channel produces a db.query
assertEquals(redisSpan!.data?.['server.port'], 6379);
});

Deno.test('denoRedisIntegration: errors on the command channel set span status', async () => {
Deno.test('redisIntegration: errors on the command channel set span status', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand DownExpand Up@@ -135,7 +135,7 @@ Deno.test('denoRedisIntegration: errors on the command channel set span status',
assertEquals(redisSpan!.status, 'internal_error');
});

Deno.test('denoRedisIntegration: ioredis:command channel produces a db.query child span', async () => {
Deno.test('redisIntegration: ioredis:command channel produces a db.query child span', async () => {
resetGlobals();
const sink = transactionSink();
init({
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,10 +26,10 @@ export {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration as vercelAIIntegration,
} from '@sentry/server-utils/orchestrion';
export { redisIntegration } from './integrations/tracing/redis';
export {
otlpIntegration,
getOtlpTracesEndpoint,
Expand Down
4 changes: 1 addition & 3 deletions packages/node/src/integrations/tracing/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,11 +21,11 @@ import {
openAIIntegration,
postgresIntegration,
postgresJsIntegration,
redisIntegration,
tediousIntegration,
vercelAiIntegration,
} from '@sentry/server-utils/orchestrion';
import { fastifyIntegration } from './fastify';
import { redisIntegration } from './redis';

export function getAutoPerformanceIntegrations(): Integration[] {
return [
Expand All@@ -36,8 +36,6 @@ export function getAutoPerformanceIntegrations(): Integration[] {
mongooseIntegration(),
mysqlIntegration(),
mysql2Integration(),
// Redis keeps the node wrapper: it wires the cache `responseHook` into the channel subscribers
// and covers all redis client versions (native diagnostics_channel + orchestrion fallbacks).
redisIntegration(),
postgresIntegration(),
prismaIntegration(),
Expand Down
118 changes: 0 additions & 118 deletions packages/node/src/integrations/tracing/redis/cache.ts

This file was deleted.

55 changes: 0 additions & 55 deletions packages/node/src/integrations/tracing/redis/index.ts

This file was deleted.

Loading
Loading