Uh oh!
There was an error while loading. Please reload this page.
ref(server-utils): Streamline redisIntegration - #23353
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Contributor
size-limit report 📦
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6caae65. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
mydea
marked this pull request as ready for review
August 12, 2026 13:56
mydea
requested review from
JPeer264, andreiborza, isaacs and s1gr1d
and removed request for
a teamAugust 12, 2026 13:56
s1gr1d
approved these changes
Aug 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+199
to
+200
| // todo: change to string[] once EAP supports it | ||
| const spanDescription = safeKey.join(', '); |
Member
There was a problem hiding this comment.
This is something that we could do already, but out of scope for this PR
mydeaforce-pushed
the
fn/redis-integration
branch
from
August 13, 2026 08:25
28f508f to
b536b35CompareUh oh!
There was an error while loading. Please reload this page.
JPeer264
approved these changes
Aug 13, 2026
mydeaforce-pushed
the
fn/redis-integration
branch
from
August 13, 2026 09:28
b536b35 to
c2fccf9CompareUh oh!
There was an error while loading. Please reload this page.
s1gr1d added a commit
that referenced
this pull request
Aug 24, 2026
Develop landed overlapping semantic-convention work (#23408, #23422, #23353, #23405) and restructured the redis integration into `integrations/redis/`. Conflicts were resolved by keeping develop's file layout and layering this branch's attribute changes on top: - ioredis/node-redis spans emit `db.operation.name` and drop `db.connection_string`; `server.address`/`server.port` are only set when known. - The ioredis orchestrion span op moves from `db` to `db.query`, and the connect span to `db` via `SENTRY_OP`, matching the native diagnostics-channel subscriber develop added. - AMQP keeps this branch's removal of the legacy `messaging.*` attributes and adds `messaging.operation.name`. - Test conditionals on the deleted `isOrchestrionEnabled()` helper (#23435) collapse to their channel branch. - `nextjs-16-orchestrion` was deleted upstream (#23349); its ioredis coverage now lives in `nextjs-16/tests/db-page.test.ts`. The v11 migration doc keeps develop's subsection structure with this branch's AMQP and Redis specifics folded in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
redisIntegrationIn deno there is still
denoRedisIntegrationfor backwards compat, but it is just an alias now.