Uh oh!
There was an error while loading. Please reload this page.
ref!(node): Remove Fastify error handler setter - #23411
Merged
Merged
Conversation
s1gr1d
requested review from
logaretm, nicohrubec and stephanie-anderson
and removed request for
a team and stephanie-andersonAugust 13, 2026 15:13
Contributor
size-limit report 📦
|
Contributor
👋 @logaretm, @nicohrubec — Please review this PR when you get a chance! |
nicohrubec
approved these changes
Aug 20, 2026
andreiborza
approved these changes
Aug 24, 2026
s1gr1d
commented
Aug 24, 2026
MemberAuthor
btw, I will wait with merging after the PR to deprecate |
Resolves conflicts with #23460, which consolidated Fastify onto a single channel-based `fastifyIntegration` and moved everything out of `packages/node/src/integrations/tracing/fastify/`. Conflict resolutions (all modify/delete — upstream deletion accepted): - The three e2e `app-handle-error-override.ts` apps: #23460 deleted them and moved override coverage into node-integration-tests. - `packages/node/src/integrations/tracing/fastify/index.ts`: deleted, the integration now lives in `@sentry/server-utils`. - `docs/migration/v11-end-state.md`: deleted by #23623, which folded the guide into MIGRATION.md. The Fastify entries were ported there. Reapplied on top: `setupFastifyErrorHandler` no longer accepts `shouldHandleError`. After removing `setShouldHandleError`, forwarding the option was the shim's only remaining job, so it is now a deprecated no-op kept purely so existing `setupFastifyErrorHandler(app)` calls do not break. The node-integration-test that covered the option was repointed at `fastifyIntegration({ shouldHandleError })`. Co-Authored-By: Opus 5 <noreply@anthropic.com>
s1gr1d
requested review from
JPeer264 and isaacs
and removed request for
a teamAugust 27, 2026 09:13
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error filtering is now configured exclusively through
fastifyIntegration({ shouldHandleError }).setupFastifyErrorHandlerno longer accepts handler options.closes#22253