Skip to content

ref(express)!: Export a single ExpressIntegrationOptions type - #23763

Merged
s1gr1d merged 2 commits into
developfrom
sig/handle-error-type
Sep 1, 2026
Merged

ref(express)!: Export a single ExpressIntegrationOptions type#23763
s1gr1d merged 2 commits into
developfrom
sig/handle-error-type

Conversation

@s1gr1d

@s1gr1ds1gr1d commented Aug 31, 2026•
edited
Loading

Copy link
Copy Markdown
Member

First merge this: #23732

Raised by @isaacs in this comment: https://github.com/getsentry/sentry-javascript/pull/23732/changes#r3890547157

ExpressIntegrationOptions was exported publicly from two places under the same name. The one from @sentry/core is deprecated and has no shouldHandleError.
The one from @sentry/server-utils has it but was unreachable, because @sentry/node re-exports neither. TypeScript users had no way to type a shouldHandleError callback for expressIntegration().

@s1gr1d
s1gr1d requested review from a team as code ownersAugust 31, 2026 11:52
@s1gr1d
s1gr1d requested review from isaacs and mydea and removed request for a teamAugust 31, 2026 11:52
@s1gr1ds1gr1d changed the title test(express): Error handler tests ref(express)!: Export a single ExpressIntegrationOptions typeAug 31, 2026
@s1gr1d
s1gr1d changed the base branch from develop to sig/express-handleErrorAugust 31, 2026 11:53
This was referenced Aug 31, 2026
Merged
Merged
@s1gr1d
s1gr1dforce-pushed the sig/handle-error-type branch from 163fc2f to 46630d2CompareAugust 31, 2026 14:59
Base automatically changed from sig/express-handleError to developAugust 31, 2026 14:59
@s1gr1d
s1gr1dforce-pushed the sig/handle-error-type branch from 46630d2 to 5821de7CompareAugust 31, 2026 14:59
@github-actions

github-actionsBot commented Aug 31, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser28.56 kB--
@sentry/browser - with treeshaking flags26.92 kB--
@sentry/browser - with treeshaking flags tracing without tracing26.82 kB--
@sentry/browser (incl. Tracing)48.86 kB--
@sentry/browser (incl. Tracing + Span Streaming)48.87 kB--
@sentry/browser (incl. Tracing, Profiling)51.79 kB--
@sentry/browser (incl. Tracing, Replay)88.35 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags77.75 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)93.04 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)106 kB--
@sentry/browser (incl. Feedback)46.05 kB--
@sentry/browser (incl. sendFeedback)33.62 kB--
@sentry/browser (incl. FeedbackAsync)38.73 kB--
@sentry/browser (incl. Metrics)29.51 kB--
@sentry/browser (incl. Logs)29.8 kB--
@sentry/browser (incl. Metrics & Logs)30.43 kB--
@sentry/react30.3 kB--
@sentry/react (incl. Tracing)51.06 kB--
@sentry/vue35.73 kB--
@sentry/vue (incl. Tracing)51.13 kB--
@sentry/svelte28.59 kB--
CDN Bundle30.35 kB--
CDN Bundle (incl. Tracing)49.5 kB--
CDN Bundle (incl. Logs, Metrics)32.58 kB--
CDN Bundle (incl. Tracing, Logs, Metrics)51.41 kB--
CDN Bundle (incl. Replay, Logs, Metrics)73.17 kB--
CDN Bundle (incl. Tracing, Replay)87 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics)88.86 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)92.93 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics)94.83 kB--
CDN Bundle - uncompressed89.95 kB--
CDN Bundle (incl. Tracing) - uncompressed147.56 kB--
CDN Bundle (incl. Logs, Metrics) - uncompressed96.24 kB--
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed153.25 kB--
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed225.41 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed267.05 kB--
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed272.73 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed280.75 kB--
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed286.42 kB--
@sentry/nextjs (client)53.68 kB--
@sentry/sveltekit (client)49.29 kB--
@sentry/core/server40.72 kB--
@sentry/core/browser13.42 kB--
@sentry/node123.83 kB+0.02%+20 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection)81.4 kB--
@sentry/node - without tracing88.13 kB+0.03%+25 B 🔺
@sentry/node - without channel injection103.26 kB+0.02%+17 B 🔺
@sentry/aws-serverless96.48 kB+0.03%+24 B 🔺
@sentry/cloudflare (withSentry) - minified201.21 kB--
@sentry/cloudflare (withSentry)500.7 kB--

View base workflow run

s1gr1d added a commit that referenced this pull request Aug 31, 2026
@s1gr1d
feat(v10/node): Deprecate shouldHandleError on `setupExpressErrorHa…
bea4d38
…ndler` and `setupFasitfyErrorHandler` (#23734)
Express:
- #23732
- #23464
- #23763
Fastify:
- #23460
- #23464
- #23411
@s1gr1d
Merge remote-tracking branch 'origin/develop' into sig/handle-error-type
6416c60
# Conflicts:
#	packages/core/src/server-exports.ts
@s1gr1d
s1gr1d merged commit 6327be6 into developSep 1, 2026
556 of 558 checks passed
@s1gr1d
s1gr1d deleted the sig/handle-error-type branch September 1, 2026 15:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@isaacsisaacsAwaiting requested review from isaacsisaacs was automatically assigned from getsentry/team-javascript-sdks-server

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s1gr1d@mydea