Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port React Router framework E2E apps to span streaming - #23844
Merged
Conversation
Contributor
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 1, 2026 14:21
75dab6a to
ae51708Compareandreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 1, 2026 14:56
7d5db09 to
d50ce36Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
2 times, most recently
from
September 1, 2026 16:05
47e95de to
5ecb95aCompareUh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 1, 2026 16:51
d50ce36 to
b03837aCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
2 times, most recently
from
September 2, 2026 08:23
adf8c96 to
e2c7572Compareandreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 08:23
b03837a to
d33d48cCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 08:46
e2c7572 to
05a6dbdCompareandreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
2 times, most recently
from
September 2, 2026 09:05
8870eb6 to
2ed771fCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 09:05
05a6dbd to
4736942Compareandreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 09:30
2ed771f to
7e3b354Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 09:30
4736942 to
7700c10CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7700c10. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 10:01
7e3b354 to
638598aCompareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 10:01
7700c10 to
06f7731Compareandreiborzaforce-pushed
the
ab/js-3482/spa-apps
branch
from
September 2, 2026 10:07
638598a to
5b28e50Compareandreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 10:07
06f7731 to
bd73839Compare
Base automatically changed from
ab/js-3482/spa-apps to
ab/js-3482/data-routersSeptember 2, 2026 11:20
andreiborza
marked this pull request as ready for review
September 2, 2026 11:43
JPeer264
approved these changes
Sep 2, 2026
JPeer264
left a comment
Member
There was a problem hiding this comment.
LGTM. Biggest PR I've reviewed in a long time.
Member
There was a problem hiding this comment.
note: Odd that these files weren't triggered as "rename" - I think then the PR would have been smaller
MemberAuthor
There was a problem hiding this comment.
Oof sorry, I think something went wrong when I broke up my stacked PR :(
Removes the `traceLifecycle: 'static'` pin from `react-router-7-framework`, `react-router-8-framework` and `react-router-7-framework-spa`, and rewrites their specs against streamed span v2. Envelope-level metadata has no span equivalent, so the SDK assertions read the `sentry.sdk.*` and `sentry.environment` attributes instead, and the `runtime` tag assertions are dropped. The trace connection spec is keyed off the `sentry-trace` meta tag. Spans are buffered before they flush, so an earlier page load on `/` can still be arriving here, and matching the two halves independently paired spans from different loads. The document advertises its own trace, and the client span is selected by the parent it continues, so a pageload that failed to continue the trace still fails the test rather than passing vacuously.
…streaming (#23845) ## What Ports `react-router-7-framework-instrumentation` to span streaming. ## Why Span streaming is the default now, so the E2E suite has to exercise it. Loader, action, middleware and fetcher assertions walk the streamed trace instead of a transaction's `spans` array, and the orchestrion mysql spec matches on `db.query.text`, since a streamed mysql span is named after its query summary. Part of #23798
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 12:27
0424336 to
be21d07CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Lms24 added a commit
that referenced
this pull request
Sep 2, 2026
#23844 ported this app to span streaming while this branch was open, so its ioredis assertions still expected the serialized command as the span name. The route builds its client without a host or port, so the name reports ioredis' own `localhost:6379` defaults, which the expectations now pin as `server.address`/`server.port` too. The duplicate-span check keys off `db.query.text`, which still tells the two commands apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-framework,react-router-8-frameworkandreact-router-7-framework-spato span streaming.Why
Span streaming is the default now, so the E2E suite has to exercise it. Envelope-level metadata has no span equivalent, so the SDK assertions read the
sentry.sdk.*andsentry.environmentattributes instead and theruntimetag assertions are dropped. The trace-connection spec matches the server segment on its op rather than its name, because an unparameterized streamed server span is named after the method alone.Part of #23798