Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port the React Router lazy routes E2E app to span streaming - #23846
Merged
Conversation
Contributor
size-limit report 📦
|
andreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 1, 2026 14:21
2cc3dfd to
9083cbfCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 14:56
2f982ae to
a9e6808Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 1, 2026 14:56
9083cbf to
ea78db3Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 15:43
a9e6808 to
8126529Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 1, 2026 15:43
ea78db3 to
797611dCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 15:55
8126529 to
cf5c7f9Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 1, 2026 15:55
797611d to
2460015Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:05
cf5c7f9 to
9e03698Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
2 times, most recently
from
September 1, 2026 16:37
e5246b4 to
aa2cbfcCompareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:37
9e03698 to
edd1076Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 1, 2026 16:51
aa2cbfc to
cd0da76Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 1, 2026 16:51
edd1076 to
7d44686CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 2, 2026 08:23
cd0da76 to
c243026Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 08:23
7d44686 to
d638522CompareUh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 08:46
d638522 to
979eaa0Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
2 times, most recently
from
September 2, 2026 09:05
a20f314 to
b76c163Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 09:05
979eaa0 to
01f6e5dCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b76c163. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
andreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 09:30
01f6e5d to
9d1bbdaCompareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 2, 2026 09:30
b76c163 to
cbeb816Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 10:01
9d1bbda to
1db63f1Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 2, 2026 10:01
cbeb816 to
8d5a351Compareandreiborzaforce-pushed
the
ab/js-3482/instrumentation-api
branch
from
September 2, 2026 10:07
1db63f1 to
107a1e4Compareandreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 2, 2026 10:07
8d5a351 to
ba9bc18Compareandreiborza
marked this pull request as ready for review
September 2, 2026 11:44
JPeer264
approved these changes
Sep 2, 2026
Base automatically changed from
ab/js-3482/instrumentation-api to
ab/js-3482/framework-appsSeptember 2, 2026 12:25
Removes the `traceLifecycle: 'static'` pin from `react-router-7-framework`, `react-router-8-framework` and `react-router-7-framework-spa`, and rewrites their specs against streamed span v2. Envelope-level metadata has no span equivalent, so the SDK assertions read the `sentry.sdk.*` and `sentry.environment` attributes instead, and the `runtime` tag assertions are dropped. The trace connection spec is keyed off the `sentry-trace` meta tag. Spans are buffered before they flush, so an earlier page load on `/` can still be arriving here, and matching the two halves independently paired spans from different loads. The document advertises its own trace, and the client span is selected by the parent it continues, so a pageload that failed to continue the trace still fails the test rather than passing vacuously.
…streaming (#23845) ## What Ports `react-router-7-framework-instrumentation` to span streaming. ## Why Span streaming is the default now, so the E2E suite has to exercise it. Loader, action, middleware and fetcher assertions walk the streamed trace instead of a transaction's `spans` array, and the orchestrion mysql spec matches on `db.query.text`, since a streamed mysql span is named after its query summary. Part of #23798
andreiborzaforce-pushed
the
ab/js-3482/framework-apps
branch
from
September 2, 2026 12:27
0424336 to
be21d07CompareRemoves the `traceLifecycle: 'static'` pin from `react-router-7-lazy-routes` and rewrites its specs against streamed span v2. The span-leaking and GQL attribution specs group streamed spans by trace instead of reading a transaction's `spans` array, and they match fetch spans on `url.full`, since a streamed `http.client` span carries only the domain in its name.
collectStreamedSpans scopes its result to one trace now, so the GQL and slow-fetch lookups no longer need to filter children by the segment's trace id, and three segment lookups that only existed to supply it are gone. The corruption test keeps the trace-scoped helper, since it collects across traces on purpose.
andreiborzaforce-pushed
the
ab/js-3482/lazy-routes
branch
from
September 2, 2026 12:27
de1f81c to
b811d6bCompareJPeer264
approved these changes
Sep 2, 2026
JPeer264
approved these changes
Sep 2, 2026
JPeer264
approved these changes
Sep 2, 2026
JPeer264
approved these changes
Sep 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports
react-router-7-lazy-routesto span streaming, the last app in the group.Why
Span streaming is the default now, so the E2E suite has to exercise it. The span-leaking and GQL attribution specs group streamed spans by trace instead of reading a transaction's
spansarray, and they match fetch spans onurl.full, since a streamedhttp.clientspan carries only the domain in its name.Closes: #23798