Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port nextjs-orpc to span streaming - #23870
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
chargomeforce-pushed
the
test/e2e-port-nextjs-orpc
branch
4 times, most recently
from
September 2, 2026 10:58
dc21e7f to
df6fc2cComparechargome
marked this pull request as ready for review
September 2, 2026 13:10
Uh oh!
There was an error while loading. Please reload this page.
andreiborza
approved these changes
Sep 2, 2026
Comment on lines
+17
to
+18
| spans.some(span => span.name === ORPC_SEGMENT_NAME && span.is_segment && span.trace_id === pageload.trace_id) && | ||
| spans.some(span => span.name === 'ORPC Middleware' && span.trace_id === pageload.trace_id) |
Member
There was a problem hiding this comment.
The trace id conditions should no longer be necessary I think 🤔
| const pageloadSpan = spans.find(span => span.name === '/' && getSpanOp(span) === 'pageload' && span.is_segment)!; | ||
| const orpcSpan = spans.find( | ||
| span => span.name === ORPC_SEGMENT_NAME && span.is_segment && span.trace_id === pageloadSpan.trace_id, |
JPeer264
approved these changes
Sep 2, 2026
| return ( | ||
| !!pageload && | ||
| spans.some(span => span.name === ORPC_SEGMENT_NAME && span.is_segment && span.trace_id === pageload.trace_id) && | ||
| spans.some(span => span.name === 'ORPC Middleware' && span.trace_id === pageload.trace_id) |
Member
There was a problem hiding this comment.
l: There were some changes made in #23912 so you can get rid of this check: span.trace_id === pageload.trace_id. You need to rebase though 🤞
(I had this here too: #23862 (comment))
Removes the `traceLifecycle: 'static'` pins and rewrites the tracing specs onto streamed spans. Both tests assert that an `ORPC Middleware` child span sits under the route handler segment. Streamed children arrive in later envelopes than their segment, so these use `collectStreamedSpans` and wait for both the segment and the child before asserting. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
test/e2e-port-nextjs-orpc
branch
from
September 2, 2026 13:42
df6fc2c to
fb01b2eCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-orpcto span streaming: removes thetraceLifecycle: 'static'pins and rewrites the tracing specs onto streamed spans, usingcollectStreamedSpansfor theORPC Middlewarechild assertions.Ref #23802