Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port nextjs-pages-dir to span streaming - #23914
Merged
chargome merged 1 commit intoSep 2, 2026
Conversation
Contributor
size-limit report 📦
|
chargomeforce-pushed
the
test/e2e-port-nextjs-pages-dir
branch
from
September 2, 2026 09:54
e784010 to
82a2df0Comparechargomeforce-pushed
the
test/e2e-port-nextjs-pages-dir
branch
3 times, most recently
from
September 2, 2026 10:58
c3bebe4 to
7472acaComparechargome
marked this pull request as ready for review
September 2, 2026 13:17
JPeer264
approved these changes
Sep 2, 2026
| const outerSpan = asyncContextEdgerouteTransaction.spans?.find(span => span.description === 'outer-span'); | ||
| const innerSpan = asyncContextEdgerouteTransaction.spans?.find(span => span.description === 'inner-span'); | ||
| const outerSpan = spans.find(span => span.name === 'outer-span' && span.trace_id === segmentSpan.trace_id); |
andreiborza
approved these changes
Sep 2, 2026
Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans. Tests asserting on children of a segment span (async context isolation, middleware fetch) use `collectStreamedSpans` and accumulate until the segment span, which ends last. `http.client` span names are low cardinality under streaming, so the middleware fetch span is named `GET localhost` rather than `GET http://localhost:3030/`. The URL is still asserted via `url.full`. Request headers carry over as `http.request.header.*` span attributes, so the `x-yeet` and `User-Agent` assertions are kept in that form. Dropped, having no span v2 equivalent: - Transaction-side `tags` (isolation scope). The error-side assertions still cover it. - The `contexts.runtime.name === 'vercel-edge'` matchers - the edge routes are uniquely named. - The middleware `breadcrumbs` assertion. Breadcrumbs live on events, not spans; the fetch is still covered by the `http.client` child span assertion in the same test. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
test/e2e-port-nextjs-pages-dir
branch
from
September 2, 2026 13:42
7472aca to
9f80d14CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-pages-dirto span streaming: removes thetraceLifecycle: 'static'pins and rewrites the specs onto streamed spans, usingcollectStreamedSpanswhere a test asserts on children of a segment span.Request headers carry over as
http.request.header.*span attributes, andhttp.clientspan names are low cardinality under streaming (GET localhost). Transaction-sidetagsand the middlewarebreadcrumbsassertion had no equivalent and were dropped; the fetch itself is still covered by itshttp.clientchild span.Ref #23802