Uh oh!
There was an error while loading. Please reload this page.
test(e2e): Port nextjs-16-cf-workers to span streaming - #23926
Merged
chargome merged 1 commit intoSep 2, 2026
Conversation
chargomeforce-pushed
the
test/e2e-port-nextjs-16-cf-workers
branch
from
September 2, 2026 11:18
20ecf1b to
4c7c437CompareContributor
size-limit report 📦
|
chargomeforce-pushed
the
test/e2e-port-nextjs-16-cf-workers
branch
from
September 2, 2026 11:58
4c7c437 to
ece94e5Comparechargome
marked this pull request as ready for review
September 2, 2026 13:22
andreiborza
approved these changes
Sep 2, 2026
Removes the `traceLifecycle: 'static'` pins and rewrites the specs onto streamed spans, completing the group. Most of this app's specs are already `test.skip`ped pending Cloudflare Workers SDK work; those are ported in place so they are span v2 when re-enabled, and their TODO notes are kept verbatim. `streaming-rsc-error` is newly skipped: under streaming the Workers runtime emits no server segment span for a request interrupted by a streaming RSC error, so the error-to-span correlation cannot be satisfied. The same spec passes on Node. See #23932 Like `nextjs-16-bun`, the parameterized-route specs assert fewer `url.*` attributes than `nextjs-16`, and request headers are not extracted as span attributes on Cloudflare Workers. The middleware isolation-scope and breadcrumb assertions were dropped, having no span v2 equivalent. Ref #23802 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargomeforce-pushed
the
test/e2e-port-nextjs-16-cf-workers
branch
from
September 2, 2026 13:43
ece94e5 to
e702483CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
nextjs-16-cf-workersto span streaming, completing the group: removes thetraceLifecycle: 'static'pins and rewrites the specs onto streamed spans.Most specs in this app are already
test.skipped pending Cloudflare Workers SDK work; they are ported in place so they are span v2 when re-enabled.streaming-rsc-erroris newly skipped - under streaming the Workers runtime emits no server segment span for a request interrupted by a streaming RSC error (#23932); the same spec passes on Node.Ref #23802