Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import type { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
import * as Sentry from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/nextjs';
import { Log } from '@sentry/nextjs';

Sentry.init({
traceLifecycle: 'static',
environment: 'qa', // dynamic sampling bias to keep transactions
dsn: process.env.NEXT_PUBLIC_E2E_TEST_DSN,
tunnel: `http://localhost:3031/`, // proxy server
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

test('should remove sentry-trace and baggage meta tags on ISR dynamic route page load', async ({ page }) => {
// Navigate to ISR page
Expand DownExpand Up@@ -41,15 +41,13 @@ test('should remove meta tags for different ISR dynamic route values', async ({
await expect(page.locator('meta[name="baggage"]')).toHaveCount(0);
});

test('should create unique transactions for ISR pages on each visit', async ({ page }) => {
test('should create unique traces for ISR pages on each visit', async ({ page }) => {
const traceIds: string[] = [];

// Load the same ISR page 5 times to ensure cached HTML meta tags are consistently removed
for (let i = 0; i < 5; i++) {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return !!(
transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload'
);
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

if (i === 0) {
Expand All@@ -58,8 +56,8 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
await page.reload();
}

const transaction = await transactionPromise;
const traceId = transaction.contexts?.trace?.trace_id;
const span = await spanPromise;
const traceId = span.trace_id;

expect(traceId).toBeDefined();
expect(traceId).toMatch(/[a-f0-9]{32}/);
Expand All@@ -72,23 +70,14 @@ test('should create unique transactions for ISR pages on each visit', async ({ p
});

test('ISR route should be identified correctly in the route manifest', async ({ page }) => {
const transactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent.transaction === '/isr-test/:product' && transactionEvent.contexts?.trace?.op === 'pageload';
const spanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/isr-test/:product' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto('/isr-test/laptop');
const transaction = await transactionPromise;

// Verify the transaction is properly parameterized
expect(transaction).toMatchObject({
transaction: '/isr-test/:product',
transaction_info: { source: 'route' },
contexts: {
trace: {
data: {
'sentry.segment.name.source': 'route',
},
},
},
});
const span = await spanPromise;

// Verify the span is properly parameterized
expect(span.name).toBe('/isr-test/:product');
expect(span.attributes['sentry.segment.name.source']?.value).toBe('route');
});
Original file line numberDiff line numberDiff line change
@@ -1,92 +1,77 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';
import { isDevMode } from './isDevMode';

// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware transactions reliably.
// TODO: Skipped until the Cloudflare Workers edge middleware setup emits middleware spans reliably.
test.skip('tracesSampler receives normalizedRequest for edge middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

await request.get('/api/endpoint-behind-middleware');

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.runtime?.name).toBe('cloudflare');
expect(middlewareTransaction.request?.url).toContain('/api/endpoint-behind-middleware');
expect(middlewareTransaction.request?.method).toBe('GET');
expect(String(middlewareSpan.attributes['http.target']?.value)).toContain('/api/endpoint-behind-middleware');
expect(middlewareSpan.attributes['http.request.method']?.value).toBe('GET');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should create a transaction for middleware', async ({ request }) => {
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
test.skip('Should create a span for middleware', async ({ request }) => {
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

const response = await request.get('/api/endpoint-behind-middleware');
expect(await response.json()).toStrictEqual({ name: 'John Doe' });

const middlewareTransaction = await middlewareTransactionPromise;
const middlewareSpan = await middlewareSpanPromise;

expect(middlewareTransaction.contexts?.trace?.status).toBe('ok');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');

// Assert that isolation scope works properly
expect(middlewareTransaction.tags?.['my-isolated-tag']).toBe(true);
// TODO: Isolation scope is not working properly yet
// expect(middlewareTransaction.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
expect(middlewareSpan.status).toBe('ok');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Faulty middlewares', async ({ request }) => {
test.skip(isDevMode, 'Throwing crashes the dev server atm'); // https://github.com/vercel/next.js/issues/85261
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

const errorEventPromise = waitForError('nextjs-16-cf-workers', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Middleware Error';
const middlewareSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'middleware GET' && span.is_segment;
});

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-throw': '1' } }).catch(() => {
// Noop
});

await test.step('should record transactions', async () => {
const middlewareTransaction = await middlewareTransactionPromise;
expect(middlewareTransaction.contexts?.trace?.status).toBe('internal_error');
expect(middlewareTransaction.contexts?.trace?.op).toBe('middleware');
expect(middlewareTransaction.contexts?.runtime?.name).toBe('vercel-edge');
expect(middlewareTransaction.transaction_info?.source).toBe('route');
await test.step('should record spans', async () => {
const middlewareSpan = await middlewareSpanPromise;
expect(middlewareSpan.status).toBe('error');
expect(getSpanOp(middlewareSpan)).toBe('middleware');
expect(middlewareSpan.attributes['sentry.segment.name.source']?.value).toBe('route');
});
});

// TODO: Middleware tests need SDK adjustments for Cloudflare Workers edge runtime
test.skip('Should trace outgoing fetch requests inside middleware and create breadcrumbs for it', async ({
request,
}) => {
test.skip('Should trace outgoing fetch requests inside middleware', async ({ request }) => {
test.skip(isDevMode, 'The fetch requests ends up in a separate tx in dev atm');
const middlewareTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'middleware GET';
});

// `http.client` span names are low cardinality under span streaming, hence `GET localhost` rather
// than the full URL.
const spansPromise = collectStreamedSpans('nextjs-16-cf-workers', spans =>
spans.some(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost'),
);

request.get('/api/endpoint-behind-middleware', { headers: { 'x-should-make-request': '1' } }).catch(() => {
// Noop
});

const middlewareTransaction = await middlewareTransactionPromise;

// Breadcrumbs should always be created for the fetch request
expect(middlewareTransaction.breadcrumbs).toEqual(
expect.arrayContaining([
{
category: 'http',
data: { 'http.request.method': 'GET', status_code: 200, url: 'http://localhost:3030/' },
timestamp: expect.any(Number),
type: 'http',
},
]),
);
const spans = await spansPromise;
const fetchSpan = spans.find(span => getSpanOp(span) === 'http.client' && span.name === 'GET localhost')!;

expect(fetchSpan.status).toBe('ok');
expect(fetchSpan.attributes).toMatchObject({
'http.request.method': { value: 'GET', type: 'string' },
'http.response.status_code': { value: 200, type: 'integer' },
'url.full': { value: 'http://localhost:3030/', type: 'string' },
});
});
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
import { waitForError, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('Should capture errors from nested server components when `Sentry.captureRequestError` is added to the `onRequestError` hook', async ({
Expand All@@ -9,16 +9,21 @@ test.skip('Should capture errors from nested server components when `Sentry.capt
return !!errorEvent?.exception?.values?.some(value => value.value === 'I am technically uncatchable');
});

const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /nested-rsc-error/[param]';
// Matched on the error's own trace so a span from an earlier spec cannot satisfy the correlation.
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', async span => {
return (
span.name === 'GET /nested-rsc-error/[param]' &&
span.is_segment &&
(await errorEventPromise).contexts?.trace?.trace_id === span.trace_id
);
});

await page.goto(`/nested-rsc-error/123`);
const errorEvent = await errorEventPromise;
const serverTransactionEvent = await serverTransactionPromise;
const serverSpan = await serverSpanPromise;

// error event is part of the transaction
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverTransactionEvent.contexts?.trace?.trace_id);
// error event is part of the same trace as the server span
expect(errorEvent.contexts?.trace?.trace_id).toBe(serverSpan.trace_id);

expect(errorEvent.request).toMatchObject({
headers: expect.any(Object),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,32 @@
import { expect, test } from '@playwright/test';
import { waitForTransaction } from '@sentry-internal/test-utils';
import { getSpanOp, waitForStreamedSpan } from '@sentry-internal/test-utils';

// TODO: Flakey on CI
test.skip('App router transactions should be attached to the pageload request span', async ({ page }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
test.skip('App router spans should be attached to the pageload request span', async ({ page }) => {
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === 'GET /pageload-tracing' && span.is_segment;
});

const pageloadTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === '/pageload-tracing';
const pageloadSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return span.name === '/pageload-tracing' && getSpanOp(span) === 'pageload' && span.is_segment;
});

await page.goto(`/pageload-tracing`);

const [serverTransaction, pageloadTransaction] = await Promise.all([
serverTransactionPromise,
pageloadTransactionPromise,
]);
const [serverSpan, pageloadSpan] = await Promise.all([serverSpanPromise, pageloadSpanPromise]);

const pageloadTraceId = pageloadTransaction.contexts?.trace?.trace_id;

expect(pageloadTraceId).toBeTruthy();
expect(serverTransaction.contexts?.trace?.trace_id).toBe(pageloadTraceId);
expect(pageloadSpan.trace_id).toBeTruthy();
expect(serverSpan.trace_id).toBe(pageloadSpan.trace_id);
});

// TODO: HTTP request headers are not extracted as span attributes on Cloudflare Workers
test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }) => {
const serverTransactionPromise = waitForTransaction('nextjs-16-cf-workers', async transactionEvent => {
return transactionEvent?.transaction === 'GET /pageload-tracing';
const serverSpanPromise = waitForStreamedSpan('nextjs-16-cf-workers', span => {
return (
span.name === 'GET /pageload-tracing' &&
span.is_segment &&
span.attributes['http.request.header.x_request_id']?.value === 'nextjs-789'
);
});

await fetch(`${baseURL}/pageload-tracing`, {
Expand All@@ -41,16 +40,14 @@ test.skip('extracts HTTP request headers as span attributes', async ({ baseURL }
},
});

const serverTransaction = await serverTransactionPromise;

expect(serverTransaction.contexts?.trace?.data).toEqual(
expect.objectContaining({
'http.request.header.user_agent': 'Custom-NextJS-Agent/15.0',
'http.request.header.content_type': 'text/html',
'http.request.header.x_nextjs_test': 'nextjs-header-value',
'http.request.header.accept': 'text/html, application/xhtml+xml',
'http.request.header.x_framework': 'Next.js',
'http.request.header.x_request_id': 'nextjs-789',
}),
);
const serverSpan = await serverSpanPromise;

expect(serverSpan.attributes).toMatchObject({
'http.request.header.user_agent': { value: 'Custom-NextJS-Agent/15.0', type: 'string' },
'http.request.header.content_type': { value: 'text/html', type: 'string' },
'http.request.header.x_nextjs_test': { value: 'nextjs-header-value', type: 'string' },
'http.request.header.accept': { value: 'text/html, application/xhtml+xml', type: 'string' },
'http.request.header.x_framework': { value: 'Next.js', type: 'string' },
'http.request.header.x_request_id': { value: 'nextjs-789', type: 'string' },
});
});
Loading
Loading