ref(node): Refactor node stack parsing to use common parser

[timfish]

This PR:

• Converts the node stack parser to be line orientated and return StackFrame | undefined
• Uses the common parser from @sentry/utils
• Updates the tests to cater for this
  • StackFrame[] are reversed
  • Additional fields added
• I have kept the top SyncPromise in the backend and removed promises from where they are not necessary.

[AbhiPrasad]

2 quick comments

[AbhiPrasad]

We can use optional chaining in node land since we down-compile when we transpile from TS -> JS

[timfish]

I had to revert the optional chaining because it broke a webpack test somewhere.

I'm going to have to some back the require issue later!

[AbhiPrasad]

Interesting, wonder what's going on. Is it the tests we have in https://github.com/getsentry/sentry-javascript/tree/master/packages/node/test/manual?

I think this is partly why we have utils like

sentry-javascript/packages/utils/src/node.ts

Lines 28 to 31 in 6809dd2

	exportfunctiondynamicRequire(mod: any,request: string): any{
	// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
	returnmod.require(request);
	}

[timfish]

It was actually the nextjs webpack tests that started failing.

The issue with dynamicRequire is that it's only designed to work with module.require.

module.require only gives you access to the require function. It does not include any other properties like require.main. This is only available on require which isn't even a regular global.

[AbhiPrasad]

Oh interesting, TIL about module.require details.

[AbhiPrasad]

Interesting, wonder what's going on. Is it the tests we have in https://github.com/getsentry/sentry-javascript/tree/master/packages/node/test/manual?

I think this is partly why we have utils like

sentry-javascript/packages/utils/src/node.ts

Lines 28 to 31 in 6809dd2

	exportfunctiondynamicRequire(mod: any,request: string): any{
	// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
	returnmod.require(request);
	}

[AbhiPrasad]

Think we are good to merge after the node parser name change, and fixing the rebase in the issue template!

[AbhiPrasad]

Oh interesting, TIL about module.require details.