Remove usage of deprecated `event.stacktrace` by timfish · Pull Request #4885 · getsentry/sentry-javascript

timfish · 2022-04-07T15:06:54Z

Removes usage of deprecated event.stacktrace

I'll add some inline comments to cover my remaining concerns...

Removes all references to `@sentry/apm`, a deprecated package we do not use anymore.

Removes the deprecated `API` class.

…ry#4849) Remove deprecated methods `startSpan` and `child`. These deprecated methods were removed in favour of `span.startChild`.

Removes `getActiveDomain` function and corresponding type.

The `user` dsn component was renamed to `publicKey`. This PR removes that from the dsn field.

…ntOutgoingRequests (getsentry#4859)

Increases the creation timeout of `MongoMemoryServer` to temporarily fix Node integration test flakiness

test + lint

timfish · 2022-04-07T17:12:07Z

This broke a lot more tests than I imagined it would. Is this because event.stacktrace was initially the default?

Does this mean this change likely to be high impact to customers?

AbhiPrasad · 2022-04-07T17:40:47Z

This actually broke a lot more tests than I imagined it would. Is this because event.stacktrace was initially the default?
Does this mean this change likely to be high impact to customers?

This is a good observation. I realized that most folks might have to make significant updates to beforeSend as a result. Putting this on the list to chat with the rest of the team - I’ll get back to you by tommorow.

lobsterkatie · 2022-04-07T20:20:05Z

@timfish FYI, now that we're on the v7 branch, we don't need to prefix PRs with [v7] anymore. 🎉

AbhiPrasad · 2022-04-11T15:07:09Z

Mind if you can rebase this? The diff is a little hard to read.

We chatted as a team, and we think it's fine for us to move off of event.stacktrace - let's go ahead with these changes!

…-event.stacktrace

timfish · 2022-04-11T17:47:37Z

Rebased. Is the Ember failure a flake?

AbhiPrasad · 2022-04-11T18:17:46Z

Yup - ember is a flake.

Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

AbhiPrasadand others added 12 commits April 7, 2022 13:32

[v7] feat: Remove references to @sentry/apm (getsentry#4845)
97e6ff3
Removes all references to `@sentry/apm`, a deprecated package we do not use anymore.

[v7] feat(core): Delete API class (getsentry#4848)
57d37c2
Removes the deprecated `API` class.

[v7] feat: Delete deprecatedstartSpanandchildmethods (getsent…
424df27
…ry#4849) Remove deprecated methods `startSpan` and `child`. These deprecated methods were removed in favour of `span.startChild`.

feat(core): Remove whitelistUrls/blacklistUrls (getsentry#4850)
5a7f145

feat(gatsby): Remove Sentry from window (getsentry#4857)
f855260

feat(hub): Remove getActiveDomain (getsentry#4858)
f1e9da2
Removes `getActiveDomain` function and corresponding type.

feat(types): Remove deprecated user dsn field (getsentry#4864)
55b0570
The `user` dsn component was renamed to `publicKey`. This PR removes that from the dsn field.

feat(hub): Remove setTransaction scope method (getsentry#4865)
2fc13c6

[v7] feat: Drop support for Node 6 (getsentry#4851)
20c7773

[v7] feat(tracing): Rename registerRequestInstrumentation -> instrume…
244eb0e
…ntOutgoingRequests (getsentry#4859)

fix(test): Increase MongoMemoryServer creation timeout (getsentry#4881)
285ca26
Increases the creation timeout of `MongoMemoryServer` to temporarily fix Node integration test flakiness

Removes usage of deprecated event.stacktrace
8afb70c

timfish commented Apr 7, 2022
View reviewed changes

Comment threadpackages/browser/src/eventbuilder.ts Outdated

timfish commented Apr 7, 2022
View reviewed changes

Comment threadpackages/node/src/eventbuilder.ts

add exception value
1bfb3aa

timfish commented Apr 7, 2022
View reviewed changes

Comment threadpackages/browser/src/eventbuilder.ts

timfish mentioned this pull request Apr 7, 2022
Refactor Stack Parsing #4543
Closed
15 tasks

timfish added 2 commits April 7, 2022 16:30

Remove redundent check
4c74bfa

Fix tests
270ce53

AbhiPrasad previously approved these changes Apr 7, 2022
View reviewed changes

AbhiPrasad reviewed Apr 7, 2022
View reviewed changes

Comment threadpackages/browser/src/integrations/dedupe.ts

timfish force-pushed the v7/remove-deprecated-event.stacktrace branch from 1131a9f to 04c3602Compare April 7, 2022 16:25

AbhiPrasad added this to the 7.0.0 milestone Apr 7, 2022

Fix dedup test and lint
6865b6e

timfish force-pushed the v7/remove-deprecated-event.stacktrace branch from 04c3602 to 6865b6eCompare April 7, 2022 16:59

Fix integration tests
5600f87

lobsterkatie changed the title ~~[v7] Remove usage of deprecated event.stacktrace~~Remove usage of deprecated event.stacktraceApr 7, 2022

lobsterkatie force-pushed the 7.x branch from 81b10fb to 9d29071Compare April 7, 2022 22:02

AbhiPrasad reviewed Apr 11, 2022
View reviewed changes

Comment threadpackages/browser/src/eventbuilder.ts

Merge remote-tracking branch 'upstream/7.x' into v7/remove-deprecated…
a91cecd
…-event.stacktrace

AbhiPrasad merged commit 2ecf1e5 into getsentry:7.xApr 11, 2022

lobsterkatie pushed a commit that referenced this pull request Apr 13, 2022
feat: Remove usage of deprecatedevent.stacktrace(#4885)
744252a
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

Lms24 pushed a commit that referenced this pull request Apr 26, 2022
feat: Remove usage of deprecatedevent.stacktrace(#4885)
c6f5cc0
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
ref(various): Remove usage of deprecatedevent.stacktrace(#4885)
56b855b
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
ref(various): Remove usage of deprecatedevent.stacktrace(#4885)
07d4ffd
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

timfish deleted the v7/remove-deprecated-event.stacktrace branch May 19, 2022 13:14

AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
ref(various): Remove usage of deprecatedevent.stacktrace(#4885)
99498dc
Removes usage of deprecated `event.stacktrace` and updated the event interface to remove the deprecated property.

plibither8 mentioned this pull request Aug 3, 2022
chore: Update @sentry/browser to latest version sourcegraph/sourcegraph-public-snapshot#39901
Merged

Navigation Menu

Uh oh!

Uh oh!

Remove usage of deprecated `event.stacktrace` - #4885

Remove usage of deprecated `event.stacktrace`#4885
AbhiPrasad merged 18 commits into
getsentry:7.xfrom
timfish:v7/remove-deprecated-event.stacktrace

timfish commented Apr 7, 2022•
edited by AbhiPrasad
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timfish commented Apr 7, 2022•
edited
Loading

Uh oh!

AbhiPrasad commented Apr 7, 2022

Uh oh!

lobsterkatie commented Apr 7, 2022

Uh oh!

Uh oh!

AbhiPrasad commented Apr 11, 2022

Uh oh!

timfish commented Apr 11, 2022

Uh oh!

AbhiPrasad commented Apr 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

timfish commented Apr 7, 2022• edited by AbhiPrasad Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timfish commented Apr 7, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbhiPrasad commented Apr 7, 2022

Uh oh!

lobsterkatie commented Apr 7, 2022

Uh oh!

Uh oh!

AbhiPrasad commented Apr 11, 2022

Uh oh!

timfish commented Apr 11, 2022

Uh oh!

AbhiPrasad commented Apr 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

timfish commented Apr 7, 2022•
edited by AbhiPrasad
Loading

timfish commented Apr 7, 2022•
edited
Loading