Uh oh!
There was an error while loading. Please reload this page.
feat: Put abs_path into stack frame object - #7167
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Contributor
Replay SDK metrics 🚀
develop | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| a961e57 | +54.75 ms | -0.00 ms | +6.50 pp | +929.18 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +92.73 ms |
| f7c0a2f | +46.14 ms | +0.00 ms | +6.37 pp | +921.47 kB | +1.06 MB | +2.23 kB | +41 B | +1 | +207.30 ms |
| cb19818 | +57.16 ms | +0.00 ms | +11.95 pp | +1.07 MB | +2.21 MB | +2.52 kB | +41 B | +1 | +111.50 ms |
| ee301c3 | +71.07 ms | -0.00 ms | +12.64 pp | +1.07 MB | +2.22 MB | +2.55 kB | +41 B | +1 | +94.67 ms |
| 93c4759 | +61.10 ms | -0.00 ms | +12.72 pp | +1.08 MB | +2.19 MB | +2.57 kB | +41 B | +1 | +116.75 ms |
| 274f489 | +63.60 ms | -0.00 ms | +11.56 pp | +1.08 MB | +2.2 MB | +2.56 kB | +41 B | +1 | +116.60 ms |
| 4827b60 | +58.67 ms | +0.00 ms | +18.38 pp | +1.07 MB | +2.22 MB | +2.6 kB | +41 B | +1 | +91.21 ms |
| c3806eb | +79.85 ms | -0.00 ms | +12.10 pp | +1.05 MB | +2.16 MB | +2.54 kB | +41 B | +1 | +93.58 ms |
| b49d9f7 | +52.79 ms | -0.00 ms | +15.46 pp | +1.07 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +70.48 ms |
| 7e57cb7 | +47.89 ms | +0.00 ms | +10.59 pp | +1.09 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +72.93 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Tue, 14 Feb 2023 08:34:12 GMT
Last updated: Tue, 14 Feb 2023 08:34:12 GMT
mydea
approved these changes
Feb 14, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
LGTM! Would be nice to be able to enforce that it is immutable, but I guess that's OK this way as well.
AbhiPrasad pushed a commit
that referenced
this pull request
Feb 14, 2023
ramchaik pushed a commit
to ramchaik/sentry-javascript
that referenced
this pull request
Feb 14, 2023
krystofwoldrich added a commit
to getsentry/sentry-react-native
that referenced
this pull request
Mar 13, 2023
… default stack parser related changes in JS getsentry/sentry-javascript#7167
10 tasks
lforst pushed a commit
that referenced
this pull request
Mar 27, 2023
lforst pushed a commit
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #7161 (comment)
In order to have a mapping from filename to debug_id for #7161 (comment) we need to have a record of a file name that is generally considered immutable:
abs_path.This PR puts the
abs_pathproperty onto stack frames when generating them. Usually, it is just equivalent tofilename.We consider this change safe since Relay just copies
filenameover toabs_pathif it is missing: https://github.com/getsentry/relay/blob/1e470ec87aee8fb9214844a1cf5eaa5257ea3d69/relay-general/src/store/normalize/stacktrace.rs#L27-L29