Skip to content

fix(frames): remove non absolute non url frame.abs_path coming from default stack parser - #2891

Merged
krystofwoldrich merged 6 commits into
mainfrom
kw-fix-source-maps-5-1-0
Mar 14, 2023
Merged

fix(frames): remove non absolute non url frame.abs_path coming from default stack parser#2891
krystofwoldrich merged 6 commits into
mainfrom
kw-fix-source-maps-5-1-0

Conversation

@krystofwoldrich

@krystofwoldrichkrystofwoldrich commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

In JS SDK frame.abs_path was added and that caused the from.abs_path to be relative. This lead to source maps failure in the product.

related changes in JS getsentry/sentry-javascript#7167

💡 Motivation and Context

fixes: #2879

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Add test so this won't happen again

krystofwoldrich
krystofwoldrich commented Mar 13, 2023
View reviewed changes
Comment threadCHANGELOG.md Outdated
marandaneto
marandaneto reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/js/sdk.tsx Outdated
@github-actions

github-actionsBot commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time423.74 ms455.24 ms31.50 ms
Size17.73 MiB20.04 MiB2.31 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
76d1baf+dirty335.72 ms355.52 ms19.80 ms
86d6d2c+dirty332.90 ms352.45 ms19.55 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
9a3ca65+dirty326.93 ms330.14 ms3.21 ms
d197b5c+dirty338.94 ms354.87 ms15.93 ms
e73f4ed+dirty332.96 ms354.33 ms21.37 ms

App size

RevisionPlainWith SentryDiff
76d1baf+dirty17.73 MiB20.04 MiB2.31 MiB
86d6d2c+dirty17.73 MiB20.04 MiB2.31 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
9a3ca65+dirty17.73 MiB20.04 MiB2.31 MiB
d197b5c+dirty17.73 MiB20.04 MiB2.31 MiB
e73f4ed+dirty17.73 MiB20.04 MiB2.31 MiB

@github-actions

github-actionsBot commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1263.32 ms1279.75 ms16.43 ms
Size2.36 MiB2.83 MiB474.50 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
76d1baf+dirty1244.10 ms1268.52 ms24.42 ms
86d6d2c+dirty1267.55 ms1286.21 ms18.66 ms
52a8031+dirty1280.88 ms1289.78 ms8.90 ms
9a3ca65+dirty1247.06 ms1274.58 ms27.52 ms
d197b5c+dirty1217.61 ms1242.66 ms25.05 ms
e73f4ed+dirty1243.27 ms1244.52 ms1.25 ms

App size

RevisionPlainWith SentryDiff
76d1baf+dirty2.36 MiB2.82 MiB469.45 KiB
86d6d2c+dirty2.36 MiB2.82 MiB462.82 KiB
52a8031+dirty2.36 MiB2.82 MiB469.44 KiB
9a3ca65+dirty2.36 MiB2.82 MiB462.89 KiB
d197b5c+dirty2.36 MiB2.82 MiB462.86 KiB
e73f4ed+dirty2.36 MiB2.82 MiB469.44 KiB

@github-actions

github-actionsBot commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1269.78 ms1277.70 ms7.92 ms
Size2.92 MiB3.39 MiB481.60 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
76d1baf+dirty1245.00 ms1257.76 ms12.76 ms
86d6d2c+dirty1291.62 ms1296.80 ms5.18 ms
52a8031+dirty1255.96 ms1273.00 ms17.04 ms
9a3ca65+dirty1276.40 ms1279.14 ms2.74 ms
d197b5c+dirty1234.80 ms1249.20 ms14.40 ms
e73f4ed+dirty1282.90 ms1309.30 ms26.40 ms

App size

RevisionPlainWith SentryDiff
76d1baf+dirty2.92 MiB3.38 MiB475.74 KiB
86d6d2c+dirty2.92 MiB3.37 MiB464.31 KiB
52a8031+dirty2.92 MiB3.38 MiB475.71 KiB
9a3ca65+dirty2.92 MiB3.37 MiB464.32 KiB
d197b5c+dirty2.92 MiB3.37 MiB464.41 KiB
e73f4ed+dirty2.92 MiB3.38 MiB475.71 KiB

@github-actions

github-actionsBot commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time260.79 ms309.59 ms48.80 ms
Size7.15 MiB8.09 MiB966.13 KiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
76d1baf+dirty339.02 ms408.65 ms69.63 ms
86d6d2c+dirty267.21 ms325.24 ms58.04 ms
52a8031+dirty330.72 ms358.76 ms28.03 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms
d197b5c+dirty258.75 ms313.61 ms54.86 ms
e73f4ed+dirty262.98 ms311.02 ms48.04 ms

App size

RevisionPlainWith SentryDiff
76d1baf+dirty7.15 MiB8.09 MiB964.41 KiB
86d6d2c+dirty7.15 MiB8.09 MiB962.69 KiB
52a8031+dirty7.15 MiB8.09 MiB965.95 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB
d197b5c+dirty7.15 MiB8.09 MiB962.72 KiB
e73f4ed+dirty7.15 MiB8.09 MiB965.94 KiB

@krystofwoldrich
krystofwoldrich marked this pull request as ready for review March 13, 2023 20:48
@krystofwoldrich

krystofwoldrich commented Mar 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@marandaneto I've added tests for the rewrite frames. Could you review it too?

marandaneto
marandaneto approved these changes Mar 14, 2023
View reviewed changes

@marandanetomarandaneto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the approach of splitting up the RewriteFrames and making it testable + adding unit tests for multiple cases, thank you!

@krystofwoldrichkrystofwoldrich mentioned this pull request Mar 14, 2023
Closed
@krystofwoldrich
krystofwoldrich merged commit 15c80ab into mainMar 14, 2023
@krystofwoldrich
krystofwoldrich deleted the kw-fix-source-maps-5-1-0 branch March 14, 2023 09:22
@Eden-ElielEden-Eliel mentioned this pull request Mar 23, 2023
Closed
11 tasks
@krystofwoldrichkrystofwoldrich mentioned this pull request Jun 14, 2023
Closed
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@marandanetomarandanetomarandaneto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The abs_path of the stack frame is index.android.bundle which is not a valid URL

2 participants

@krystofwoldrich@marandaneto