Uh oh!
There was an error while loading. Please reload this page.
test(replay): Ensure LCP spans have equals start and end timestamps (Playwright) - #7229
Merged
billyvg merged 1 commit intoFeb 21, 2023
Merged
Conversation
mydea
commented
Feb 20, 2023
Member
should we just PR this against this branch #7225 and merge in into there? Looks like a win to me! |
Lms24
marked this pull request as ready for review
February 20, 2023 14:28
Lms24
commented
Feb 20, 2023
MemberAuthor
Sure, totally fine with me |
billyvg
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #7225, draft until merged, otherwise ready
Just adds a check for timestamp equality of LCP perf span start and end times