Skip to content

test(replay): Ensure LCP spans have equals start and end timestamps (Playwright)#7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
Feb 21, 2023
Merged

test(replay): Ensure LCP spans have equals start and end timestamps (Playwright) #7229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/integration-tests/suites/replay/customEvents/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,7 @@ import {
expectedNavigationPerformanceSpan,
getExpectedReplayEvent,
} from '../../../utils/replayEventTemplates';
import type { PerformanceSpan } from '../../../utils/replayHelpers';
import {
getCustomRecordingEvents,
getReplayEvent,
Expand DownExpand Up@@ -68,6 +69,13 @@ sentryTest(
expectedMemoryPerformanceSpan,
]),
);

const lcpSpan = collectedPerformanceSpans.find(
s => s.description === 'largest-contentful-paint',
) as PerformanceSpan;

// LCP spans should be point-in-time spans
expect(lcpSpan?.startTimestamp).toBeCloseTo(lcpSpan?.endTimestamp);
},
);

Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/utils/replayHelpers.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@ import type { Page, Request } from 'playwright';
import { envelopeRequestParser } from './helpers';

type CustomRecordingEvent = { tag: string; payload: Record<string, unknown> };
type PerformanceSpan = {
export type PerformanceSpan = {
op: string;
description: string;
startTimestamp: number;
Expand Down