Skip to content

feat(tracing): Add tracing-internal package - #7418

Closed
timfish wants to merge 3 commits into
getsentry:developfrom
timfish:feat/tracing-internal
Closed

feat(tracing): Add tracing-internal package#7418
timfish wants to merge 3 commits into
getsentry:developfrom
timfish:feat/tracing-internal

Conversation

@timfish

@timfishtimfish commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

This PR:

  • Adds a tracing-internal package
  • Moves all the code (minus side-effects) from @sentry/tracing to tracing-internal
  • Moves tests that require private types to tracing-internal
  • Ensures BrowserTracing is exported separately from tracing-internal for tree-shaking

@timfish

Copy link
Copy Markdown
CollaboratorAuthor

The build passes fine on my machine. I've tried clearing the nx cache locally and get the same 🤔.

Instead of attempting to bundle the private @sentry-internal/tracing code into @sentry/tracing and getting all the typescript definitions bundled too... how about making @sentry-internal/tracing public and publishing it. It would be a lot less work for what is only a stop-gap solution.

@timfishtimfish changed the title feat(tracing): Add tracing-internal private packagefeat(tracing): Add tracing-internal packageMar 12, 2023
@AbhiPrasad

Copy link
Copy Markdown
Contributor

how about making @sentry-internal/tracing public and publishing it

let's just do this - we can leave a note in the readme that nobody should be installing this - and we don't have to publish it in the release registry.

@timfish

timfish commented Mar 13, 2023

Copy link
Copy Markdown
CollaboratorAuthor

@timfishtimfish closed this Mar 13, 2023
@timfish
timfish deleted the feat/tracing-internal branch March 14, 2023 15:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@timfish@AbhiPrasad