Uh oh!
There was an error while loading. Please reload this page.
feat(tracing): Move tracing code to internal package - #7451
Merged
AbhiPrasad merged 7 commits intoMar 14, 2023
Conversation
4 tasks
timfishforce-pushed
the
feat/move-tracing-to-internal
branch
from
March 13, 2023 22:29
07f2d8f to
3f527c9Comparetimfish
marked this pull request as ready for review
March 14, 2023 15:32
AbhiPrasad
suggested changes
Mar 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
…nto feat/move-tracing-to-internal
| "@sentry/core": "7.43.0", | ||
| "@sentry/types": "7.43.0", | ||
| "@sentry/utils": "7.43.0", | ||
| "tslib": "^1.9.3" |
Contributor
There was a problem hiding this comment.
Think we still need tslib here?
AbhiPrasad
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #7445 which needs to be merged first.
Ref #5815
@sentry/tracingtotracing-internaltracing-internalBrowserTracingis exported separately fromIntegrationsintracing-internalfor tree-shakingI guess there could be a further PR after this to do some more cleanup, like moving the definition of
Integrationsfromtracing-internalto@sentry/tracing.