Skip to content

fix(loader): Ensure JS loader works with tracing & add tests - #7662

Merged
mydea merged 4 commits into
developfrom
fn/loader-playwright-tests
Mar 31, 2023
Merged

fix(loader): Ensure JS loader works with tracing & add tests#7662
mydea merged 4 commits into
developfrom
fn/loader-playwright-tests

Conversation

@mydea

@mydeamydea commented Mar 30, 2023

Copy link
Copy Markdown
Member

This adds some new integration tests to test the JS loader, making sure the behavior is actually as expected.
This is especially important for the newer loader variants, potentially including tracing & replay.

Some small adjustments to tracing were necessary to ensure it works together with the loader.

@mydea
mydea requested a review from AbhiPrasadMarch 30, 2023 07:43
@mydeamydea self-assigned this Mar 30, 2023
@github-actions

github-actionsBot commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.66 KB (+0.22% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)64.53 KB (+0.21% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.2 KB (+0.25% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)56.91 KB (+0.24% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.57 KB (+0.19% 🔺)
@sentry/browser - Webpack (minified)72.13 KB (+0.19% 🔺)
@sentry/react - Webpack (gzipped + minified)21.6 KB (+0.2% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)52.09 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)28.26 KB (+0.18% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.45 KB (+0.18% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.78 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.86 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)63.5 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)56.54 KB (+0.08% 🔺)

@mydea
mydeaforce-pushed the fn/loader-playwright-tests branch from bdc04f4 to d8b5b1aCompareMarch 30, 2023 12:55
@mydea
mydea marked this pull request as ready for review March 30, 2023 14:57
@mydea
mydeaforce-pushed the fn/loader-playwright-tests branch from d8b5b1a to 026a554CompareMarch 30, 2023 14:57
@mydeamydea changed the title test(loader): Add integration tests for JS loader behavior fix(loader): Ensure JS loader works with tracing & add testsMar 30, 2023
@mydea
mydeaforce-pushed the fn/loader-playwright-tests branch from 026a554 to a31fe4eCompareMarch 31, 2023 05:31
@mydea
mydeaforce-pushed the fn/loader-playwright-tests branch from ca01711 to 5dfccc6CompareMarch 31, 2023 08:32
@mydea
mydea merged commit 8af854c into developMar 31, 2023
@mydea
mydea deleted the fn/loader-playwright-tests branch March 31, 2023 09:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad