Skip to content

feat(loader): Ensure default integrations are added & work for performance - #46995

Merged
mydea merged 1 commit into
masterfrom
fn/loader-script-fixes
Apr 6, 2023
Merged

feat(loader): Ensure default integrations are added & work for performance#46995
mydea merged 1 commit into
masterfrom
fn/loader-script-fixes

Conversation

@mydea

@mydeamydea commented Apr 6, 2023

Copy link
Copy Markdown
Member

This re-implements parts of the reverted #46447.

This updates the loader script to:

The other part is #46994 - this kind-of depends on this as without this the integrations will not be added (as the sample rates are not set). However they are only indirectly linked and can be merged/deployed separately.

Verification steps

  • I verified both the min & and full loader script generated are ES5 compliant with es-check
  • Tried in a local test app with the min & full loader script, both without performance/replay, as well as with them.
  • I put the generated min. loader script into the JS SDK integration tests

@mydea
mydea requested a review from AbhiPrasadApril 6, 2023 07:57
@mydeamydea self-assigned this Apr 6, 2023
@github-actionsgithub-actionsBot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 6, 2023
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@mydeamydea added this to the JavaScript SDK Dynamic Loader milestone Apr 6, 2023
@AbhiPrasadAbhiPrasad removed the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2023
@mydea
mydeaforce-pushed the fn/loader-script-fixes branch from 4152107 to b20b711CompareApril 6, 2023 09:22
@github-actionsgithub-actionsBot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 6, 2023

@AbhiPrasadAbhiPrasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems to break when I ran in a local app! Let's :shipit:

@mydea
mydea merged commit fe14ec2 into masterApr 6, 2023
@mydea
mydea deleted the fn/loader-script-fixes branch April 6, 2023 09:45
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: BackendAutomatically applied to PRs that change backend componentsScope: FrontendAutomatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad