[Experiment] New Scopes by antonpirker · Pull Request #2597 · getsentry/sentry-python

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker · 2023-12-14T13:35:11Z

All PRs labeled with scope refactor in one branch.

…y-python into antonpirker/refactor-hub

…reaks them

…continue-trace

…-capture

…ctor-hub-tracing

…ctor-hub-transaction-span-continue-trace

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…ntextvars

…scopes the hub is removed and the root level API directly calls it on the scope

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

…copes

…e' into experiment-new-scopes

…ment-new-scopes

antonpirker · 2023-12-19T13:19:16Z

Closing in favor of
#2609
#2610

antonpirker added 30 commits November 29, 2023 16:08

Moved get_integration from Hub to Client
f2a4a3a

Moved add_breadcrumb from Hub to Scope
4869365

Moved session functions from Hub to Scope
e5f9e9d

Fixed import
a338099

Fixed Python 2.7 syntax
d900a1b

Merge branch 'master' into antonpirker/refactor-hub
0afb3ab

Give the client to the scope function. Want to establish a pattern.
fe77d04

Merge branch 'antonpirker/refactor-hub' of github.com:getsentry/sentr…
4ba7dce
…y-python into antonpirker/refactor-hub

Moved capture_* functions from Hub to Client
b15613a

Renamed scope_args to scope_kwargs
8331bd0

oops
ce1759f

preserve old behavior when called from client directly (not from hub)
9a08b6e

update test
f9b8d5a

Moved trancing related functions from Hub to Scope
232ce23

Sort imports
fc95050

Fixed some tests
b0b3cec

Fixed test
dec7dbf

Trying to fix broken tests because some something was released that b…
cfd3d54
…reaks them

fix aiohttp tests
ea13b55

Moved start_transaction, start_span and continue_trace from Hub to Scope
802021e

Merge branch 'master' into antonpirker/refactor-hub-tracing
812c791

Merge branch 'master' into antonpirker/refactor-hub-transaction-span-…
92c1919
…continue-trace

Merge branch 'master' into antonpirker/refactor-hub-capture
d233ae5

Merge branch 'master' into antonpirker/refactor-hub
2932adc

Merge branch 'antonpirker/refactor-hub' into antonpirker/refactor-hub…
3a7af73
…-capture

Merge branch 'antonpirker/refactor-hub-capture' into antonpirker/refa…
c3baed0
…ctor-hub-tracing

Merge branch 'antonpirker/refactor-hub-tracing' into antonpirker/refa…
03f1df3
…ctor-hub-transaction-span-continue-trace

Fixed import
5cf788f

Fix
fec7bad

fixed import
34d91ac

antonpirkerand others added 25 commits December 7, 2023 11:05

Make linter happy
6439f5e

Fixed return value
2a01475

_update_scope belongs into the scope not the client
bb3250a

Made top_scope separate parameter
3a22dd6

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'feat/new-scopes' into antonpirker/update-threadlocal-co…
4f74e89
…ntextvars

Typing
4ed5f8a

Hub calls capture_* on scope that calls it on client. Later with new …
c78b1f5
…scopes the hub is removed and the root level API directly calls it on the scope

Merge branch 'master' into feat/new-scopes
b4183bd

Merge branch 'feat/new-scopes' into antonpirker/refactor-hub-capture
0901e72

Moved everything to scope and only have capture_event in client
269fd56

small fix
0354065

Updated test
3d5825e

Fixed test
4e78d1f

Fixed test
ba72216

Fixed test for old python
c5a7ae7

Formatting
bbb93e6

Passing the client as separate argument and updating api docs.
12e632d

ApiDocs
eb56a12

Fix
074a9ef

Update sentry_sdk/scope.py
ac3955b
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>

Merge branch 'antonpirker/refactor-hub-tracing' into experiment-new-s…
c446e9c
…copes

Merge branch 'antonpirker/refactor-hub-transaction-span-continue-trac…
75b963f
…e' into experiment-new-scopes

Merge branch 'antonpirker/update-threadlocal-contextvars' into experi…
4565033
…ment-new-scopes

antonpirker added the Do not merge label Dec 14, 2023

Linting fix
a83f2ca

antonpirker closed this Dec 19, 2023

antonpirker deleted the experiment-new-scopes branch January 9, 2025 10:05