(1) Add new scopes related API (but not yet calling it) by antonpirker · Pull Request #2609 · getsentry/sentry-python

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker · 2023-12-19T12:07:33Z

This adds the API for the new Scopes to the code base but does not call/use it.

The ideas behind the new Scopes implementation:

The current and the isolation scope are saved as ContextVars
The global scope is a global variable
In the new context managers with new_scope() and with isolated_scope() the current and/or isolation scope are forked (meaning copied) and given to the code block wrapped with the context manager. On exit of the code block the current and/or isolation scope are reset to the old value that they had before the with block. (This is basically the same functionality as the push and pop scope of the stack in the current implementation)
A forked scope holds a reference to the scope it was forked from (the original_scope). We need this to implement copy-on-write functionality in forked scopes. As long as you do not change the data in the forked scope, all the data in the forked scope is still the same references as in the original scope. If you manipulate the data, a copy of the data is made and this copy is then changed. (implemented in the _copy_on_write decorator, that will be applied to the properties of the Scope when the API is actually implemented. (this PR))
There will always be a client in this implementation. The standard client will be referenced in the global scope. If the SDK is not yet initialized there will also be a client, but it will be a NoopClient meaning it can be used as a normal client, but it will not send any data to Sentry.
There is also the possibility to set a custom client on the Scope (possible on current, isolation and global scope), so one could use multiple clients to send data to different targets

There is a follow up PR where the API added in this PR is actually implemented: #2610

Moved some functionality from Hub to Scope or Client: - moved `add_breadcrumb` from Hub to Scope - moved session functions from Hub to Scope - moved `get_integration1` from Hub to Client. This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Each commit is moving one function, so it should be easy to review commit by commit.

…)` (#2570) Improves the capabilities of our threadlocal context variables, we use when no "real" context variables are available (for example in old Python versions) - Adds a no-op [copy_context](https://docs.python.org/3/library/contextvars.html#contextvars.copy_context) function to use in environments without context vars - Adds [reset](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar.reset) functionality to our threadlocal based context vars. This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

Moved some functionality from Hub to Client: - Capture Event: - moved `capture_event` from Hub to Client - created new `capture_event` in Scope that calls `capture_event` in Client - made `capture_event` in Hub call the new `capture_event` in Scope - Capture Exception: - created new `capture_exception` in Scope - made `capture_exception` in Hub call the new one in Scope - Capture Message: - created new `capture_message` in Scope - made `capture_message` in Hub call the new one in Scope - renamed `**scope_args` to `**scope_kwargs` because it contains keyword arguments. - moved `_update_scope` from Hub to Scope and renamed it to `_merge_scopes` This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Its properly easier to reason about this change when checking out the branch than looking at the diff.

Moved some functionality from Hub to Client: - sorted some typing imports - moved `get_traceparent` from Hub to Scope - moved `get_baggage` from Hub to Scope - moved `iter_trace_propagation_headers` from Hub to Scope - moved `trace_propagation_meta` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future.

sl0thentr0py

i need to think some of the scope stuff through later but I already left some comments about the client. We need to clean this up before I'm happy with it.

…on into new-scopes-add-api

Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…lity of the sdk here

Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

…on into new-scopes-add-api

antonpirker · 2024-02-13T08:35:49Z

Closing this PR in favor of #2610

All the changes from this PR are in the linked PR now.

This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible. This change was discussed in this RFC: getsentry/rfcs#122 There is also a small FAQ: https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80 And a Miro board showing how the new scopes manage data: https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892 ### This RP contains - Introduction of global, isolation, and current scope - Deprecation of the Hub - All existing Hub based API still works and is still used by most of our integrations. Under the hood the new Scopes are used. - (this PR now includes all the changes made in the [first PR](#2609) introducing the new API) ### Breaking changes - The Pyramid integration will not capture errors that might happen in `authenticated_userid()` in a custom `AuthenticationPolicy` class. - The parameter `propagate_hub` in `ThreadingIntegration()` was deprecated and renamed to `propagate_scope`.

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

antonpirker added 7 commits December 11, 2023 12:54

Merge branch 'master' into feat/new-scopes
a17cb67

Merge branch 'master' into feat/new-scopes
b4183bd

Added new API
eee394d

antonpirker added the scope refactor label Dec 19, 2023

antonpirker changed the title ~~Add new scopes related API~~(1) Add new scopes related APIDec 19, 2023

antonpirker added 8 commits December 19, 2023 13:14

formatting
5816b54

formatting
7a440fe

formatting
0a40f62

Removed duplicated import
ea8f139

formatting
d9c88e7

formatting
67eea1e

formatting
76d352e

formatting
0feab1a

This was referenced Dec 19, 2023
[Experiment] New scope step3 #2606
Closed
New scope - step 1 #2601
Closed
[Experiment] New Scopes #2597
Closed

antonpirker marked this pull request as ready for review December 20, 2023 09:37

antonpirker requested a review from sl0thentr0py December 20, 2023 09:37

sl0thentr0py requested changes Dec 20, 2023
View reviewed changes

Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/api.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/client.py Outdated
Comment threadsentry_sdk/scope.py Outdated

antonpirker added 7 commits January 9, 2024 14:10

Merge branch 'master' into new-scopes-add-api
db610a8

Merge branch 'master' into feat/new-scopes
cabf8d9

Merge branch 'feat/new-scopes' into new-scopes-add-api
7cc1f86

trigger ci
cce06c7

trigger ci
1f06fbb

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
692a2dc
…on into new-scopes-add-api

Fixed import
9d2a7b1

antonpirker added 2 commits February 6, 2024 15:47

formatting
d3917e0

Merge branch 'feature/new-scopes' into new-scopes-add-api
7189e5e

adinauer reviewed Feb 7, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py
Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

sentrivana reviewed Feb 9, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py

szokeasaurusrex reviewed Feb 9, 2024
View reviewed changes

antonpirkerand others added 12 commits February 12, 2024 09:03

Update sentry_sdk/scope.py
f6cb4ef
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Renamed NoopClient to NonRecordingClient to be more like otel
72365d4

Added some comments
ae39a43

Added the right version number
f908fe8

Added universal lock and use it when changing the global scope
9247623

Added tests for UniversalLock
6be5e5f

Made properties of BaseClient actual properties, not class vars
3b3537f

Fixed default value
27522d0

Do not call async tests in python 2
a821b93

Make it run in old python
fcb3f68

Make it work with old python
161a1ac

Make api consistent
b7c0db5

szokeasaurusrex reviewed Feb 12, 2024
View reviewed changes

Comment threadsentry_sdk/scope.py Outdated
Comment threadsentry_sdk/__init__.py

antonpirkerand others added 4 commits February 12, 2024 15:17

Removed useless universal lock, because locking is not the responsibi…
56b266b
…lity of the sdk here

Apply suggestions from code review
f7f8d42
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io> Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>

Prevent infinite recursion by using default options.
b57cde6

Merge branch 'new-scopes-add-api' of github.com:getsentry/sentry-pyth…
90d8d20
…on into new-scopes-add-api

antonpirker closed this Feb 13, 2024

antonpirker deleted the new-scopes-add-api branch January 9, 2025 10:05

coderabbitaiBot mentioned this pull request May 19, 2026
feat: sentry DSN wiring + metrics shim audit (dead set() removed, 11 new tests) YiAgent/openbot#58
Merged
5 tasks

Uh oh!

Conversation

antonpirker commented Dec 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sl0thentr0py left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonpirker commented Feb 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

antonpirker commented Dec 19, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sl0thentr0py left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antonpirker commented Feb 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

antonpirker commented Dec 19, 2023•
edited
Loading

antonpirker commented Dec 19, 2023•
edited
Loading

antonpirker commented Dec 19, 2023•
edited
Loading

antonpirker commented Dec 19, 2023•
edited
Loading