(2.4) feat(feedback-ui): Add screenshots

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

This PR adds attachment handling in the SDK capture feedback form leaving the image picking to be implemented on the client:

• Adds attachment button
• Adds SDK callbacks for handling attachments
• Implements feedback attachments in the sample app

Note that string attachments are converted to UInt8Array before sending to the server.

Android	iOS

💡 Motivation and Context

Fixes#4337

💚 How did you test it?

CI, Manual testing (example)

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

As discussed we will use the no props configuration in the changelog.

[krystofwoldrich]

The impl looks good, but I would scale the scope down to only allow bytes array for now and remove the conversion. We can extend it later.

[krystofwoldrich]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

[antonis]

@antonis Have you explored the option of taking screenshot of the app and attaching it?

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.
Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

[krystofwoldrich]

I haven't explored this option on the SDK side. My assumption was that the developer may choose to implement this. E.g to capture a screenshot with react-native-view-shot instead of selecting an image with react-native-image-picker as the sample implementation.

Got it. This is nice and flexible, but provides less out of the box value.

Looking at it now I see that we already have captureScreenshot (that convenietly returns Uint8Array) functionality exposed by the native SDKs. I'm not sure if this would be useful though since it will be a screenshot of the feedback form unless we use a screenshot taken before 🤔 Maybe I can explore this on this or a separate PR.

Yes, exactly we already have that function, but as you said taking the screenshot of the form is not useful. But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

[antonis]

Thank you for the feedback @krystofwoldrich 🙇

But especially when combined with the auto inject, since we will be responsible for showing and hiding the form we can, hide the form take the screenshot and then show it again.

This makes sense 👍 I will iterate along the auto-inject functionality.

Note: We might anyway also need to create a base64 representation of the screenshot to be able to show a preview using RN Image tag. Or create a tmp file.

👍

[krystofwoldrich]

Look good! 🚀

Just left two small nits in the comments.

[antonis]

Just left two small nits in the comments.

Thank you once more for the feedback @krystofwoldrich 🙇
I fixed the nits and I'll merge on the feature branch as soon as the CI is 🟢