Uh oh!
There was an error while loading. Please reload this page.
feat: Feedback Widget Beta for React Native - #4435
Merged
Merged
Conversation
* Update the client implementation to use the new capture feedback js api * Updates SDK API * Adds new feedback button in the sample * Adds changelog * Removes unused mock * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Directly use captureFeedback from sentry/core * Use import from core * Fixes imports order lint issue * Fixes build issue * Adds captureFeedback tests from sentry-javascript * Update CHANGELOG.md * Only deprecate client captureUserFeedback * Add simple form UI * Adds basic form functionality * Update imports * Update imports * Remove useState hook to avoid multiple react instances issues * Move types and styles in different files * Removes attachment button to be added back separately along with the implementation * Add basic field validation * Adds changelog * Updates changelog * Updates changelog * Trim whitespaces from the submitted feedback * Adds tests * Renames FeedbackFormScreen to FeedbackForm * Add beta label * Extract default text to constants * Moves constant to a separate file and aligns naming with JS * Adds input text labels * Close screen before sending the feedback to minimise wait time Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Rename file for consistency * Flatten configuration hierarchy and clean up * Align required values with JS * Use Sentry user email and name when set * Simplifies email validation * Show success alert message * Aligns naming with JS and unmounts the form by default * Use the minimum config without props in the changelog * Adds development not for unimplemented function * Show email and name conditionally * Adds sentry branding (png logo) * Adds sentry logo resource * Add assets in module exports * Revert "Add assets in module exports" This reverts commit 5292475. * Revert "Adds sentry logo resource" This reverts commit d6e9229. * Revert "Adds sentry branding (png logo)" This reverts commit 8c56753. * Add last event id * Mock lastEventId * Adds beta note in the changelog * Updates changelog * Align colors with JS * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Use regular fonts for both buttons * Handle keyboard properly * Adds an option on whether the email should be validated * Merge properties only once * Loads current user data on form construction * Remove unneeded extra padding * Fix background color issue * Fixes changelog typo * Updates styles background color Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Use defaultProps * Correct defaultProps * Adds test to verify when getUser is called * (2.2) feat: Add Feedback Form UI Branding logo (#4357) * Adds sentry branding logo as a base64 encoded png --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Autoinject feedback form (#4370) * Align changelog entry * Update changelog * Revert "Autoinject feedback form (#4370)" This reverts commit da0e3ea. --------- Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Contributor
|
10 tasks
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9dabcce | 485.63 ms | 483.54 ms | -2.09 ms |
| ad6c299 | 375.94 ms | 382.02 ms | 6.08 ms |
| 0ebca77 | 414.93 ms | 444.49 ms | 29.56 ms |
| 05b43ab | 438.67 ms | 496.19 ms | 57.52 ms |
| 70caa60+dirty | 299.00 ms | 321.02 ms | 22.02 ms |
| 9282172 | 486.12 ms | 467.70 ms | -18.42 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| 13f280b | 486.16 ms | 472.45 ms | -13.71 ms |
| 1faf8e3 | 449.18 ms | 432.08 ms | -17.10 ms |
| 15c80ab+dirty | 336.27 ms | 350.58 ms | 14.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9dabcce | 17.74 MiB | 20.09 MiB | 2.36 MiB |
| ad6c299 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 0ebca77 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
| 05b43ab | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 70caa60+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
| 9282172 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 13f280b | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 1faf8e3 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 15c80ab+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
Previous results on branch: feedback-ui
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df05370 | 477.62 ms | 491.63 ms | 14.00 ms |
| b74349e | 406.08 ms | 400.88 ms | -5.20 ms |
| bc11245 | 435.30 ms | 421.73 ms | -13.58 ms |
| cebae56 | 334.43 ms | 353.88 ms | 19.45 ms |
| 9402883 | 448.53 ms | 468.73 ms | 20.20 ms |
| e5d5735 | 452.70 ms | 453.04 ms | 0.34 ms |
| 0459aee | 491.48 ms | 486.13 ms | -5.35 ms |
| 77e88fc | 478.48 ms | 487.21 ms | 8.73 ms |
| 6b1624f | 462.78 ms | 465.13 ms | 2.35 ms |
| 0325426 | 477.32 ms | 457.43 ms | -19.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df05370 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| b74349e | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| bc11245 | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| cebae56 | 17.75 MiB | 20.12 MiB | 2.38 MiB |
| 9402883 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| e5d5735 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 0459aee | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 77e88fc | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 6b1624f | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 0325426 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe8312+dirty | 389.98 ms | 421.46 ms | 31.48 ms |
| 52a8031+dirty | 330.72 ms | 358.76 ms | 28.03 ms |
| cdf2bdf+dirty | 391.69 ms | 461.14 ms | 69.45 ms |
| 9c48b2c+dirty | 270.82 ms | 321.12 ms | 50.30 ms |
| 0677344+dirty | 288.40 ms | 391.44 ms | 103.04 ms |
| 83f6f6c+dirty | 442.82 ms | 487.48 ms | 44.66 ms |
| c6f01ea+dirty | 379.95 ms | 439.35 ms | 59.40 ms |
| 488c9c5+dirty | 448.98 ms | 531.62 ms | 82.64 ms |
| c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
| 690220d+dirty | 492.10 ms | 473.88 ms | -18.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5fe8312+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 52a8031+dirty | 7.15 MiB | 8.09 MiB | 965.95 KiB |
| cdf2bdf+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 9c48b2c+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
| 0677344+dirty | 7.15 MiB | 8.07 MiB | 949.80 KiB |
| 83f6f6c+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| c6f01ea+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 488c9c5+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
| 690220d+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
Previous results on branch: feedback-ui
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8cb898b+dirty | 393.33 ms | 416.20 ms | 22.87 ms |
| 894ebb0+dirty | 417.81 ms | 499.74 ms | 81.93 ms |
| 6b1624f+dirty | 382.17 ms | 441.00 ms | 58.83 ms |
| cebae56+dirty | 353.30 ms | 344.79 ms | -8.51 ms |
| 77e88fc+dirty | 358.67 ms | 346.20 ms | -12.47 ms |
| 0459aee+dirty | 424.10 ms | 466.63 ms | 42.53 ms |
| e5d5735+dirty | 377.37 ms | 430.04 ms | 52.67 ms |
| 9402883+dirty | 436.49 ms | 518.94 ms | 82.45 ms |
| 0325426+dirty | 418.89 ms | 485.00 ms | 66.11 ms |
| d1a10a1+dirty | 364.43 ms | 362.98 ms | -1.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8cb898b+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 894ebb0+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 6b1624f+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| cebae56+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 77e88fc+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 0459aee+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| e5d5735+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 9402883+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 0325426+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| d1a10a1+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5446992+dirty | 1273.28 ms | 1276.68 ms | 3.40 ms |
| 8ab11b6+dirty | 1203.23 ms | 1206.02 ms | 2.79 ms |
| 8b86336+dirty | 1219.38 ms | 1230.73 ms | 11.36 ms |
| 1c9e040+dirty | 1226.02 ms | 1221.06 ms | -4.96 ms |
| 83f6f6c+dirty | 1218.33 ms | 1220.27 ms | 1.93 ms |
| 5bb8d5f+dirty | 1235.47 ms | 1237.39 ms | 1.92 ms |
| 7e87527+dirty | 1209.85 ms | 1216.31 ms | 6.46 ms |
| 80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
| 9672577+dirty | 1230.46 ms | 1237.43 ms | 6.97 ms |
| 6a667d6+dirty | 1209.23 ms | 1210.85 ms | 1.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5446992+dirty | 2.36 MiB | 2.88 MiB | 531.94 KiB |
| 8ab11b6+dirty | 2.36 MiB | 3.11 MiB | 759.83 KiB |
| 8b86336+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 1c9e040+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 83f6f6c+dirty | 2.36 MiB | 3.10 MiB | 759.79 KiB |
| 5bb8d5f+dirty | 2.36 MiB | 2.92 MiB | 570.22 KiB |
| 7e87527+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
| 9672577+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 6a667d6+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
Previous results on branch: feedback-ui
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee+dirty | 1232.82 ms | 1231.19 ms | -1.63 ms |
| d1a10a1+dirty | 1223.68 ms | 1230.31 ms | 6.63 ms |
| e42816c+dirty | 1211.29 ms | 1219.65 ms | 8.37 ms |
| 0325426+dirty | 1228.88 ms | 1229.92 ms | 1.04 ms |
| b74349e+dirty | 1206.13 ms | 1221.65 ms | 15.53 ms |
| e5d5735+dirty | 1222.02 ms | 1222.22 ms | 0.20 ms |
| 3e4cdf5+dirty | 1222.53 ms | 1224.42 ms | 1.89 ms |
| 6b1624f+dirty | 1224.65 ms | 1225.65 ms | 1.00 ms |
| bc11245+dirty | 1220.78 ms | 1225.65 ms | 4.88 ms |
| 9402883+dirty | 1219.65 ms | 1217.94 ms | -1.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| d1a10a1+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| e42816c+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 0325426+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| b74349e+dirty | 2.63 MiB | 3.76 MiB | 1.12 MiB |
| e5d5735+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 3e4cdf5+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 6b1624f+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| bc11245+dirty | 2.63 MiB | 3.76 MiB | 1.12 MiB |
| 9402883+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4161236+dirty | 1245.33 ms | 1245.63 ms | 0.30 ms |
| 8fe7c9d+dirty | 1227.63 ms | 1245.28 ms | 17.65 ms |
| dadc233+dirty | 1266.52 ms | 1282.55 ms | 16.03 ms |
| 5f03ae9+dirty | 1237.79 ms | 1241.02 ms | 3.23 ms |
| a38594f+dirty | 1226.24 ms | 1225.42 ms | -0.83 ms |
| 1e28462+dirty | 1214.71 ms | 1214.04 ms | -0.67 ms |
| ad6c299+dirty | 1248.50 ms | 1248.88 ms | 0.38 ms |
| 7fd512a+dirty | 1239.41 ms | 1241.50 ms | 2.09 ms |
| 484813b+dirty | 1225.07 ms | 1221.00 ms | -4.07 ms |
| 8d251c2+dirty | 1221.19 ms | 1227.12 ms | 5.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4161236+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 8fe7c9d+dirty | 3.19 MiB | 4.24 MiB | 1.06 MiB |
| dadc233+dirty | 2.92 MiB | 3.40 MiB | 492.53 KiB |
| 5f03ae9+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| a38594f+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 1e28462+dirty | 3.19 MiB | 4.31 MiB | 1.12 MiB |
| ad6c299+dirty | 2.92 MiB | 3.40 MiB | 494.12 KiB |
| 7fd512a+dirty | 2.92 MiB | 3.66 MiB | 758.62 KiB |
| 484813b+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
| 8d251c2+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
Previous results on branch: feedback-ui
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee+dirty | 1233.67 ms | 1239.80 ms | 6.12 ms |
| d1a10a1+dirty | 1228.56 ms | 1229.79 ms | 1.23 ms |
| e42816c+dirty | 1220.08 ms | 1222.46 ms | 2.38 ms |
| 0325426+dirty | 1210.17 ms | 1216.37 ms | 6.20 ms |
| b74349e+dirty | 1214.22 ms | 1225.07 ms | 10.84 ms |
| e5d5735+dirty | 1217.78 ms | 1221.80 ms | 4.02 ms |
| 3e4cdf5+dirty | 1213.36 ms | 1221.31 ms | 7.95 ms |
| 6b1624f+dirty | 1224.12 ms | 1220.73 ms | -3.39 ms |
| bc11245+dirty | 1229.67 ms | 1224.77 ms | -4.90 ms |
| 9402883+dirty | 1217.71 ms | 1213.02 ms | -4.69 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| d1a10a1+dirty | 3.19 MiB | 4.32 MiB | 1.14 MiB |
| e42816c+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 0325426+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| b74349e+dirty | 3.19 MiB | 4.32 MiB | 1.14 MiB |
| e5d5735+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 3e4cdf5+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 6b1624f+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| bc11245+dirty | 3.19 MiB | 4.32 MiB | 1.14 MiB |
| 9402883+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
* Update the client implementation to use the new capture feedback js api * Updates SDK API * Adds new feedback button in the sample * Adds changelog * Removes unused mock * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Directly use captureFeedback from sentry/core * Use import from core * Fixes imports order lint issue * Fixes build issue * Adds captureFeedback tests from sentry-javascript * Update CHANGELOG.md * Only deprecate client captureUserFeedback * Add simple form UI * Adds basic form functionality * Update imports * Update imports * Remove useState hook to avoid multiple react instances issues * Move types and styles in different files * Removes attachment button to be added back separately along with the implementation * Add basic field validation * Adds changelog * Updates changelog * Updates changelog * Trim whitespaces from the submitted feedback * Adds tests * Adds attachment button UI * Adds changelog * Add attachment handling based on the client implementation * Reduce render method complexity * Adds test for attachment button visibility * Format code * Pick image with react-native-image-picker * Convert base64 string to Uint8Array before sending * Updates changelog * Renames FeedbackFormScreen to FeedbackForm * Add beta label * Extract default text to constants * Moves constant to a separate file and aligns naming with JS * Adds input text labels * Close screen before sending the feedback to minimise wait time Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Rename file for consistency * Flatten configuration hierarchy and clean up * Align required values with JS * Use Sentry user email and name when set * Simplifies email validation * Show success alert message * Aligns naming with JS and unmounts the form by default * Use the minimum config without props in the changelog * Adds development not for unimplemented function * Show email and name conditionally * Adds sentry branding (png logo) * Adds sentry logo resource * Add assets in module exports * Revert "Add assets in module exports" This reverts commit 5292475. * Revert "Adds sentry logo resource" This reverts commit d6e9229. * Revert "Adds sentry branding (png logo)" This reverts commit 8c56753. * Add last event id * Mock lastEventId * Remove changelog * Reverse unrelated change * Adds beta note in the changelog * Updates changelog * Align colors with JS * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Use regular fonts for both buttons * Handle keyboard properly * Adds an option on whether the email should be validated * Merge properties only once * Loads current user data on form construction * Remove unneeded extra padding * Fix background color issue * Fixes changelog typo * Updates styles background color Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Use defaultProps * Correct defaultProps * Adds test to verify when getUser is called * Add default value in doc comment Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Add a more clear doc comment Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * (2.2) feat: Add Feedback Form UI Branding logo (#4357) * Adds sentry branding logo as a base64 encoded png --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Autoinject feedback form (#4370) * Align changelog entry * Update changelog * Use AddScreenshot naming * Allow only Uint8Array for screenshots * Rename callback parameter * Adds snapshot tests for screenshot button * Rename screenshot button for clarity * Use a library to get the Uint8Array --------- Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
# Conflicts: # CHANGELOG.md
* Auto-inject feedback form * Temporarily disable sample rotating indicator * Revert "Temporarily disable sample rotating indicator" This reverts commit db407ce. * Wrap Modal in a View * Handles Android back button * Make modal style configurable * Print an error when the modal is not supported * Add changelog * Adds tests * Get major, minor version with deconstruct declaration Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Remove if condition Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> * Prettier * Fix test import --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
6 tasks
--------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # samples/react-native/package.json # yarn.lock
# Conflicts: # CHANGELOG.md
26 tasks
* Disable bouncing * Add modal ui appearance * Update snapshot tests * Fix bottom margin * Fix sheet height * Remove extra modal border * Do not expose modal styles * Animate background color * Avoid keyboard in modal * Use Image Picker interface matching `expo-image-picker` and `react-native-image-picker` * Update samples to pass the ImagePicker library implementation * Get image data from uri * Add early return and dev note * Adds tests * Adds sample expo plugin configuration * Update media type for expo * Update media type for rn * Add native implementation for getDataFromUri * Bumped to the latest react-native-image-picker version 8 * Add missing null in return type
# Conflicts: # CHANGELOG.md
* chore(feedback): Use `Widget` instead of `Form` * fix * fix lint --------- Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>
* chore(feedback): Improve widget animations * add comment * when widget is about to be shown it should not animate slide down
* Save form state for unsubmitted data * Omit isVisible from state * Save/clear form state on unmount * Pass the missing attachment parameter in the onSubmitSuccess * Use instance variable for _didSubmitForm * Fixes lint issue
* Save form state for unsubmitted data * Show selected screenshot * Omit isVisible from state * Save/clear form state on unmount * Pass the missing attachment parameter in the onSubmitSuccess * Use instance variable for _didSubmitForm * Fixes lint issue * Fix merge issue
…4546) * Save form state for unsubmitted data * Show selected screenshot * Use image uri instead of UInt8Array in onAddScreenshot callback * Omit isVisible from state * Save/clear form state on unmount * Pass the missing attachment parameter in the onSubmitSuccess * Use only the uri parameter for the onAddScreenshot callback * Use instance variable for _didSubmitForm * Fixed callback function parameter name for clarity Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Fixes lint issue --------- Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
# Conflicts: # CHANGELOG.md
* Save form state for unsubmitted data * Show selected screenshot * Use image uri instead of UInt8Array in onAddScreenshot callback * Omit isVisible from state * Save/clear form state on unmount * Pass the missing attachment parameter in the onSubmitSuccess * Use only the uri parameter for the onAddScreenshot callback * Handle attachments on the web * Use window for showing alerts on the web * Disable keyboard handling on the web * Use instance variable for _didSubmitForm * Fixed callback function parameter name for clarity Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> * Fixes lint issue * Use RN_GLOBAL_OBJ for web alert --------- Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
* Align secondary buttons with the web * Update snapshots
antonis
marked this pull request as ready for review
February 21, 2025 07:35
antonis
requested review from
krystofwoldrich and lucas-zimerman
as code ownersFebruary 21, 2025 07:35
krystofwoldrich
approved these changes
Feb 21, 2025
krystofwoldrich
left a comment
Contributor
There was a problem hiding this comment.
All merges into the feature branch were approved individually. So I'm approving this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR contains reviewed PRs for the feedback widget:
Documentation
💡 Motivation and Context
Fixes#4302
💚 How did you test it?
CI and manual testing of individual PRs
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps