(2.1) Handles captureFeedback errors

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #4328

📜 Description

• Handles captureFeedback errors
• Aligns with the JS callbacks API by adding the onFormOpen, onSubmitSuccess, onSubmitError, onFormSubmitted

💡 Motivation and Context

Fixes#4359

💚 How did you test it?

Manual testing, Unit tests

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[krystofwoldrich]

The transport in mobile SDK works differently than the JS transport, and we currently don't have the response available, so the sendFeedback will still throw event after the fix in JS.

See impl of sendEnvelope in RN

sentry-react-native/packages/core/src/js/client.ts

Line 132 in 18ce5e8

returnPromise.resolve({});

---

I think we should avoid checking the connection before send, because the native transport handles that (it stores the envelope offline and tries to send it later).

---

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

[antonis]

Thank you for the feedback @krystofwoldrich and the explanation on why not to use sendFeedback 🙇

We can just try catch our current captureFeedback api for the on error call back. And note in the docs that if the device is offline the envelope is sent later.

Makes sense 👍 Updated with c014ccc

[lucas-zimerman]

Looks good to me! Thank you for the PR!

[krystofwoldrich]

Thank you for all the changes and refs.

Looks good! 🚀