feat(feedback): Report a Bug button by antonis · Pull Request #4378 · getsentry/sentry-react-native

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonis · 2024-12-16T12:08:16Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Targeting feedback-ui-2 branch

PR Chain:

📜 Description

Implements feedback button that launches the feedback widget using the auto-injected feedback widget

The button is shown with Sentry.showFeedbackButton() and hidden with Sentry.hideFeedbackButton() provided that the app is wrapped (Sentry.wrap(RootComponent)). The button can be styled like:

Sentry.feedbackIntegration({
buttonOptions: {
styles: {
triggerButton: {
marginBottom: 75,
},
},
},
})

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Manual testing with the sample app

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…implementation

antonis · 2025-03-26T17:03:53Z

Thank you for reviewing and your feedback @krystofwoldrich 🙇

I noticed that the button is above the shadow when dismissing the form.

Good catch 👍 Should be fixed after 04f1a8d

Let's also add a dummy button integration to track the usage of the button.

Good point! Added with 7473c58

The web version has a border similar to the form buttons.

Good catch 👍 Added the border with 24b3df0

…ct-Button # Conflicts: # CHANGELOG.md

antonis · 2025-04-03T14:53:53Z

+
+const showFeedbackWidget = (): void => {
+ // eslint-disable-next-line @typescript-eslint/no-var-requires
+ const { showFeedbackWidget } = require('./FeedbackWidgetManager');


The cyclic dependency is properly fixed with a small refactoring in a followup PR #4718

Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

krystofwoldrich

Looks good. Thank you! 🚀

Can you also add the button to the Expo Sample?

antonis · 2025-04-07T09:53:26Z

Thank you for reviewing and all the feedback Krystof 🙇

Can you also add the button to the Expo Sample?

Added with 722114d

⚠️ PR Chain: - 👉 #13512 - #13513 - #13515 ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* Adds feedback button documentation. Part of getsentry/sentry-react-native#4302 Implementation PR: getsentry/sentry-react-native#4378 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.):  - [ ] Other deadline:  - [x] None: Not urgent, can wait up to 1 week+ Should be merged after getsentry/sentry-react-native#4726 is released ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE  Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/) --------- Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com> Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

antonisand others added 30 commits November 27, 2024 14:00

Update the client implementation to use the new capture feedback js api
817eac8

Updates SDK API
5370a99

Adds new feedback button in the sample
42e2fa1

Adds changelog
514b102

Removes unused mock
0935bbd

Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Directly use captureFeedback from sentry/core
da0d4ac

Use import from core
3e36c6d

Fixes imports order lint issue
5f3df64

Fixes build issue
71b28e8

Adds captureFeedback tests from sentry-javascript
f9d2b59

Update CHANGELOG.md
d05d531

Only deprecate client captureUserFeedback
2bb104b

Add simple form UI
4339274

Adds basic form functionality
6ce799b

Update imports
f2cefc6

Update imports
694ee33

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33

Remove useState hook to avoid multiple react instances issues
034efde

Move types and styles in different files
67a492d

Removes attachment button to be added back separately along with the …
8eaa61d
…implementation

Add basic field validation
0b88cc5

Adds changelog
ae11b8d

Updates changelog
7f2ca06

Updates changelog
064b6c4

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a

Trim whitespaces from the submitted feedback
e21718a

Adds tests
407f179

Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005

Renames FeedbackFormScreen to FeedbackForm
ddade00

antonis added 3 commits March 26, 2025 18:49

Expose showFeedbackButton/hideFeedbackButton methods
06adadd

Add dummy integration for tracking usage
7473c58

Adds button border
24b3df0

antonis requested a review from krystofwoldrich March 26, 2025 17:04

antonis added 2 commits March 26, 2025 19:33

Fixes tests
10a70a3

Merge branch 'feedback-ui-2' into antonis/4358-Feedback-Form-Autoinje…
b3fe27c
…ct-Button # Conflicts: # CHANGELOG.md

antonis changed the title ~~feat(feedback): Implements Report a Bug button~~feat(feedback): Report a Bug buttonApr 3, 2025

antonis commented Apr 3, 2025
View reviewed changes

This was referenced Apr 3, 2025
ref(feedback): Extracts FeedbackWidgetProvider in a separate file #4718
Merged
feat(feedback): Screenshot button #4714
Merged

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackButton.test.tsx Outdated

krystofwoldrich reviewed Apr 7, 2025
View reviewed changes

Comment threadpackages/core/test/feedback/FeedbackWidgetManager.test.tsx Outdated

antonisand others added 4 commits April 7, 2025 11:54

Rename FeedbackButtonProps in tests for clarity
fc01d8c

Add missing function call in test
cbff8fa
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>

Merge branch 'antonis/4358-Feedback-Form-Autoinject-Button' ofhttps:…
28efb28
…//github.com/getsentry/sentry-react-native into antonis/4358-Feedback-Form-Autoinject-Button

Adds missing semicolon in test
e89edea

krystofwoldrich approved these changes Apr 7, 2025
View reviewed changes

Adds feedback button in expo app
722114d

antonis merged commit 1bb4e34 into feedback-ui-2Apr 7, 2025

antonis deleted the antonis/4358-Feedback-Form-Autoinject-Button branch April 7, 2025 10:01

This was referenced Apr 7, 2025
feat(feedback): Feedback Widget Drop 2 #4726
Merged
Show Report Feedback on Shake #4735
Closed
Show Report button when screenshot taken #4736
Closed
fix(feedback): Fixes accessibility issue on iOS #4739
Merged

antonis mentioned this pull request Apr 25, 2025
RN: Adds feedback button doc getsentry/sentry-docs#13512
Merged
6 tasks

Uh oh!

Uh oh!

Conversation

antonis commented Dec 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

antonis commented Mar 26, 2025

Uh oh!

antonisApr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

antonis commented Dec 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

antonis commented Mar 26, 2025

Uh oh!

antonisApr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich left a comment

Choose a reason for hiding this comment

Uh oh!

antonis commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

antonis commented Dec 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

antonis commented Mar 26, 2025

Uh oh!

antonisApr 3, 2025

Choose a reason for hiding this comment

antonis commented Dec 16, 2024•
edited
Loading

antonis commented Dec 16, 2024•
edited
Loading

antonis commented Dec 16, 2024•
edited
Loading

antonis commented Dec 16, 2024•
edited
Loading