feat(feedback): Screenshot button - #4714

Merged
antonis merged 196 commits into
feedback-ui-2from
antonis/screenshot-button
Apr 14, 2025
Merged

feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from
antonis/screenshot-button

Conversation

@antonis

@antonisantonis commented Mar 31, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on feat(feedback): Theming

PR Chain:

📜 Description

  • Adds take screenshot button in the feedback widget that:
    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment

⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.

Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4

Feedback widget UI states

enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28

💡 Motivation and Context

Part of #4302

💚 How did you test it?

Sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

antonisand others added 30 commits November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00
This was referenced Apr 9, 2025
Closed
Merged
Merged
antonis
antonis commented Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';

@antonisantonisApr 14, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from antonis/feedback-theme to feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx Outdated
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich reviewed Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx Outdated
});

await waitFor(() => {
const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');

@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change
consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();

@antonisantonisApr 14, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇
Updated with 59597a4

krystofwoldrich
krystofwoldrich approved these changes Apr 14, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.

Thank you.

@antonis
antonis merged commit 4c988a8 into feedback-ui-2Apr 14, 2025
@antonis
antonis deleted the antonis/screenshot-button branch April 14, 2025 13:24
@antonisantonis mentioned this pull request Apr 16, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request Apr 25, 2025
Merged
6 tasks
antonis added a commit to getsentry/sentry-docs that referenced this pull request Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit to getsentry/sentry-docs that referenced this pull request Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit to getsentry/sentry-docs that referenced this pull request Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(feedback): Screenshot button - #4714
Merged
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Apr 14, 2025
Merged
feat(feedback): Screenshot button#4714
antonis merged 196 commits into
feedback-ui-2from 
antonis/screenshot-button
Conversation
@antonis
@antonisantonis
commented
Mar 31, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
Based on feat(feedback): Theming
PR Chain:
📜 Description
  • Adds take screenshot button in the feedback widget that:

    • closes the feedback modal
    • shows the screenshot button
  • Adds screenshot button that captures a screenshot and opens the feedback widget modal with the captured screenshot as attachment
⚠️ Note that the screenshot button is not supported on the web because the captureScreenshot() function is only available on mobile. Support for web environment will be investigated on a separate PR.
Simulator.Screen.Recording.-.iPhone.16e.-.2025-04-03.at.12.52.20.mp4
Feedback widget UI states
enableScreenshot (or imagePicker set)enableTakeScreenshot
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 59Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 20 05
BothScreenshot attached
Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 20Simulator Screenshot - iPhone 16e - 2025-04-07 at 18 17 28
💡 Motivation and Context
Part of #4302
💚 How did you test it?
Sample app
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
antonisand others
added 30 commits
November 27, 2024 14:00
@antonis
Update the client implementation to use the new capture feedback js api
817eac8
@antonis
Updates SDK API
5370a99
@antonis
Adds new feedback button in the sample
42e2fa1
@antonis
Adds changelog
514b102
@antonis
Removes unused mock
0935bbd
@antonis@krystofwoldrich
Update CHANGELOG.md
9ea5496
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
@antonis
Directly use captureFeedback from sentry/core
da0d4ac
@antonis
Use import from core
3e36c6d
@antonis
Fixes imports order lint issue
5f3df64
@antonis
Fixes build issue
71b28e8
@antonis
Adds captureFeedback tests from sentry-javascript
f9d2b59
@krystofwoldrich
Update CHANGELOG.md
d05d531
@antonis
Only deprecate client captureUserFeedback
2bb104b
@antonis
Add simple form UI
4339274
@antonis
Adds basic form functionality
6ce799b
@antonis
Update imports
f2cefc6
@antonis
Update imports
694ee33
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
18b1c33
@antonis
Remove useState hook to avoid multiple react instances issues
034efde
@antonis
Move types and styles in different files
67a492d
@antonis
Removes attachment button to be added back separately along with the …
8eaa61d
…implementation
@antonis
Add basic field validation
0b88cc5
@antonis
Adds changelog
ae11b8d
@antonis
Updates changelog
7f2ca06
@antonis
Updates changelog
064b6c4
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
e2add4a
@antonis
Trim whitespaces from the submitted feedback
e21718a
@antonis
Adds tests
407f179
@antonis
Merge branch 'main' into antonis/3859-newCaptureFeedbackAPI-Form
14ac005
@antonis
Renames FeedbackFormScreen to FeedbackForm
ddade00

This was referenced Apr 9, 2025

Closed

 Merged

 Merged

antonis
antonis
commented
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/src/js/feedback/ScreenshotButton.tsx
import { defaultScreenshotButtonStyles } from './FeedbackWidget.styles';
import { getTheme } from './FeedbackWidget.theme';
import type { ScreenshotButtonProps, ScreenshotButtonStyles, ScreenshotButtonTextConfiguration } from './FeedbackWidget.types';
import { hideScreenshotButton, showFeedbackWidget, showScreenshotButton } from './FeedbackWidgetManager';
@antonisantonisApr 14, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cyclic dep failure is fixed in #4718

Base automatically changed from
antonis/feedback-theme to
feedback-ui-2April 14, 2025 12:29
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
@antonis
Merge branch 'feedback-ui-2' into antonis/screenshot-button
2cdf6c5
# Conflicts:
#	CHANGELOG.md
#	packages/core/src/js/feedback/FeedbackWidget.styles.ts
#	packages/core/src/js/feedback/FeedbackWidgetManager.tsx
#	packages/core/src/js/feedback/integration.ts
#	packages/core/test/feedback/FeedbackWidgetManager.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Apr 14, 2025
View reviewed changes
Comment threadpackages/core/test/feedback/ScreenshotButton.test.tsx
Outdated

 });

 await waitFor(() => {
 const takeScreenshotButtonAfterCapture = queryByText('Remove screenshot');
@krystofwoldrichkrystofwoldrichApr 14, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L: Just fixed the name and double negation not null.

Suggested change

consttakeScreenshotButtonAfterCapture=queryByText('Remove screenshot');
constremoveScreenshotButtonAfterCapture=queryByText('Remove screenshot');
expect(removeScreenshotButtonAfterCapture).toBeTruthy();
@antonisantonisApr 14, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Krystof 🙇

Updated with 59597a4
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one more small comment.
Thank you.
@antonis
antonis
merged commit 4c988a8
into
feedback-ui-2Apr 14, 2025
@antonis
antonis
deleted the

antonis/screenshot-button

branch
April 14, 2025 13:24
@antonisantonis
mentioned this pull request
Apr 16, 2025
 Merged

10 tasks
@antonisantonis
mentioned this pull request
Apr 25, 2025
 Merged

6 tasks
antonis added a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 5, 2025
@antonis@lucas-zimerman@krystofwoldrich
RN: Adds screenshot button documentation (#13515)
53ca31f
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
antonpirker pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jun 6, 2025
@antonis@lucas-zimerman
@krystofwoldrich@antonpirker
RN: Adds screenshot button documentation (#13515)
e7a3a6e
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@antonis@lucas-zimerman
@krystofwoldrich@bitsandfoxes
RN: Adds screenshot button documentation (#13515)
f96dd9d
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->
⚠️ PR Chain:
- #13512
- #13513
- 👉 #13515
## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds screenshot button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR:
getsentry/sentry-react-native#4714
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
Should be merged after
getsentry/sentry-react-native#4726 is released
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
## LEGAL BOILERPLATE
<!-- Sentry employees and contractors can delete or ignore this section.
-->
Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
## EXTRA RESOURCES
- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
---------
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich