fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466

Merged
krystofwoldrich merged 6 commits into
v7from
kw-handle-user-ip-address
Apr 16, 2025
Merged

fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from
kw-handle-user-ip-address

Conversation

@krystofwoldrich

@krystofwoldrichkrystofwoldrich commented Jan 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • Enhancement

Tasks

  • To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  • And stop the Replay auto-fill for Cocoa and RN/JS.

❓ What to do for RN v6?

Map current behavior for RN JS, Cocoa, Android, and Android Native.

PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN

Related JS v9 changes

💡 Motivation and Context

💚 How did you test it?

unit tests

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@krystofwoldrichkrystofwoldrich mentioned this pull request Jan 20, 2025
Merged
@lucas-zimerman

lucas-zimerman commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?

krystofwoldrich added a commit to getsentry/sentry-javascript that referenced this pull request Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich

krystofwoldrich commented Feb 4, 2025

Copy link
Copy Markdown
ContributorAuthor

This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?

Yes, this depends on JS v9, which also means a major version of RN.

timfish
timfish reviewed Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts Outdated
@lucas-zimerman

lucas-zimerman commented Mar 3, 2025

Copy link
Copy Markdown
Collaborator

@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9

@krystofwoldrich
krystofwoldrichforce-pushed the kw-handle-user-ip-address branch from f6555c1 to 7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich changed the base branch from main to v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed the kw-handle-user-ip-address branch from 5d55818 to 5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich changed the base branch from v7 to kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich changed the title fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich

krystofwoldrich commented Apr 15, 2025

Copy link
Copy Markdown
ContributorAuthor

This is ready for a review.

@github-actions

github-actionsBot commented Apr 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB

@github-actions

github-actionsBot commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms

App size

RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB

@github-actions

github-actionsBot commented Apr 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB

@github-actions

github-actionsBot commented Apr 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB

lucas-zimerman
lucas-zimerman reviewed Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman reviewed Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts
Base automatically changed from kw-bump-latest-js to v7April 16, 2025 10:50
antonis
antonis approved these changes Apr 16, 2025
View reviewed changes

@antonisantonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 29876df into v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich deleted the kw-handle-user-ip-address branch April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman
+1 more reviewer
@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}

4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true - #4466
Merged
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Apr 16, 2025
Merged
fix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: true#4466
krystofwoldrich merged 6 commits into
v7from 
kw-handle-user-ip-address
Conversation
@krystofwoldrich
@krystofwoldrichkrystofwoldrich
commented
Jan 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  Enhancement
Tasks
  •  To align the behavior we need to add {{auto}} to RN v5 or upgrade to JS v9
  •  And stop the Replay auto-fill for Cocoa and RN/JS.
❓ What to do for RN v6?
Map current behavior for RN JS, Cocoa, Android, and Android Native.
PlatRelay adds {{auto}}SDK adds {{auto}}
RN JSYESNO
CocoaYESYES
AndroidNOYES
Android NativeNOUNKNOWN
Related JS v9 changes
💡 Motivation and Context
💚 How did you test it?
unit tests
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
@krystofwoldrichkrystofwoldrich
mentioned this pull request
Jan 20, 2025
 Merged

@lucas-zimerman
lucas-zimerman
commented
Jan 27, 2025

Copy link


Copy Markdown

Collaborator
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
krystofwoldrich added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Feb 3, 2025
@krystofwoldrich
chore(browser): Export ipAddress helpers for use in other SDKs (#15079)
3c4df06
- Related to #15008
Export helpers to avoid duplications in sentry/react-native.
- RN PR getsentry/sentry-react-native#4466
@krystofwoldrich
krystofwoldrich
commented
Feb 4, 2025

Copy link


Copy Markdown

ContributorAuthor
This PR depends on JS v9 before releasing? if so will we bump it only on a major version of Sentry React Native?
Yes, this depends on JS v9, which also means a major version of RN.
timfish
timfish
reviewed
Feb 13, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
Outdated

@lucas-zimerman
lucas-zimerman
commented
Mar 3, 2025

Copy link


Copy Markdown

Collaborator
@krystofwoldrich we should point this PR towards v7, where #4568 will be merged, since this depends on JavaScript V9
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
f6555c1 to
7669fb0CompareApril 15, 2025 13:45
@krystofwoldrich
krystofwoldrich
changed the base branch from
main
to
v7April 15, 2025 13:51
@krystofwoldrich
krystofwoldrichforce-pushed
the
kw-handle-user-ip-address
branch
from
5d55818 to
5b1fd7eCompareApril 15, 2025 14:49
@krystofwoldrich
krystofwoldrich
changed the base branch from
v7
to
kw-bump-latest-jsApril 15, 2025 14:50
@krystofwoldrichkrystofwoldrich
changed the title
fix(sdk): Set {{auto}} if user.ip_address is undefinedfix(sdk): Set {{auto}} if user.ip_address is undefined and sendDefaultPii: trueApr 15, 2025
@krystofwoldrich
krystofwoldrich
commented
Apr 15, 2025

Copy link


Copy Markdown

ContributorAuthor
This is ready for a review.
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time364.35 ms368.44 ms4.08 ms
Size7.15 MiB8.29 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time424.23 ms442.98 ms18.75 ms
Size17.75 MiB20.15 MiB2.41 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.38 ms1229.82 ms0.44 ms
Size2.63 MiB3.77 MiB1.14 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
@github-actions
github-actionsBot
commented
Apr 15, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1238.54 ms1235.26 ms-3.29 ms
Size3.19 MiB4.34 MiB1.15 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/src/js/client.ts
lucas-zimerman
lucas-zimerman
reviewed
Apr 15, 2025
View reviewed changes
Comment threadpackages/core/test/client.test.ts

Base automatically changed from
kw-bump-latest-js to
v7April 16, 2025 10:50
antonis
antonis
approved these changes
Apr 16, 2025
View reviewed changes
@antonisantonis
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@krystofwoldrich
krystofwoldrich
merged commit 29876df
into
v7Apr 16, 2025
@krystofwoldrich
krystofwoldrich
deleted the

kw-handle-user-ip-address

branch
April 16, 2025 13:47
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimerman

+1 more reviewer

@timfishtimfishtimfish approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Explicity set user.ip_address: {{auto}}


4 participants

@krystofwoldrich@lucas-zimerman@antonis@timfish