feat: Bump to Sentry Javascript V9 - #4568

Merged
lucas-zimerman merged 34 commits into
v7from
lz/bump/jsv9
Apr 15, 2025
Merged

feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from
lz/bump/jsv9

Conversation

@lucas-zimerman

@lucas-zimermanlucas-zimerman commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR bumps JavaScript to version V9 and also fixes any break changes found.
In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.

Changes handled:

In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.

💡 Motivation and Context

💚 How did you test it?

Sample App, CI, Sentry.io discover

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

  • Update Changelog with breakchanges.
  • Create Migration Doc.

#skip-changelog for now

@github-actions

github-actionsBot commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB

Previous results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms

App size

RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB

@github-actions

github-actionsBot commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms

App size

RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB

Previous results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms

App size

RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB

@github-actions

github-actionsBot commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB

Previous results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms

App size

RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB

@github-actions

github-actionsBot commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB

Baseline results on branch: v7

Startup times

RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms

App size

RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB

Previous results on branch: lz/bump/jsv9

Startup times

RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms

App size

RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB

@antonisantonis mentioned this pull request Feb 19, 2025
Closed
10 tasks
@lucas-zimerman

lucas-zimerman commented Feb 24, 2025

Copy link
Copy Markdown
CollaboratorAuthor

I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK

@antonisantonis mentioned this pull request Feb 25, 2025
Closed
10 tasks
@krystofwoldrich

krystofwoldrich commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

@lucas-zimerman

lucas-zimerman commented Feb 25, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR

krystofwoldrich
krystofwoldrich reviewed Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json Outdated
@krystofwoldrich

krystofwoldrich commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Thank you @lucas-zimerman, now the yarn.lock looks good.

lucas-zimerman
lucas-zimerman commented Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman marked this pull request as ready for review February 25, 2025 18:37
@lucas-zimerman

lucas-zimerman commented Feb 25, 2025

Copy link
Copy Markdown
CollaboratorAuthor

@antonis@krystofwoldrich I'd say now it's ready for review :D

antonis
antonis reviewed Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json Outdated
antonis
antonis reviewed Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts Outdated
krystofwoldrich
krystofwoldrich reviewed Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts Outdated
krystofwoldrich
krystofwoldrich reviewed Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich reviewed Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich reviewed Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts Outdated
krystofwoldrich
krystofwoldrich reviewed Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich

krystofwoldrich commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Overall the PR looks good. Thank you for all the changes.

I have just a few suggestions and some questions to understand the v9 changes.

@krystofwoldrich

krystofwoldrich commented Mar 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Looks good, thank you for all the comments, changes and explanations.

Two things we should do in a follow-up PRs:

One item to finalize this PR:

krystofwoldrich
krystofwoldrich reviewed Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts
This was referenced Apr 7, 2025
Closed
Closed
Closed
@lucas-zimerman

lucas-zimerman commented Apr 7, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Looks good, thank you for all the comments, changes and explanations.

Two things we should do in a follow-up PRs:

* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:

* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542

@antonisantonis mentioned this pull request Apr 8, 2025
Merged
10 tasks
@lucas-zimermanlucas-zimerman mentioned this pull request Apr 9, 2025
Merged
10 tasks
krystofwoldrich
krystofwoldrich approved these changes Apr 14, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.

Looks good!

@lucas-zimerman
lucas-zimerman merged commit 6eaf70f into v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman deleted the lz/bump/jsv9 branch April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich mentioned this pull request May 9, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonisantonisantonis approved these changes
+1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Bump to Sentry Javascript V9 - #4568
Merged
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Apr 15, 2025
Merged
feat: Bump to Sentry Javascript V9#4568
lucas-zimerman merged 34 commits into
v7from 
lz/bump/jsv9
Conversation
@lucas-zimerman
@lucas-zimermanlucas-zimerman
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
This PR bumps JavaScript to version V9 and also fixes any break changes found.

In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.
Changes handled:
In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.
💡 Motivation and Context
💚 How did you test it?
Sample App, CI, Sentry.io discover
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
  •  Update Changelog with breakchanges.
  •  Create Migration Doc.
#skip-changelog for now
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1220.76 ms1214.90 ms-5.86 ms
Size2.63 MiB3.75 MiB1.12 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1231.84 ms1235.49 ms3.65 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty2.63 MiB3.76 MiB1.13 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1216.13 ms1227.20 ms11.08 ms
35eb9e7+dirty1213.46 ms1221.42 ms7.96 ms
71f7309+dirty1222.02 ms1224.81 ms2.79 ms
345e497+dirty1218.83 ms1218.73 ms-0.10 ms
e54b1ed+dirty1227.33 ms1254.46 ms27.14 ms
49f1a9c+dirty1220.19 ms1230.58 ms10.39 ms
e468cd4+dirty1214.60 ms1219.63 ms5.04 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty2.63 MiB3.73 MiB1.10 MiB
35eb9e7+dirty2.63 MiB3.73 MiB1.10 MiB
71f7309+dirty2.63 MiB3.73 MiB1.10 MiB
345e497+dirty2.63 MiB3.68 MiB1.05 MiB
e54b1ed+dirty2.63 MiB3.68 MiB1.05 MiB
49f1a9c+dirty2.63 MiB3.75 MiB1.12 MiB
e468cd4+dirty2.63 MiB3.75 MiB1.12 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time428.71 ms429.00 ms0.29 ms
Size17.75 MiB20.15 MiB2.40 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e478.08 ms467.46 ms-10.63 ms
App size
RevisionPlainWith SentryDiff
9da5c4e17.75 MiB20.16 MiB2.41 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d422.12 ms478.34 ms56.22 ms
71f7309412.45 ms431.62 ms19.18 ms
49f1a9c423.64 ms411.10 ms-12.54 ms
e54b1ed434.79 ms429.52 ms-5.27 ms
e468cd4403.30 ms404.98 ms1.68 ms
345e497397.98 ms423.40 ms25.42 ms
35eb9e7383.45 ms415.65 ms32.21 ms
App size
RevisionPlainWith SentryDiff
987dc4d17.75 MiB20.10 MiB2.36 MiB
71f730917.75 MiB20.10 MiB2.36 MiB
49f1a9c17.75 MiB20.15 MiB2.40 MiB
e54b1ed17.75 MiB20.10 MiB2.36 MiB
e468cd417.75 MiB20.15 MiB2.40 MiB
345e49717.75 MiB20.10 MiB2.36 MiB
35eb9e717.75 MiB20.10 MiB2.36 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time383.39 ms391.12 ms7.73 ms
Size7.15 MiB8.41 MiB1.26 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty399.70 ms407.34 ms7.64 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty7.15 MiB8.42 MiB1.27 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
49f1a9c+dirty408.02 ms399.80 ms-8.22 ms
e54b1ed+dirty435.06 ms429.19 ms-5.87 ms
e468cd4+dirty382.67 ms399.64 ms16.97 ms
987dc4d+dirty411.89 ms418.60 ms6.71 ms
345e497+dirty375.33 ms377.23 ms1.90 ms
71f7309+dirty361.15 ms369.90 ms8.75 ms
35eb9e7+dirty426.84 ms453.53 ms26.69 ms
App size
RevisionPlainWith SentryDiff
49f1a9c+dirty7.15 MiB8.41 MiB1.26 MiB
e54b1ed+dirty7.15 MiB8.37 MiB1.22 MiB
e468cd4+dirty7.15 MiB8.41 MiB1.26 MiB
987dc4d+dirty7.15 MiB8.37 MiB1.22 MiB
345e497+dirty7.15 MiB8.37 MiB1.22 MiB
71f7309+dirty7.15 MiB8.37 MiB1.22 MiB
35eb9e7+dirty7.15 MiB8.37 MiB1.22 MiB
@github-actions
github-actionsBot
commented
Feb 19, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1229.55 ms1231.68 ms2.13 ms
Size3.19 MiB4.32 MiB1.13 MiB
Baseline results on branch: v7
Startup times
RevisionPlainWith SentryDiff
9da5c4e+dirty1215.41 ms1226.38 ms10.97 ms
App size
RevisionPlainWith SentryDiff
9da5c4e+dirty3.19 MiB4.33 MiB1.14 MiB
Previous results on branch: lz/bump/jsv9
Startup times
RevisionPlainWith SentryDiff
987dc4d+dirty1209.94 ms1215.25 ms5.31 ms
35eb9e7+dirty1219.31 ms1217.37 ms-1.94 ms
71f7309+dirty1206.00 ms1214.28 ms8.28 ms
345e497+dirty1210.67 ms1207.50 ms-3.17 ms
e54b1ed+dirty1227.90 ms1230.92 ms3.02 ms
49f1a9c+dirty1218.65 ms1217.25 ms-1.40 ms
e468cd4+dirty1230.35 ms1240.34 ms9.99 ms
App size
RevisionPlainWith SentryDiff
987dc4d+dirty3.19 MiB4.30 MiB1.11 MiB
35eb9e7+dirty3.19 MiB4.30 MiB1.11 MiB
71f7309+dirty3.19 MiB4.30 MiB1.11 MiB
345e497+dirty3.19 MiB4.25 MiB1.06 MiB
e54b1ed+dirty3.19 MiB4.25 MiB1.06 MiB
49f1a9c+dirty3.19 MiB4.32 MiB1.13 MiB
e468cd4+dirty3.19 MiB4.32 MiB1.13 MiB
@antonisantonis
mentioned this pull request
Feb 19, 2025
 Closed

10 tasks
@lucas-zimerman
lucas-zimerman
commented
Feb 24, 2025

Copy link


Copy Markdown

CollaboratorAuthor
I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK
@antonisantonis
mentioned this pull request
Feb 25, 2025
 Closed

10 tasks
@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@lucas-zimerman The yarn.lock seems to be completely regenerated.
How have you upgraded to the JS v9?
We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592
The yarn.lock change should be readable as only sentry deps should change.
I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR
krystofwoldrich
krystofwoldrich
reviewed
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

@krystofwoldrich
krystofwoldrich
commented
Feb 25, 2025

Copy link


Copy Markdown

Contributor
Thank you @lucas-zimerman, now the yarn.lock looks good.
lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025
View reviewed changes
Comment threadpackages/core/src/js/tracing/span.ts
@lucas-zimerman
lucas-zimerman
marked this pull request as ready for review
February 25, 2025 18:37
@lucas-zimerman
lucas-zimerman
commented
Feb 25, 2025

Copy link


Copy Markdown

CollaboratorAuthor
@antonis@krystofwoldrich I'd say now it's ready for review :D
antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/package.json
Outdated

antonis
antonis
reviewed
Feb 26, 2025
View reviewed changes
Comment threadpackages/core/src/js/integrations/reactnativeerrorhandlers.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/feedback.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/addTracingExtensions.test.ts
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/timetodisplaynative.web.test.tsx
krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/utils/safe.test.ts
Outdated

krystofwoldrich
krystofwoldrich
reviewed
Mar 12, 2025
View reviewed changes
Comment threadpackages/core/test/tracing/integrations/userInteraction.test.ts
@krystofwoldrich
krystofwoldrich
commented
Mar 12, 2025

Copy link


Copy Markdown

Contributor
Overall the PR looks good. Thank you for all the changes.
I have just a few suggestions and some questions to understand the v9 changes.
@krystofwoldrich
krystofwoldrich
commented
Mar 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
One item to finalize this PR:
krystofwoldrich
krystofwoldrich
reviewed
Mar 20, 2025
View reviewed changes
Comment threadpackages/core/src/js/transports/encodePolyfill.ts

This was referenced Apr 7, 2025

Closed


Closed


Closed

@lucas-zimerman
lucas-zimerman
commented
Apr 7, 2025

Copy link


Copy Markdown

CollaboratorAuthor
Looks good, thank you for all the comments, changes and explanations.
Two things we should do in a follow-up PRs:
* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)
* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)
* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:
* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542
@antonisantonis
mentioned this pull request
Apr 8, 2025
 Merged

10 tasks
@lucas-zimermanlucas-zimerman
mentioned this pull request
Apr 9, 2025
 Merged

10 tasks
krystofwoldrich
krystofwoldrich
approved these changes
Apr 14, 2025
View reviewed changes
@krystofwoldrichkrystofwoldrich
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping RN to JS v9.
Looks good!
@lucas-zimerman
lucas-zimerman
merged commit 6eaf70f
into
v7Apr 15, 2025
@lucas-zimerman
lucas-zimerman
deleted the

lz/bump/jsv9

branch
April 15, 2025 08:26
@krystofwoldrichkrystofwoldrich
mentioned this pull request
May 9, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@antonisantonisantonis approved these changes

+1 more reviewer

@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lucas-zimerman@krystofwoldrich@antonis