chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(ci): Fixes iOS binary size diff failure - #4489

Merged
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size
Jan 30, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4489
krystofwoldrich merged 2 commits into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently (though marginally) due to small changes in the size of the app.

For example it passes on the feedback widget feature branch

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

but fails on the autoinject branch that does not include major code changes or large assets.

INFO: App io.sentry.rn.perf-test-app-sentry is 1.08 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1127476 should be < 1126400

On main the test marginally passes:

INFO: App io.sentry.rn.perf-test-app-sentry is 1.07 MiB larger than app io.sentry.rn.perf-test-app-plain
BinarySizeTest > app size() PASSED

With this PR I suggest bumping the diff by 100KB which should give us some space for new SDK features without compromising the ability of the test to detect any unreasonable bump of the binary size.

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time342.82 ms335.92 ms-6.90 ms
Size17.75 MiB20.11 MiB2.37 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
cdf2f33469.46 ms462.17 ms-7.29 ms
7bc4d75488.76 ms473.28 ms-15.48 ms
e22745e462.66 ms458.10 ms-4.56 ms
f06c879408.41 ms424.54 ms16.13 ms
e2b64fe316.88 ms330.23 ms13.35 ms
c6f01ea486.20 ms486.98 ms0.77 ms
34aba08328.10 ms342.84 ms14.74 ms
b95b8af454.05 ms454.53 ms0.48 ms
d8e8c67448.79 ms438.70 ms-10.09 ms
52c0562453.04 ms434.71 ms-18.33 ms

App size

RevisionPlainWith SentryDiff
cdf2f3317.74 MiB20.08 MiB2.34 MiB
7bc4d7517.74 MiB20.08 MiB2.34 MiB
e22745e17.74 MiB20.08 MiB2.34 MiB
f06c87917.73 MiB19.85 MiB2.12 MiB
e2b64fe17.73 MiB19.80 MiB2.07 MiB
c6f01ea17.74 MiB20.10 MiB2.36 MiB
34aba0817.73 MiB19.80 MiB2.07 MiB
b95b8af17.73 MiB20.11 MiB2.37 MiB
d8e8c6717.74 MiB20.10 MiB2.36 MiB
52c056217.73 MiB20.11 MiB2.38 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time469.30 ms614.86 ms145.56 ms
Size7.15 MiB8.38 MiB1.23 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
416f465+dirty407.26 ms451.31 ms44.05 ms
9f0f6c8+dirty365.53 ms419.16 ms53.63 ms
70e6261+dirty395.08 ms408.12 ms13.04 ms
d43a46b+dirty417.65 ms472.98 ms55.33 ms
2ec71da+dirty375.64 ms431.59 ms55.95 ms
12427f4+dirty379.48 ms400.92 ms21.44 ms
5446992+dirty371.61 ms390.00 ms18.39 ms
baa882f+dirty449.30 ms540.40 ms91.10 ms
d0bf494+dirty253.73 ms308.23 ms54.49 ms
9a3ca65+dirty344.96 ms358.92 ms13.96 ms

App size

RevisionPlainWith SentryDiff
416f465+dirty7.15 MiB8.37 MiB1.22 MiB
9f0f6c8+dirty7.15 MiB8.37 MiB1.22 MiB
70e6261+dirty7.15 MiB8.21 MiB1.07 MiB
d43a46b+dirty7.15 MiB8.34 MiB1.19 MiB
2ec71da+dirty7.15 MiB8.38 MiB1.23 MiB
12427f4+dirty7.15 MiB8.12 MiB997.78 KiB
5446992+dirty7.15 MiB8.12 MiB999.45 KiB
baa882f+dirty7.15 MiB8.34 MiB1.19 MiB
d0bf494+dirty7.15 MiB8.04 MiB910.85 KiB
9a3ca65+dirty7.15 MiB8.09 MiB962.83 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.51 ms1230.16 ms7.65 ms
Size3.19 MiB4.25 MiB1.07 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1224.90 ms1231.40 ms6.50 ms
de59d3a+dirty1241.17 ms1249.16 ms8.00 ms
63ed251+dirty1223.27 ms1222.94 ms-0.33 ms
5a22220+dirty1246.18 ms1249.61 ms3.43 ms
416f465+dirty1232.48 ms1233.26 ms0.78 ms
c398f67+dirty1227.31 ms1230.00 ms2.69 ms
1332acb+dirty1243.98 ms1241.12 ms-2.86 ms
8fe7c9d+dirty1227.63 ms1245.28 ms17.65 ms
5f03ae9+dirty1237.79 ms1241.02 ms3.23 ms
9cab16b+dirty1236.10 ms1247.16 ms11.06 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.92 MiB3.44 MiB533.29 KiB
de59d3a+dirty2.92 MiB3.67 MiB772.59 KiB
63ed251+dirty2.92 MiB3.66 MiB757.10 KiB
5a22220+dirty2.92 MiB3.48 MiB575.81 KiB
416f465+dirty2.92 MiB3.67 MiB772.44 KiB
c398f67+dirty2.92 MiB3.60 MiB701.89 KiB
1332acb+dirty2.92 MiB3.67 MiB772.45 KiB
8fe7c9d+dirty3.19 MiB4.24 MiB1.06 MiB
5f03ae9+dirty3.19 MiB4.25 MiB1.06 MiB
9cab16b+dirty2.92 MiB3.64 MiB743.06 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.10 ms1217.38 ms-1.72 ms
Size2.63 MiB3.69 MiB1.06 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
12427f4+dirty1267.15 ms1271.30 ms4.15 ms
de59d3a+dirty1223.73 ms1236.28 ms12.55 ms
63ed251+dirty1232.55 ms1238.77 ms6.22 ms
5a22220+dirty1209.49 ms1220.94 ms11.45 ms
416f465+dirty1221.56 ms1226.48 ms4.92 ms
c398f67+dirty1219.67 ms1225.66 ms5.99 ms
1332acb+dirty1230.53 ms1234.54 ms4.01 ms
8fe7c9d+dirty1241.83 ms1244.35 ms2.51 ms
5f03ae9+dirty1232.29 ms1230.92 ms-1.37 ms
9cab16b+dirty1237.76 ms1234.00 ms-3.76 ms

App size

RevisionPlainWith SentryDiff
12427f4+dirty2.36 MiB2.88 MiB530.38 KiB
de59d3a+dirty2.36 MiB3.11 MiB760.16 KiB
63ed251+dirty2.36 MiB3.10 MiB752.55 KiB
5a22220+dirty2.36 MiB2.92 MiB570.21 KiB
416f465+dirty2.36 MiB3.11 MiB759.80 KiB
c398f67+dirty2.36 MiB3.04 MiB696.27 KiB
1332acb+dirty2.36 MiB3.11 MiB759.86 KiB
8fe7c9d+dirty2.63 MiB3.68 MiB1.04 MiB
5f03ae9+dirty2.63 MiB3.68 MiB1.05 MiB
9cab16b+dirty2.36 MiB3.08 MiB737.23 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review January 28, 2025 11:03
krystofwoldrich
krystofwoldrich approved these changes Jan 30, 2025
View reviewed changes

@krystofwoldrichkrystofwoldrich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich
krystofwoldrich merged commit 1c9e040 into mainJan 30, 2025
@krystofwoldrich
krystofwoldrich deleted the antonis/ci-ios-binary-size branch January 30, 2025 21:31
@antonisantonis mentioned this pull request Apr 28, 2025
Merged
10 tasks
@antonisantonis mentioned this pull request May 7, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanAwaiting requested review from lucas-zimermanlucas-zimerman is a code owner
1 more reviewer
@krystofwoldrichkrystofwoldrichkrystofwoldrich approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@krystofwoldrich