chore(ci): Fixes iOS binary size diff failure - #4817

Merged
antonis merged 1 commit into
mainfrom
antonis/ci-ios-binary-size
May 8, 2025
Merged

chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom
antonis/ci-ios-binary-size

Conversation

@antonis

@antonisantonis commented May 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.

💡 Motivation and Context

I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.

BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Android (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms

App size

RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms

App size

RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB

@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Android (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms

App size

RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms

App size

RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB

@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

iOS (legacy) Performance metrics 🚀

PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms

App size

RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms

App size

RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB

@antonis
antonis marked this pull request as ready for review May 7, 2025 11:25
@github-actions

github-actionsBot commented May 7, 2025

Copy link
Copy Markdown
Contributor

iOS (new) Performance metrics 🚀

PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB

Baseline results on branch: main

Startup times

RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms

App size

RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB

Previous results on branch: antonis/ci-ios-binary-size

Startup times

RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms

App size

RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB

@antonisantonis mentioned this pull request May 7, 2025
Merged
8 tasks
lucas-zimerman
lucas-zimerman approved these changes May 7, 2025
View reviewed changes

@lucas-zimermanlucas-zimerman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.
but for now, LGTM!

@antonis

antonis commented May 8, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time

I agree 🤔

Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴

@antonis
antonis merged commit 1d75738 into mainMay 8, 2025
@antonis
antonis deleted the antonis/ci-ios-binary-size branch May 8, 2025 08:14
@antonisantonis mentioned this pull request Sep 4, 2025
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(ci): Fixes iOS binary size diff failure - #4817
Merged
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
May 8, 2025
Merged
chore(ci): Fixes iOS binary size diff failure#4817
antonis merged 1 commit into
mainfrom 
antonis/ci-ios-binary-size
Conversation
@antonis
@antonisantonis
commented
May 7, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
📢 Type of change
  •  Bugfix
  •  New feature
  •  Enhancement
  •  Refactoring
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that metrics (new, ios) check has started to fail consistently onmain after bumping the iOS SDK.
BinarySizeTest > app size() FAILED
java.lang.AssertionError: 1229276 should be < 1228800
at BinarySizeTest.app size(BinarySizeTest.kt:37)

Notes:
💚 How did you test it?
CI
📝 Checklist
  •  I added tests to verify changes
  •  No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  •  I updated the docs if needed.
  •  I updated the wizard if needed.
  •  All tests passing
  •  No breaking changes
🔮 Next steps
#skip-changelog
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time400.00 ms394.10 ms-5.90 ms
Size17.75 MiB20.13 MiB2.38 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
7fd512a442.18 ms437.57 ms-4.61 ms
3261206476.43 ms465.96 ms-10.48 ms
5bb8d5f431.21 ms459.40 ms28.19 ms
c398f67449.64 ms461.38 ms11.74 ms
1d86dd6405.14 ms411.06 ms5.92 ms
0db0c72372.12 ms386.00 ms13.88 ms
bd0ca38418.14 ms425.96 ms7.82 ms
52a8031+dirty311.55 ms321.37 ms9.82 ms
a18210a455.15 ms530.29 ms75.15 ms
b6f8ea2472.49 ms469.60 ms-2.89 ms
App size
RevisionPlainWith SentryDiff
7fd512a17.74 MiB20.08 MiB2.35 MiB
326120617.75 MiB20.11 MiB2.37 MiB
5bb8d5f17.73 MiB19.93 MiB2.20 MiB
c398f6717.73 MiB19.94 MiB2.21 MiB
1d86dd617.73 MiB19.86 MiB2.12 MiB
0db0c7217.73 MiB19.75 MiB2.02 MiB
bd0ca3817.75 MiB20.13 MiB2.38 MiB
52a8031+dirty17.73 MiB20.04 MiB2.31 MiB
a18210a17.75 MiB20.11 MiB2.36 MiB
b6f8ea217.75 MiB20.11 MiB2.36 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a495.10 ms494.98 ms-0.13 ms
90ec215422.56 ms422.70 ms0.14 ms
1a94d77342.82 ms335.92 ms-6.90 ms
App size
RevisionPlainWith SentryDiff
a202c7a17.75 MiB20.11 MiB2.37 MiB
90ec21517.75 MiB20.15 MiB2.40 MiB
1a94d7717.75 MiB20.11 MiB2.37 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
Android (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time421.60 ms441.74 ms20.14 ms
Size7.15 MiB8.40 MiB1.25 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
d16beca+dirty389.49 ms423.86 ms34.37 ms
e652a2e+dirty368.83 ms360.91 ms-7.91 ms
5852d77+dirty378.83 ms381.89 ms3.06 ms
abb7058+dirty320.78 ms324.08 ms3.30 ms
950b04f+dirty308.66 ms312.69 ms4.03 ms
1c65324+dirty381.10 ms427.26 ms46.16 ms
cc8a6ca+dirty397.63 ms393.60 ms-4.03 ms
cdc3945+dirty428.13 ms443.92 ms15.78 ms
1d7ae00+dirty373.63 ms417.21 ms43.58 ms
79976dd+dirty373.25 ms404.64 ms31.39 ms
App size
RevisionPlainWith SentryDiff
d16beca+dirty7.15 MiB8.37 MiB1.22 MiB
e652a2e+dirty7.15 MiB8.38 MiB1.23 MiB
5852d77+dirty7.15 MiB8.38 MiB1.22 MiB
abb7058+dirty7.15 MiB8.10 MiB980.40 KiB
950b04f+dirty7.15 MiB8.40 MiB1.25 MiB
1c65324+dirty7.15 MiB8.22 MiB1.07 MiB
cc8a6ca+dirty7.15 MiB8.39 MiB1.23 MiB
cdc3945+dirty7.15 MiB8.39 MiB1.23 MiB
1d7ae00+dirty7.15 MiB8.39 MiB1.23 MiB
79976dd+dirty7.15 MiB8.38 MiB1.23 MiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
a202c7a+dirty398.12 ms447.65 ms49.53 ms
90ec215+dirty659.49 ms692.31 ms32.82 ms
1a94d77+dirty469.30 ms614.86 ms145.56 ms
App size
RevisionPlainWith SentryDiff
a202c7a+dirty7.15 MiB8.38 MiB1.23 MiB
90ec215+dirty7.15 MiB8.42 MiB1.26 MiB
1a94d77+dirty7.15 MiB8.38 MiB1.23 MiB
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (legacy) Performance metrics 🚀
PlainWith SentryDiff
Startup time1222.86 ms1222.69 ms-0.16 ms
Size2.63 MiB3.79 MiB1.16 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1266.22 ms1274.84 ms8.62 ms
94fc925+dirty1231.12 ms1223.85 ms-7.27 ms
7d161c0+dirty1215.20 ms1218.64 ms3.43 ms
17c0c2e+dirty1231.45 ms1235.10 ms3.66 ms
e8e44ed+dirty1220.44 ms1216.42 ms-4.02 ms
e1e6bc7+dirty1208.24 ms1221.46 ms13.22 ms
f8fa2ad+dirty1239.08 ms1235.49 ms-3.59 ms
af2c0b0+dirty1201.83 ms1208.94 ms7.11 ms
2501f36+dirty1232.17 ms1232.50 ms0.33 ms
1c65324+dirty1235.17 ms1235.08 ms-0.09 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.36 MiB2.87 MiB520.20 KiB
94fc925+dirty2.63 MiB3.69 MiB1.05 MiB
7d161c0+dirty2.63 MiB3.75 MiB1.12 MiB
17c0c2e+dirty2.63 MiB3.78 MiB1.14 MiB
e8e44ed+dirty2.63 MiB3.76 MiB1.13 MiB
e1e6bc7+dirty2.63 MiB3.78 MiB1.15 MiB
f8fa2ad+dirty2.63 MiB3.78 MiB1.14 MiB
af2c0b0+dirty2.63 MiB3.76 MiB1.13 MiB
2501f36+dirty2.63 MiB3.76 MiB1.13 MiB
1c65324+dirty2.36 MiB3.04 MiB698.64 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1219.10 ms1217.38 ms-1.72 ms
90ec215+dirty1221.18 ms1222.32 ms1.14 ms
a202c7a+dirty1229.63 ms1230.33 ms0.71 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty2.63 MiB3.69 MiB1.06 MiB
90ec215+dirty2.63 MiB3.80 MiB1.17 MiB
a202c7a+dirty2.63 MiB3.69 MiB1.05 MiB
@antonis
antonis
marked this pull request as ready for review
May 7, 2025 11:25
@github-actions
github-actionsBot
commented
May 7, 2025

Copy link


Copy Markdown

Contributor
iOS (new) Performance metrics 🚀
PlainWith SentryDiff
Startup time1219.12 ms1221.65 ms2.53 ms
Size3.19 MiB4.36 MiB1.17 MiB
Baseline results on branch: main
Startup times
RevisionPlainWith SentryDiff
575f9da+dirty1272.00 ms1284.38 ms12.38 ms
94fc925+dirty1231.04 ms1231.60 ms0.55 ms
7d161c0+dirty1239.57 ms1250.46 ms10.89 ms
17c0c2e+dirty1239.76 ms1243.32 ms3.56 ms
e8e44ed+dirty1222.90 ms1219.75 ms-3.15 ms
e1e6bc7+dirty1221.47 ms1237.02 ms15.55 ms
f8fa2ad+dirty1227.51 ms1212.89 ms-14.62 ms
af2c0b0+dirty1229.82 ms1231.41 ms1.59 ms
2501f36+dirty1232.98 ms1227.81 ms-5.17 ms
1c65324+dirty1239.71 ms1239.86 ms0.15 ms
App size
RevisionPlainWith SentryDiff
575f9da+dirty2.92 MiB3.43 MiB524.26 KiB
94fc925+dirty3.19 MiB4.25 MiB1.07 MiB
7d161c0+dirty3.19 MiB4.32 MiB1.13 MiB
17c0c2e+dirty3.19 MiB4.34 MiB1.16 MiB
e8e44ed+dirty3.19 MiB4.33 MiB1.14 MiB
e1e6bc7+dirty3.19 MiB4.35 MiB1.16 MiB
f8fa2ad+dirty3.19 MiB4.35 MiB1.16 MiB
af2c0b0+dirty3.19 MiB4.33 MiB1.14 MiB
2501f36+dirty3.19 MiB4.33 MiB1.14 MiB
1c65324+dirty2.92 MiB3.61 MiB705.56 KiB
Previous results on branch: antonis/ci-ios-binary-size
Startup times
RevisionPlainWith SentryDiff
1a94d77+dirty1222.51 ms1230.16 ms7.65 ms
90ec215+dirty1220.78 ms1226.56 ms5.78 ms
a202c7a+dirty1218.98 ms1215.89 ms-3.09 ms
App size
RevisionPlainWith SentryDiff
1a94d77+dirty3.19 MiB4.25 MiB1.07 MiB
90ec215+dirty3.19 MiB4.37 MiB1.18 MiB
a202c7a+dirty3.19 MiB4.25 MiB1.07 MiB
@antonisantonis
mentioned this pull request
May 7, 2025
 Merged

8 tasks
lucas-zimerman
lucas-zimerman
approved these changes
May 7, 2025
View reviewed changes
@lucas-zimermanlucas-zimerman
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we'll need a different approach for this test if test size keeps increasing over time.

but for now, LGTM!
@antonis
antonis
commented
May 8, 2025•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Maybe in the future we'll need a different approach for this test if test size keeps increasing over time
I agree 🤔
Proceeding with merge since the 100kb bump (to 1300kb) has already landed on the Feedback Widget feature branch and main is 🔴
@antonis
antonis
merged commit 1d75738
into
mainMay 8, 2025
@antonis
antonis
deleted the

antonis/ci-ios-binary-size

branch
May 8, 2025 08:14
@antonisantonis
mentioned this pull request
Sep 4, 2025
 Merged

10 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lucas-zimermanlucas-zimermanlucas-zimerman approved these changes
@krystofwoldrichkrystofwoldrichAwaiting requested review from krystofwoldrich

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@antonis@lucas-zimerman